Skip to contentSkip to conversation

Add i2c support for MediaTek mt8512

PATCH New mingming lee 3 participants 8 messages Oct 16, 2020 – Nov 23, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v3 cover Add i2c support for MediaTek mt8512

From: Mingming Lee <[email protected]>

This patch series adds basic i2c support for MediaTek MT8512 EMMC boards.

---
Changes for v3:
- fixed code veriew note in v2.
- optimize the dma read/write flow in mtk_i2c_do_transfer().
- add Reviewed-by info.

Changes for v2:
- using error number defined in include/linux/errno.h.
- add Mediatek i2c controller driver to ARM MEDIATEK in MAINTAINERS.
- add bindings for mediatek i2c driver.

Mingming Lee (5):
i2c: mediatek: add basic driver support
ARM: dts: Mediatek: add i2c node support for mt8512
configs: mt8512: Enable I2C related configs
dt-binding: i2c: add bindings for mediatek i2c driver
MAINTAINERS: add i2c driver to ARM MEDIATEK

 MAINTAINERS                              |   2 +
 arch/arm/dts/mt8512-bm1-emmc.dts         |  12 +
 arch/arm/dts/mt8512.dtsi                 |  38 +-
 configs/mt8512_bm1_emmc_defconfig        |   8 +-
 doc/device-tree-bindings/i2c/i2c-mtk.txt |  39 ++
 drivers/i2c/Kconfig                      |   8 +
 drivers/i2c/Makefile                     |   1 +
 drivers/i2c/mt_i2c.c                     | 713 +++++++++++++++++++++++++++++++
 8 files changed, 819 insertions(+), 2 deletions(-)
 create mode 100644 doc/device-tree-bindings/i2c/i2c-mtk.txt
 create mode 100644 drivers/i2c/mt_i2c.c
Signature · 1 line
1.8.1.1.dirty
#1 lore raw

PATCH v3 1/5 i2c: mediatek: add basic driver support

From: Mingming Lee <[email protected]>

Add MediaTek I2C basic driver

---
Changes for v3:
- fixed code veriew note in v2
- optimize the dma read/write flow in mtk_i2c_do_transfer()

Changes for v2:
- using error number defined in include/linux/errno.h

---
 drivers/i2c/Kconfig  |   8 +
 drivers/i2c/Makefile |   1 +
 drivers/i2c/mt_i2c.c | 713 +++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 722 insertions(+)
 create mode 100644 drivers/i2c/mt_i2c.c
drivers/i2c/Kconfig +8 -0
index dec6dc9..e217673 100644
@@ -159,6 +159,14 @@ config SYS_I2C_MESON
 	  internal buffer holding up to 8 bytes for transfers and supports
 	  both 7-bit and 10-bit addresses.
 
+config SYS_I2C_MTK
+	bool "MediaTek I2C driver"
+	help
+	  This selects the MediaTek Integrated Inter Circuit bus driver.
+	  The I2C bus adapter is the base for some other I2C client, eg: touch, sensors.
+	  If you want to use MediaTek I2C interface, say Y here.
+	  If unsure, say N.
+
 config SYS_I2C_MXC
 	bool "NXP MXC I2C driver"
 	help
drivers/i2c/Makefile +1 -0
index e851ec4..7227742 100644
@@ -28,6 +28,7 @@ obj-$(CONFIG_SYS_I2C_LPC32XX) += lpc32xx_i2c.o
 obj-$(CONFIG_SYS_I2C_MESON) += meson_i2c.o
 obj-$(CONFIG_SYS_I2C_MVTWSI) += mvtwsi.o
 obj-$(CONFIG_SYS_I2C_MXC) += mxc_i2c.o
+obj-$(CONFIG_SYS_I2C_MTK) += mt_i2c.o
 obj-$(CONFIG_SYS_I2C_NEXELL) += nx_i2c.o
 obj-$(CONFIG_SYS_I2C_OCTEON) += octeon_i2c.o
 obj-$(CONFIG_SYS_I2C_OMAP24XX) += omap24xx_i2c.o
drivers/i2c/mt_i2c.c new file +713 -0

713 lines not on this page · raw message

Signature · 1 line
1.8.1.1.dirty
#2 lore raw

PATCH v3 1/5 i2c: mediatek: add basic driver support

Quoted 12 lines · mingming lee

From: Mingming Lee <[email protected]>

Add MediaTek I2C basic driver

---
Changes for v3:
- fixed code veriew note in v2
- optimize the dma read/write flow in mtk_i2c_do_transfer()

Quoted 8 lines

Changes for v2:
- using error number defined in include/linux/errno.h

---
 drivers/i2c/Kconfig  |   8 +
 drivers/i2c/Makefile |   1 +
 drivers/i2c/mt_i2c.c | 713 +++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 722 insertions(+)
 create mode 100644 drivers/i2c/mt_i2c.c
#3 lore raw

PATCH v3 1/5 i2c: mediatek: add basic driver support

In reply to mingming lee

Hello mingming lee,

Am 16.10.20 um 05:27 schrieb mingming lee:

Quoted 11 lines

From: Mingming Lee <[email protected]>

Add MediaTek I2C basic driver

---
Changes for v3:
- fixed code veriew note in v2
- optimize the dma read/write flow in mtk_i2c_do_transfer()

Quoted 8 lines

Changes for v2:
- using error number defined in include/linux/errno.h

---
 drivers/i2c/Kconfig  |   8 +
 drivers/i2c/Makefile |   1 +
 drivers/i2c/mt_i2c.c | 713 +++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 722 insertions(+)
 create mode 100644 drivers/i2c/mt_i2c.c

Applied your changes to my testtree at:

https://github.com/hsdenx/u-boot-i2c/commits/work

and for this travis build fails with:

https://travis-ci.org/github/hsdenx/u-boot-i2c/jobs/745329353#L1350

aarch64: + mt8512_bm1_emmc
+drivers/i2c/mt_i2c.c: In function 'mtk_i2c_do_transfer':
+drivers/i2c/mt_i2c.c:453:10: error: initialization of 'u32' {aka 'unsigned int'} from 'u8 *' {aka 'unsigned char *'} makes integer from pointer without a cast [-Werror=int-conversion]
+ 453 | writel(msgs->buf, priv->pdmabase + REG_RX_MEM_ADDR);
+ | ^~~~
+arch/arm/include/asm/io.h:122:34: note: in definition of macro 'writel'
+ 122 | #define writel(v,c) ({ u32 __v = v; __iowmb(); __arch_putl(__v,c); __v; })
+ | ^
+drivers/i2c/mt_i2c.c:463:10: error: initialization of 'u32' {aka 'unsigned int'} from 'u8 *' {aka 'unsigned char *'} makes integer from pointer without a cast [-Werror=int-conversion]
+ 463 | writel(msgs->buf, priv->pdmabase + REG_TX_MEM_ADDR);
+drivers/i2c/mt_i2c.c:474:10: error: initialization of 'u32' {aka 'unsigned int'} from 'u8 *' {aka 'unsigned char *'} makes integer from pointer without a cast [-Werror=int-conversion]
+ 474 | writel(msgs->buf, priv->pdmabase + REG_TX_MEM_ADDR);
+drivers/i2c/mt_i2c.c:476:10: error: initialization of 'u32' {aka 'unsigned int'} from 'u8 *' {aka 'unsigned char *'} makes integer from pointer without a cast [-Werror=int-conversion]
+ 476 | writel((msgs + 1)->buf, priv->pdmabase + REG_RX_MEM_ADDR);
+ | ^
+cc1: all warnings being treated as errors
+make[2]: *** [drivers/i2c/mt_i2c.o] Error 1
+make[1]: *** [drivers/i2c] Error 2
+make: *** [sub-make] Error 2

Could you please take a look and send an update?

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#4 lore raw

PATCH v3 2/5 ARM: dts: Mediatek: add i2c node support for mt8512

In reply to mingming lee

From: Mingming Lee <[email protected]>

add i2c dts node support for mt8512

---
Changes for v3:
- just add Reviewed-by info.

---
 arch/arm/dts/mt8512-bm1-emmc.dts | 12 ++++++++++++
 arch/arm/dts/mt8512.dtsi         | 38 +++++++++++++++++++++++++++++++++++++-
 2 files changed, 49 insertions(+), 1 deletion(-)
arch/arm/dts/mt8512-bm1-emmc.dts +12 -0
index 296ed93..7c02539 100644
@@ -45,6 +45,18 @@
 	};
 };
 
+&i2c0 {
+	status = "okay";
+};
+
+&i2c1 {
+	status = "okay";
+};
+
+&i2c2 {
+	status = "okay";
+};
+
 &mmc0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins_default>;
arch/arm/dts/mt8512.dtsi +37 -1
index 01a02a7..39e9499 100644
@@ -90,6 +90,42 @@
 		reg = <0x10200a80 0x50>;
 	};
 
+	i2c0: i2c at 11007000 {
+		compatible = "mediatek,mt8512-i2c";
+		reg = <0x11007000 0x1000>,
+			  <0x11000080 0x80>;
+		clocks = <&infracfg CLK_INFRA_I2C0_AXI>,
+					<&infracfg CLK_INFRA_AP_DMA>;
+		clock-names = "main", "dma";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};
+
+	i2c1: i2c at 10019000 {
+		compatible = "mediatek,mt8512-i2c";
+		reg = <0x10019000 0x1000>,
+			  <0x11000100 0x80>;
+		clocks = <&infracfg CLK_INFRA_I2C1_AXI>,
+				<&infracfg CLK_INFRA_AP_DMA>;
+		clock-names = "main", "dma";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};
+
+	i2c2: i2c at 1001e000 {
+		compatible = "mediatek,mt8512-i2c";
+		reg = <0x1001e000 0x1000>,
+			  <0x11000180 0x80>;
+		clocks = <&infracfg CLK_INFRA_I2C1_AXI>,
+					<&infracfg CLK_INFRA_AP_DMA>;
+		clock-names = "main", "dma";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};
+
 	uart0: serial at 11002000 {
 		compatible = "mediatek,hsuart";
 		reg = <0x11002000 0x1000>;
@@ -112,4 +148,4 @@
 		status = "disabled";
 	};
 
-};
\ No newline at end of file
+};
Signature · 1 line
1.8.1.1.dirty
#5 lore raw

PATCH v3 3/5 configs: mt8512: Enable I2C related configs

In reply to mingming lee

From: Mingming Lee <[email protected]>

Enable MTK I2C
Enable I2C basic command

---
Changes for v3:
- fixed the config order
- add Reviewed-by info

---
 configs/mt8512_bm1_emmc_defconfig | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
configs/mt8512_bm1_emmc_defconfig +7 -1
index 10a2083..a509cfe 100644
@@ -3,21 +3,24 @@ CONFIG_POSITION_INDEPENDENT=y
 CONFIG_ARCH_MEDIATEK=y
 CONFIG_SYS_TEXT_BASE=0x44e00000
 CONFIG_SYS_MALLOC_F_LEN=0x4000
+CONFIG_NR_DRAM_BANKS=1
 CONFIG_ENV_SIZE=0x1000
 CONFIG_DM_GPIO=y
 CONFIG_TARGET_MT8512=y
-CONFIG_NR_DRAM_BANKS=1
 CONFIG_DEFAULT_DEVICE_TREE="mt8512-bm1-emmc"
 CONFIG_FIT=y
 CONFIG_FIT_SIGNATURE=y
 CONFIG_DEFAULT_FDT_FILE="mt8512-bm1-emmc.dtb"
 CONFIG_SYS_PROMPT="MT8512> "
 CONFIG_CMD_BOOTMENU=y
+CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_ENV_OVERWRITE=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CLK=y
+CONFIG_DM_I2C=y
+CONFIG_SYS_I2C_MTK=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_MMC_MTK=y
@@ -33,3 +36,6 @@ CONFIG_MTK_TIMER=y
 CONFIG_WDT=y
 CONFIG_WDT_MTK=y
 CONFIG_LZO=y
+CONFIG_CMD_I2C=y
+CONFIG_DM_I2C=y
+CONFIG_SYS_I2C_MTK=y
Signature · 1 line
1.8.1.1.dirty
#6 lore raw

PATCH v3 4/5 dt-binding: i2c: add bindings for mediatek i2c driver

In reply to mingming lee

From: Mingming Lee <[email protected]>

add bindings for mediatek i2c driver

---
Changes for v3:
- just add Reviewed-by info

---
 doc/device-tree-bindings/i2c/i2c-mtk.txt | 39 ++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 doc/device-tree-bindings/i2c/i2c-mtk.txt
doc/device-tree-bindings/i2c/i2c-mtk.txt new file +39 -0
new file mode 100644
index 0000000..10a3f29
@@ -0,0 +1,39 @@
+I2C for Mediatek platforms
+
+Required properties :
+- compatible : Must be "mediatek,mt8512-i2c"
+- reg: physical base address of the controller and length of memory mapped
+     region.
+- #address-cells = <1>;
+- #size-cells = <0>;
+- clocks: phandles to input clocks.
+- clock-names : Contains the names of the clocks:
+   "main", the clock used for normal mode I2C.
+   "dma", the clock used for apdma mode I2C.
+- status : enable in requried dts or not.
+
+Examples :
+
+	i2c0: i2c at 11007000 {
+		compatible = "mediatek,mt8512-i2c";
+		reg = <0x11007000 0x1000>,
+			  <0x11000080 0x80>;
+		clocks = <&infracfg CLK_INFRA_I2C0_AXI>,
+					<&infracfg CLK_INFRA_AP_DMA>;
+		clock-names = "main", "dma";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};
+
+	i2c1: i2c at 10019000 {
+		compatible = "mediatek,mt8512-i2c";
+		reg = <0x10019000 0x1000>,
+			  <0x11000100 0x80>;
+		clocks = <&infracfg CLK_INFRA_I2C1_AXI>,
+				<&infracfg CLK_INFRA_AP_DMA>;
+		clock-names = "main", "dma";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};
\ No newline at end of file
Signature · 1 line
1.8.1.1.dirty
#7 lore raw

PATCH v3 5/5 MAINTAINERS: add i2c driver to ARM MEDIATEK

In reply to mingming lee

From: Mingming Lee <[email protected]>

add Mediatek i2c controller driver to ARM MEDIATEK.

---
Changes for v3:
- just add Reviewed-by info

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 889a73f..cc78561 100644
@@ -254,10 +254,12 @@ S:	Maintained
 F:	arch/arm/mach-mediatek/
 F:	arch/arm/include/asm/arch-mediatek/
 F:	board/mediatek/
+F:	doc/device-tree-bindings/i2c/i2c-mtk.txt
 F:	doc/device-tree-bindings/phy/phy-mtk-*
 F:	doc/device-tree-bindings/usb/mediatek,*
 F:	doc/README.mediatek
 F:	drivers/clk/mediatek/
+F:	drivers/i2c/mt_i2c.c
 F:	drivers/mmc/mtk-sd.c
 F:	drivers/phy/phy-mtk-*
 F:	drivers/pinctrl/mediatek/
Signature · 1 line
1.8.1.1.dirty