Skip to contentSkip to conversation

usb: mtu3: fix build warning/error

PATCH New Chunfeng Yun 2 participants 5 messages Oct 19, 2020

Subsystems (2)
lore
Share & tools
lore

Chunfeng Yun

author maintainer
#0 lore raw

PATCH 1/1 usb: mtu3: fix build warning/error

Fix up the following build warning/error:
1. unused variable 'mtu' in mtu3_gadget_dequeue() and mtu3_gadget_ep_set_halt()
2. implicit declaration of function ?flush_dcache_range? and ?invalidate_dcache_range?

---
 drivers/usb/mtu3/mtu3_gadget.c | 4 ++--
 drivers/usb/mtu3/mtu3_qmu.c    | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/usb/mtu3/mtu3_gadget.c +2 -2
index 027b7e6111..c981407b29 100644
@@ -306,7 +306,7 @@ static int mtu3_gadget_dequeue(struct usb_ep *ep, struct usb_request *req)
 	struct mtu3_ep *mep = to_mtu3_ep(ep);
 	struct mtu3_request *mreq = to_mtu3_request(req);
 	struct mtu3_request *r;
-	struct mtu3 *mtu = mep->mtu;
+	__maybe_unused struct mtu3 *mtu = mep->mtu;
 	unsigned long flags;
 	int ret = 0;
 
@@ -344,7 +344,7 @@ done:
 static int mtu3_gadget_ep_set_halt(struct usb_ep *ep, int value)
 {
 	struct mtu3_ep *mep = to_mtu3_ep(ep);
-	struct mtu3 *mtu = mep->mtu;
+	__maybe_unused struct mtu3 *mtu = mep->mtu;
 	struct mtu3_request *mreq;
 	unsigned long flags = 0;
 	int ret = 0;
drivers/usb/mtu3/mtu3_qmu.c +1 -0
index f602e50c2f..801c2bc416 100644
@@ -19,6 +19,7 @@
  */
 
 #include <asm/cache.h>
+#include <cpu_func.h>
 #include <linux/iopoll.h>
 #include <linux/types.h>
 
Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/1 usb: mtu3: fix build warning/error

Quoted 5 lines · Chunfeng Yun

Fix up the following build warning/error:
1. unused variable 'mtu' in mtu3_gadget_dequeue() and mtu3_gadget_ep_set_halt()
2. implicit declaration of function ?flush_dcache_range? and ?invalidate_dcache_range?

Which patch of the ones in usb/next do I squash this in ?

author maintainer
#2 lore raw

PATCH 1/1 usb: mtu3: fix build warning/error

Quoted 8 lines · Marek Vasut
Quoted 5 lines · Chunfeng Yun

Fix up the following build warning/error:
1. unused variable 'mtu' in mtu3_gadget_dequeue() and mtu3_gadget_ep_set_halt()
2. implicit declaration of function ?flush_dcache_range? and ?invalidate_dcache_range?

Which patch of the ones in usb/next do I squash this in ?

squash in: ab703ebb1c usb: add MediaTek USB3 DRD driver

Thanks a lot

#3 lore raw

PATCH 1/1 usb: mtu3: fix build warning/error

Quoted 8 lines · Chunfeng Yun
Quoted 7 lines · Marek Vasut
Quoted 5 lines · Chunfeng Yun

Fix up the following build warning/error:
1. unused variable 'mtu' in mtu3_gadget_dequeue() and mtu3_gadget_ep_set_halt()
2. implicit declaration of function ?flush_dcache_range? and ?invalidate_dcache_range?

Quoted 5 lines
Quoted 1 line

Which patch of the ones in usb/next do I squash this in ?

squash in: ab703ebb1c usb: add MediaTek USB3 DRD driver

Thanks a lot

Build fails:
https://gitlab.denx.de/u-boot/custodians/u-boot-usb/-/pipelines/5036

author maintainer
#4 lore raw

PATCH 1/1 usb: mtu3: fix build warning/error

Quoted 9 lines · Marek Vasut
Quoted 8 lines · Chunfeng Yun
Quoted 7 lines · Marek Vasut
Quoted 5 lines · Chunfeng Yun

Fix up the following build warning/error:
1. unused variable 'mtu' in mtu3_gadget_dequeue() and mtu3_gadget_ep_set_halt()
2. implicit declaration of function ?flush_dcache_range? and ?invalidate_dcache_range?

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Which patch of the ones in usb/next do I squash this in ?

squash in: ab703ebb1c usb: add MediaTek USB3 DRD driver

Thanks a lot

Build fails:
https://gitlab.denx.de/u-boot/custodians/u-boot-usb/-/pipelines/5036

Sorry, the patch is already sent out, thanks