Skip to contentSkip to conversation

cifs : fix memory leak on error path

PATCH New Defang Bo 1 participant 1 message Oct 19, 2020

Subsystems (2)
lore
Share & tools
lore

Defang Bo

author
#0 lore raw

PATCH 1/1 cifs : fix memory leak on error path

In SMB2_open_init() , if smb2_plain_req_init() fails, then the memory assigned to req will be leaked. It's similar to SMB2_open() which is fixed by the commit <b7a73c84eb96> ("cifs: fix memory leak in SMB2_open()").

---
 fs/cifs/smb2pdu.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
fs/cifs/smb2pdu.c +3 -2
index 2f4cdd2..a1f584a 100644
@@ -2703,9 +2703,10 @@ int smb311_posix_mkdir(const unsigned int xid, struct inode *inode,
 
 	rc = smb2_plain_req_init(SMB2_CREATE, tcon, server,
 				 (void **) &req, &total_len);
-	if (rc)
+	if (rc) {
+		cifs_small_buf_release(req);
 		return rc;
-
+	}
 	iov[0].iov_base = (char *)req;
 	/* -1 since last byte is buf[0] which is sent below (path) */
 	iov[0].iov_len = total_len - 1;
Signature · 1 line
1.9.1