Skip to contentSkip to conversation

bonding: fix xmit balance policy name

PATCH Superseded Min Hu (Connor) 2 participants 3 messages Oct 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bonding: fix xmit balance policy name

Currently there exits inconsistence about name of transmission policy for a Link Bonding device. "xmit_balance_policy" is not corrent, which should be modified to "balance_xmit_policy".

Fixes 2950a769315e ("bond: testpmd support")
Fixes ac718398f477 ("doc: testpmd application user guide")
---
 app/test-pmd/cmdline.c                      | 2 +-
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
app/test-pmd/cmdline.c +1 -1
index 07ee4e4..9bc7751 100644
@@ -649,7 +649,7 @@ static void cmd_help_long_parsed(void *parsed_result,
 			"set bonding mode IEEE802.3AD aggregator policy (port_id) (agg_name)"
 			"	Set Aggregation mode for IEEE802.3AD (mode 4)"
 
-			"set bonding xmit_balance_policy (port_id) (l2|l23|l34)\n"
+			"set bonding balance_xmit_policy (port_id) (l2|l23|l34)\n"
 			"	Set the transmit balance policy for bonded device running in balance mode.\n\n"
 
 			"set bonding mon_period (port_id) (value)\n"
doc/guides/testpmd_app_ug/testpmd_funcs.rst +3 -3
index a4c07c9..3f8719e 100644
@@ -2610,16 +2610,16 @@ For example, to set the MAC address of a Link Bonding device (port 10) to 00:00:
 
    testpmd> set bonding mac 10 00:00:00:00:00:01
 
-set bonding xmit_balance_policy
+set bonding balance_xmit_policy
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 Set the transmission policy for a Link Bonding device when it is in Balance XOR mode::
 
-   testpmd> set bonding xmit_balance_policy (port_id) (l2|l23|l34)
+   testpmd> set bonding balance_xmit_policy (port_id) (l2|l23|l34)
 
 For example, set a Link Bonding device (port 10) to use a balance policy of layer 3+4 (IP addresses & UDP ports)::
 
-   testpmd> set bonding xmit_balance_policy 10 l34
+   testpmd> set bonding balance_xmit_policy 10 l34
 
 
 set bonding mon_period
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 bonding: fix xmit balance policy name

Currently there exits inconsistence about name of transmission policy for a Link Bonding device. "xmit_balance_policy" is not correct, which should be modified to "balance_xmit_policy".

Fixes 2950a769315e ("bond: testpmd support")
Fixes ac718398f477 ("doc: testpmd application user guide")

---
v1->v2:
fix commit log info.

---
 app/test-pmd/cmdline.c                      | 2 +-
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
app/test-pmd/cmdline.c +1 -1
index 07ee4e4..9bc7751 100644
@@ -649,7 +649,7 @@ static void cmd_help_long_parsed(void *parsed_result,
 			"set bonding mode IEEE802.3AD aggregator policy (port_id) (agg_name)"
 			"	Set Aggregation mode for IEEE802.3AD (mode 4)"
 
-			"set bonding xmit_balance_policy (port_id) (l2|l23|l34)\n"
+			"set bonding balance_xmit_policy (port_id) (l2|l23|l34)\n"
 			"	Set the transmit balance policy for bonded device running in balance mode.\n\n"
 
 			"set bonding mon_period (port_id) (value)\n"
doc/guides/testpmd_app_ug/testpmd_funcs.rst +3 -3
index a4c07c9..3f8719e 100644
@@ -2610,16 +2610,16 @@ For example, to set the MAC address of a Link Bonding device (port 10) to 00:00:
 
    testpmd> set bonding mac 10 00:00:00:00:00:01
 
-set bonding xmit_balance_policy
+set bonding balance_xmit_policy
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 Set the transmission policy for a Link Bonding device when it is in Balance XOR mode::
 
-   testpmd> set bonding xmit_balance_policy (port_id) (l2|l23|l34)
+   testpmd> set bonding balance_xmit_policy (port_id) (l2|l23|l34)
 
 For example, set a Link Bonding device (port 10) to use a balance policy of layer 3+4 (IP addresses & UDP ports)::
 
-   testpmd> set bonding xmit_balance_policy 10 l34
+   testpmd> set bonding balance_xmit_policy 10 l34
 
 
 set bonding mon_period
Signature · 1 line
2.7.4
Reviewed-by on v2 1/1 Applied
#2 lore raw
Quoted 9 lines · Min Hu (Connor)

Currently there exits inconsistence about name of transmission policy for a Link Bonding device. "xmit_balance_policy" is not correct, which should be modified to "balance_xmit_policy".

Fixes 2950a769315e ("bond: testpmd support")
Fixes ac718398f477 ("doc: testpmd application user guide")

Applied to dpdk-next-net/main, thanks.