Skip to contentSkip to conversation

usb: mtu3: fix build error caused by dev_xxx()

PATCH New Chunfeng Yun 3 participants 5 messages Oct 19, 2020 – Oct 20, 2020

Subsystems (2)
lore
Share & tools
lore

Chunfeng Yun

author maintainer
#0 lore raw

PATCH 1/1 usb: mtu3: fix build error caused by dev_xxx()

Due to the following to patches:
4a1989c0bc77 ("dm: Don't undefine dev_xxx macros") 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros")

Need include device_compat.h and no need use __maybe_unused anymore to fix unused variable warning

---
Please squash in: ab703ebb1cc0 ("usb: add MediaTek USB3 DRD driver") in u-boot-usb/next

Sorry for inconvenience

---
 drivers/usb/mtu3/mtu3.h        | 1 +
 drivers/usb/mtu3/mtu3_gadget.c | 4 ++--
 drivers/usb/mtu3/mtu3_plat.c   | 3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)
drivers/usb/mtu3/mtu3.h +1 -0
index a51251c661..8a7ae83ee9 100644
@@ -13,6 +13,7 @@
 #include <asm/io.h>
 #include <clk.h>
 #include <dm.h>
+#include <dm/device_compat.h>
 #include <dm/devres.h>
 #include <generic-phy.h>
 #include <linux/bug.h>
drivers/usb/mtu3/mtu3_gadget.c +2 -2
index c981407b29..027b7e6111 100644
@@ -306,7 +306,7 @@ static int mtu3_gadget_dequeue(struct usb_ep *ep, struct usb_request *req)
 	struct mtu3_ep *mep = to_mtu3_ep(ep);
 	struct mtu3_request *mreq = to_mtu3_request(req);
 	struct mtu3_request *r;
-	__maybe_unused struct mtu3 *mtu = mep->mtu;
+	struct mtu3 *mtu = mep->mtu;
 	unsigned long flags;
 	int ret = 0;
 
@@ -344,7 +344,7 @@ done:
 static int mtu3_gadget_ep_set_halt(struct usb_ep *ep, int value)
 {
 	struct mtu3_ep *mep = to_mtu3_ep(ep);
-	__maybe_unused struct mtu3 *mtu = mep->mtu;
+	struct mtu3 *mtu = mep->mtu;
 	struct mtu3_request *mreq;
 	unsigned long flags = 0;
 	int ret = 0;
drivers/usb/mtu3/mtu3_plat.c +2 -1
index 24ffdb360a..3795e695e8 100644
@@ -347,7 +347,8 @@ static int mtu3_glue_bind(struct udevice *parent)
 
 	ret = device_bind_driver_to_node(parent, driver, name, node, &dev);
 	if (ret)
-		dev_err("%s: not able to bind usb device mode\n", __func__);
+		dev_err(parent, "%s: not able to bind usb device mode\n",
+			__func__);
 
 	return ret;
 }
Signature · 1 line
2.18.0
Applied
#1 lore raw

PATCH 1/1 usb: mtu3: fix build error caused by dev_xxx()

Quoted 11 lines · Chunfeng Yun

Due to the following to patches:
4a1989c0bc77 ("dm: Don't undefine dev_xxx macros") 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros")

Need include device_compat.h and no need use __maybe_unused anymore to fix unused variable warning

---
Please squash in: ab703ebb1cc0 ("usb: add MediaTek USB3 DRD driver") in u-boot-usb/next

Applied, thanks.

Quoted 1 line

Sorry for inconvenience

Please make use of the CI next time.

author maintainer
#2 lore raw

PATCH 1/1 usb: mtu3: fix build error caused by dev_xxx()

Quoted 8 lines · Marek Vasut
Quoted 7 lines · Chunfeng Yun

Due to the following to patches:
4a1989c0bc77 ("dm: Don't undefine dev_xxx macros") 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros")

Need include device_compat.h and no need use __maybe_unused anymore to fix unused variable warning

Quoted 6 lines
Quoted 4 lines

---
Please squash in: ab703ebb1cc0 ("usb: add MediaTek USB3 DRD driver") in u-boot-usb/next

Applied, thanks.

Thank you!

Quoted 4 lines
Quoted 2 lines

Sorry for inconvenience

Please make use of the CI next time.

Is there any reference about CI I can see?

#3 lore raw

PATCH 1/1 usb: mtu3: fix build error caused by dev_xxx()

Hi Chunfeng,

Quoted 15 lines · Chunfeng Yun
Quoted 13 lines · Marek Vasut
Quoted 11 lines · Chunfeng Yun

Due to the following to patches:
4a1989c0bc77 ("dm: Don't undefine dev_xxx macros") 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros")

Need include device_compat.h and no need use __maybe_unused anymore to fix unused variable warning

---
Please squash in: ab703ebb1cc0 ("usb: add MediaTek USB3 DRD driver") in u-boot-usb/next

Quoted 9 lines
Quoted 1 line

Applied, thanks.

Thank you!

Quoted 4 lines
Quoted 2 lines

Sorry for inconvenience

Please make use of the CI next time.

Is there any reference about CI I can see?

You can use Microsoft Azure (recommended), or Travis-CI to test your patches.

Regards,
Bin

author maintainer
#4 lore raw

PATCH 1/1 usb: mtu3: fix build error caused by dev_xxx()

Quoted 22 lines · Bin Meng

Hi Chunfeng,

Quoted 19 lines · Chunfeng Yun
Quoted 8 lines · Marek Vasut
Quoted 7 lines · Chunfeng Yun

Due to the following to patches:
4a1989c0bc77 ("dm: Don't undefine dev_xxx macros") 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros")

Need include device_compat.h and no need use __maybe_unused anymore to fix unused variable warning

Quoted 6 lines
Quoted 4 lines

---
Please squash in: ab703ebb1cc0 ("usb: add MediaTek USB3 DRD driver") in u-boot-usb/next

Applied, thanks.

Thank you!

Quoted 1 line
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Sorry for inconvenience

Please make use of the CI next time.

Is there any reference about CI I can see?

You can use Microsoft Azure (recommended), or Travis-CI to test your patches.

Thank you

Quoted 3 lines

Regards,
Bin