bus: mhi: core: fix potential operator-precedence with BHI macros
Subsystems (2)
PATCH 1/1 bus: mhi: core: fix potential operator-precedence with BHI macros
The BHI_MSMHWID and BHI_OEMPKHASH macros take a value 'n' which is a BHI register index. If 'n' is an expression rather than a simple value, there can be an operator precedence issue which can result in the incorrect calculation of the register offset. Adding parentheses around the macro parameter can prevent such issues.
--- drivers/bus/mhi/core/internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/bus/mhi/core/internal.h +2 -2
@@ -153,8 +153,8 @@ extern struct bus_type mhi_bus_type;#define BHI_SERIALNU (0x40)#define BHI_SBLANTIROLLVER (0x44)#define BHI_NUMSEG (0x48) -#define BHI_MSMHWID (n) (0x4C + (0x4 * n)) -#define BHI_OEMPKHASH (n) (0x64 + (0x4 * n)) +#define BHI_MSMHWID (n) (0x4C + (0x4 * (n))) +#define BHI_OEMPKHASH (n) (0x64 + (0x4 * (n)))#define BHI_RSVD5 (0xC4)#define BHI_STATUS_MASK (0xC0000000)#define BHI_STATUS_SHIFT (30)
Signature · 2 lines
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 8 lines · Jeffrey Hugo
The
BHI_MSMHWIDandBHI_OEMPKHASHmacros take a value 'n' which is a BHI register index. If 'n' is an expression rather than a simple value, there can be an operator precedence issue which can result in the incorrect calculation of the register offset. Adding parentheses around the macro parameter can prevent such issues.Signed-off-by Jeffrey Hugo <[email protected]>---
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 7 lines · Jeffrey Hugo
The
BHI_MSMHWIDandBHI_OEMPKHASHmacros take a value 'n' which is a BHI register index. If 'n' is an expression rather than a simple value, there can be an operator precedence issue which can result in the incorrect calculation of the register offset. Adding parentheses around the macro parameter can prevent such issues.Signed-off-by Jeffrey Hugo <[email protected]>
Thanks,
Mani
Quoted 23 lines
--- drivers/bus/mhi/core/internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/bus/mhi/core/internal.h +2
-2@@ -153,8 +153,8 @@ extern struct bus_type mhi_bus_type;#define BHI_SERIALNU (0x40)#define BHI_SBLANTIROLLVER (0x44)#define BHI_NUMSEG (0x48) -#define BHI_MSMHWID (n) (0x4C + (0x4 * n)) -#define BHI_OEMPKHASH (n) (0x64 + (0x4 * n)) +#define BHI_MSMHWID (n) (0x4C + (0x4 * (n))) +#define BHI_OEMPKHASH (n) (0x64 + (0x4 * (n)))#define BHI_RSVD5 (0xC4)#define BHI_STATUS_MASK (0xC0000000)#define BHI_STATUS_SHIFT (30)Signature · 2 lines
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Manivannan Sadhasivam
AppliedQuoted 7 lines · Jeffrey Hugo
The
BHI_MSMHWIDandBHI_OEMPKHASHmacros take a value 'n' which is a BHI register index. If 'n' is an expression rather than a simple value, there can be an operator precedence issue which can result in the incorrect calculation of the register offset. Adding parentheses around the macro parameter can prevent such issues.Signed-off-by Jeffrey Hugo <[email protected]>
Applied to mhi-next!
Thanks,
Mani
Quoted 23 lines
--- drivers/bus/mhi/core/internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/bus/mhi/core/internal.h +2
-2@@ -153,8 +153,8 @@ extern struct bus_type mhi_bus_type;#define BHI_SERIALNU (0x40)#define BHI_SBLANTIROLLVER (0x44)#define BHI_NUMSEG (0x48) -#define BHI_MSMHWID (n) (0x4C + (0x4 * n)) -#define BHI_OEMPKHASH (n) (0x64 + (0x4 * n)) +#define BHI_MSMHWID (n) (0x4C + (0x4 * (n))) +#define BHI_OEMPKHASH (n) (0x64 + (0x4 * (n)))#define BHI_RSVD5 (0xC4)#define BHI_STATUS_MASK (0xC0000000)#define BHI_STATUS_SHIFT (30)Signature · 2 lines
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
This patch was applied to qcom/linux.git (refs/heads/for-next):
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
Quoted 9 lines · On Tue, 20 Oct 2020 14:29:45 -0600 you wrote:
The
BHI_MSMHWIDandBHI_OEMPKHASHmacros take a value 'n' which is a BHI register index. If 'n' is an expression rather than a simple value, there can be an operator precedence issue which can result in the incorrect calculation of the register offset. Adding parentheses around the macro parameter can prevent such issues.Signed-off-by Jeffrey Hugo <[email protected]>[...]
Here is the summary with links:
- bus: mhi: core: fix potential operator-precedence with BHI macros
https://git.kernel.org/qcom/c/8ff3f7bdde45
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html