(one line): use #ifdef with CONFIG_*
PATCH 1/1 (one line): use #ifdef with CONFIG_*
===== include/asm-i386/kmap_types.h 1.13 vs edited =====
include/asm-i386/kmap_types.h +1 -1
@@ -3,7 +3,7 @@#include <linux/config.h> -#if CONFIG_DEBUG_HIGHMEM +#ifdef CONFIG_DEBUG_HIGHMEM # define D (n) __KM_FENCE_##n ,#else # define D (n)
include/asm-i386/kmap_types.h line 6
Quoted 3 lines · Nikita Danilov
include/asm-i386/kmap_types.h +1
-1-#if CONFIG_DEBUG_HIGHMEM +#ifdef CONFIG_DEBUG_HIGHMEM
mnm:/usr/src/linux-2.5.68> grep -r '#if[ ]*CONFIG' . | wc -l
185
Why fix this one in particular?
Quoted 9 lines · Andrew Morton
include/asm-i386/kmap_types.h line 6
Quoted 3 lines · Nikita Danilov
include/asm-i386/kmap_types.h +1
-1-#if CONFIG_DEBUG_HIGHMEM +#ifdef CONFIG_DEBUG_HIGHMEM mnm:/usr/src/linux-2.5.68> grep -r '#if[ ]*CONFIG' . | wc -l
185Why fix this one in particular?
Err, I just added -Wundef to cc options and it was the only one that has shown up. Probably all of them should be corrected at once.
Nikita.
Quoted 2 lines · Nikita Danilov
Err, I just added -Wundef to cc options and it was the only one that has shown up. Probably all of them should be corrected at once.
I submitted patches to clean a lot of this up, but not all seem to have made it into Linus's kernel. I'll re-diff against 2.5.68 and re-send.