common/sfc_efx/base: fix build breakage on clang 3.4.x
PATCH 1/1 common/sfc_efx/base: fix build breakage on clang 3.4.x
Remove duplicate typedef for efx_mae_actions_t.
--- drivers/common/sfc_efx/base/efx_impl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/common/sfc_efx/base/efx_impl.h +2 -2
@@ -1736,7 +1736,7 @@ struct efx_mae_match_spec_s {uint16_t emavp_tci_be; } efx_mae_action_vlan_push_t; -typedef struct efx_mae_actions_s { +struct efx_mae_actions_s {/* Bitmap of actions in spec, indexed by action type */ uint32_t emass_actions;
@@ -1746,7 +1746,7 @@ struct efx_mae_match_spec_s { EFX_MAE_VLAN_PUSH_MAX_NTAGS];uint32_t emass_mark_value; efx_mport_sel_t emass_deliver_mport; -} efx_mae_actions_t; +};#endif /* EFSYS_OPT_MAE */
Signature · 1 line
1.8.3.1
Thanks Andrew.
Quoted 41 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Andrew Rybchenko
Sent: Tuesday, October 27, 2020 2:09 PM
To: [email protected]
Subject: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on clang 3.4.xRemove duplicate typedef for
efx_mae_actions_t.Fixes 57f9eb33d32c ("common/sfc_efx/base: add action set spec init/finiAPIs")
Signed-off-by Andrew Rybchenko <[email protected]>--- drivers/common/sfc_efx/base/efx_impl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/common/sfc_efx/base/efx_impl.h +2
-3@@ -1736,7 +1736,7 @@ struct efx_mae_match_spec_s {uint16_t emavp_tci_be; } efx_mae_action_vlan_push_t; -typedef struct efx_mae_actions_s { +struct efx_mae_actions_s {/* Bitmap of actions in spec, indexed by action type */ uint32_t emass_actions;@@ -1746,7 +1746,7 @@ struct efx_mae_match_spec_s { EFX_MAE_VLAN_PUSH_MAX_NTAGS];uint32_t emass_mark_value; efx_mport_sel_t emass_deliver_mport; -} efx_mae_actions_t; +};#endif /* EFSYS_OPT_MAE */ --
Quoted 1 line
1.8.3.1
Quoted 40 lines · Ali Alnubani
Thanks Andrew.
Quoted 38 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Andrew Rybchenko
Sent: Tuesday, October 27, 2020 2:09 PM
To: [email protected]
Subject: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on clang 3.4.xRemove duplicate typedef for
efx_mae_actions_t.Fixes 57f9eb33d32c ("common/sfc_efx/base: add action set spec init/finiAPIs")
Signed-off-by Andrew Rybchenko <[email protected]>--- drivers/common/sfc_efx/base/efx_impl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/common/sfc_efx/base/efx_impl.h +2
-2@@ -1736,7 +1736,7 @@ struct efx_mae_match_spec_s {uint16_t emavp_tci_be; } efx_mae_action_vlan_push_t; -typedef struct efx_mae_actions_s { +struct efx_mae_actions_s {/* Bitmap of actions in spec, indexed by action type */ uint32_t emass_actions;@@ -1746,7 +1746,7 @@ struct efx_mae_match_spec_s { EFX_MAE_VLAN_PUSH_MAX_NTAGS];uint32_t emass_mark_value;efx_mport_sel_t emass_deliver_mport; -} efx_mae_actions_t; +};
Quoted 7 lines
Quoted 4 lines
drivers/common/sfc_efx/base/efx_impl.h +0
-1#endif /* EFSYS_OPT_MAE */ --1.8.3.1
Tested-by Ali Alnubani <[email protected]>
Squashed into corresponding changeset, thanks.