Skip to contentSkip to conversation

glibc: Added and whitelisted CVE patches

PATCH In review saloni 3 participants 4 messages Oct 28, 2020

lore
Share & tools
lore

saloni

author
#0 lore raw

PATCH 1/1 glibc: Added and whitelisted CVE patches

From: Saloni Jain <[email protected]>

Below CVE patches are whitelisted as not considered as security threats by Upstream Community:
1. CVE-2019-1010022

2. CVE-2019-1010023

3. CVE-2019-1010024

4. CVE-2019-1010025

Below CVE patches are whitelisted as the changes are already present in the source-code:
1. CVE-2020-1751

2. CVE-2020-1752

3. CVE-2020-6096

4. CVE-2015-8985

5. CVE-2016-10739

6. CVE-2020-10029

7. CVE-2009-5155

Upstream-Status: Pending

---
 meta/recipes-core/glibc/glibc_2.32.bb | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.32.bb +18 -1
index 2a0e464..7c56f6b 100644
@@ -1,7 +1,24 @@
 require glibc.inc
 require glibc-version.inc
 
-CVE_CHECK_WHITELIST += "CVE-2020-10029"
+#As confirmed by Upstream Community below patches are not considered security threats, hence whitelisted.
+CVE_CHECK_WHITELIST += "\
+    CVE-2019-1010022 \
+    CVE-2019-1010023 \
+    CVE-2019-1010024 \
+    CVE-2019-1010025 \
+"
+#Changes are already present in source-code, hence whitelisted.
+CVE_CHECK_WHITELIST += "\
+    CVE-2009-5155 \
+    CVE-2016-10739 \
+    CVE-2020-10029 \
+    CVE-2015-8985 \
+    CVE-2020-6096 \
+    CVE-2016-10228 \
+    CVE-2020-1751 \
+    CVE-2020-1752 \
+"
 
 DEPENDS += "gperf-native bison-native make-native"
 

--
2.7.4

This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.

#1 lore raw
Quoted 27 lines · Saloni.Jain

From: Saloni Jain <[email protected]>

Below CVE patches are whitelisted as not considered as security threats by Upstream Community:
1. CVE-2019-1010022

2. CVE-2019-1010023

3. CVE-2019-1010024

4. CVE-2019-1010025

Below CVE patches are whitelisted as the changes are already present in the source-code:
1. CVE-2020-1751

2. CVE-2020-1752

3. CVE-2020-6096

4. CVE-2015-8985

5. CVE-2016-10739

Quoted 9 lines

6. CVE-2020-10029

7. CVE-2009-5155

Thanks for doing this. Looks ok to me.

Quoted 1 line

Upstream-Status: Pending

we do not need upstream status to metadata patches but to actual components which needs to be tracked for upstream submission etc. so please remove it here.

Quoted 39 lines
---
 meta/recipes-core/glibc/glibc_2.32.bb | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.32.bb +18 -2
index 2a0e464..7c56f6b 100644
@@ -1,7 +1,24 @@
 require glibc.inc
 require glibc-version.inc
 
-CVE_CHECK_WHITELIST += "CVE-2020-10029"
+#As confirmed by Upstream Community below patches are not considered security threats, hence whitelisted.
+CVE_CHECK_WHITELIST += "\
+    CVE-2019-1010022 \
+    CVE-2019-1010023 \
+    CVE-2019-1010024 \
+    CVE-2019-1010025 \
+"
+#Changes are already present in source-code, hence whitelisted.
+CVE_CHECK_WHITELIST += "\
+    CVE-2009-5155 \
+    CVE-2016-10739 \
+    CVE-2020-10029 \
+    CVE-2015-8985 \
+    CVE-2020-6096 \
+    CVE-2016-10228 \
+    CVE-2020-1751 \
+    CVE-2020-1752 \
+"
 
 DEPENDS += "gperf-native bison-native make-native"
 
--

2.7.4

This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.

author
#2 lore raw

Hello Khem Raj,

Thankyou for the feedback! I have removed the line and resent the patch again.

Thanks & Regards,
Saloni
________________________________
From: Khem Raj <[email protected]>
Sent: Wednesday, October 28, 2020 9:23 PM
To: Saloni Jain <[email protected]>
Cc: Patches and discussions about the oe-core layer <[email protected]>; Nisha Parrakat <[email protected]>; Anuj Chougule <[email protected]>
Subject: Re: [poky][master][PATCH] glibc: Added and whitelisted CVE patches

Quoted 27 lines · Saloni.Jain

From: Saloni Jain <[email protected]>

Below CVE patches are whitelisted as not considered as security threats by Upstream Community:
1. CVE-2019-1010022

2. CVE-2019-1010023

3. CVE-2019-1010024

4. CVE-2019-1010025

Below CVE patches are whitelisted as the changes are already present in the source-code:
1. CVE-2020-1751

2. CVE-2020-1752

3. CVE-2020-6096

4. CVE-2015-8985

5. CVE-2016-10739

Quoted 9 lines

6. CVE-2020-10029

7. CVE-2009-5155

Thanks for doing this. Looks ok to me.

Quoted 1 line

Upstream-Status: Pending

we do not need upstream status to metadata patches but to actual components which needs to be tracked for upstream submission etc. so please remove it here.

Quoted 38 lines
---
 meta/recipes-core/glibc/glibc_2.32.bb | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.32.bb +18 -2
index 2a0e464..7c56f6b 100644
@@ -1,7 +1,24 @@
 require glibc.inc
 require glibc-version.inc
 
-CVE_CHECK_WHITELIST += "CVE-2020-10029"
+#As confirmed by Upstream Community below patches are not considered security threats, hence whitelisted.
+CVE_CHECK_WHITELIST += "\
+    CVE-2019-1010022 \
+    CVE-2019-1010023 \
+    CVE-2019-1010024 \
+    CVE-2019-1010025 \
+"
+#Changes are already present in source-code, hence whitelisted.
+CVE_CHECK_WHITELIST += "\
+    CVE-2009-5155 \
+    CVE-2016-10739 \
+    CVE-2020-10029 \
+    CVE-2015-8985 \
+    CVE-2020-6096 \
+    CVE-2016-10228 \
+    CVE-2020-1751 \
+    CVE-2020-1752 \
+"
 
 DEPENDS += "gperf-native bison-native make-native"
 
--

2.7.4

Quoted 1 line

This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.

This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.

#3 lore raw
In reply to saloni
Quoted 6 lines · saloni

From: Saloni Jain <[email protected]>

Below CVE patches are whitelisted as not considered as security threats by Upstream Community:
1. CVE-2019-1010022

Quoted 7 lines

2. CVE-2019-1010023

3. CVE-2019-1010024

4. CVE-2019-1010025

The above looks good to me.

Quoted 13 lines

Below CVE patches are whitelisted as the changes are already present in the source-code:
1. CVE-2020-1751

2. CVE-2020-1752

3. CVE-2020-6096

4. CVE-2015-8985

5. CVE-2016-10739

Quoted 8 lines

6. CVE-2020-10029

7. CVE-2009-5155

There is no need for this second category, these CVE's do not show up in a CVE check for master:

https://lists.yoctoproject.org/g/yocto-security/topic/oe_core_cve_metrics_for/76221269?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,76221269

Please send a v2 with the above CVE's removed.

Quoted 1 line

Upstream-Status: Pending

You can remove the above in v2 also

Thanks for helping with CVE's!

Steve

Quoted 42 lines
---
 meta/recipes-core/glibc/glibc_2.32.bb | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.32.bb +18 -2
index 2a0e464..7c56f6b 100644
@@ -1,7 +1,24 @@
 require glibc.inc
 require glibc-version.inc
 
-CVE_CHECK_WHITELIST += "CVE-2020-10029"
+#As confirmed by Upstream Community below patches are not considered security threats, hence whitelisted.
+CVE_CHECK_WHITELIST += "\
+    CVE-2019-1010022 \
+    CVE-2019-1010023 \
+    CVE-2019-1010024 \
+    CVE-2019-1010025 \
+"
+#Changes are already present in source-code, hence whitelisted.
+CVE_CHECK_WHITELIST += "\
+    CVE-2009-5155 \
+    CVE-2016-10739 \
+    CVE-2020-10029 \
+    CVE-2015-8985 \
+    CVE-2020-6096 \
+    CVE-2016-10228 \
+    CVE-2020-1751 \
+    CVE-2020-1752 \
+"
 
 DEPENDS += "gperf-native bison-native make-native"
 
--

2.7.4

This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.