Convert graph bindings to json-schema
PATCH v2 1/1 Convert graph bindings to json-schema
Move graph bindings to json-schema and thus convert graph.txt to graph.yaml. The graph.txt is currently referenced in many files and for now graph.txt re-directs reference to graph.yaml.
Changelog
=========
v1 -> v2
--------
* Dropped "[PATCH 2/2] dt-bindings: Use graph.yaml reference in docs"
* [PATCH 1/2] is modified to retain graph.txt file for now and added re-direction to graph.yaml
Sameer Pujar (1):
dt-bindings: Convert graph bindings to json-schema
Documentation/devicetree/bindings/graph.txt | 129 +----------------- Documentation/devicetree/bindings/graph.yaml | 188 +++++++++++++++++++++++++++ 2 files changed, 189 insertions(+), 128 deletions(-) create mode 100644 Documentation/devicetree/bindings/graph.yaml
Signature · 1 line
2.7.4
PATCH v2 1/1 dt-bindings: Convert graph bindings to json-schema
Convert device tree bindings of graph to YAML format. Currently graph.txt doc is referenced in multiple files and all of these need to use schema references. For now graph.txt is updated to refer to graph.yaml.
--- Documentation/devicetree/bindings/graph.txt | 129 +----------------- Documentation/devicetree/bindings/graph.yaml | 188 +++++++++++++++++++++++++++ 2 files changed, 189 insertions(+), 128 deletions(-) create mode 100644 Documentation/devicetree/bindings/graph.yaml
Documentation/devicetree/bindings/graph.txt +1 -128
@@ -1,128 +1 @@ -Common bindings for device graphs - -General concept ---------------- - -The hierarchical organisation of the device tree is well suited to describe -control flow to devices, but there can be more complex connections between -devices that work together to form a logical compound device, following an -arbitrarily complex graph. -There already is a simple directed graph between devices tree nodes using -phandle properties pointing to other nodes to describe connections that -can not be inferred from device tree parent-child relationships. The device -tree graph bindings described herein abstract more complex devices that can -have multiple specifiable ports, each of which can be linked to one or more -ports of other devices. - -These common bindings do not contain any information about the direction or -type of the connections, they just map their existence. Specific properties -may be described by specialized bindings depending on the type of connection. - -To see how this binding applies to video pipelines, for example, see -Documentation/devicetree/bindings/media/video-interfaces.txt. -Here the ports describe data interfaces, and the links between them are -the connecting data buses. A single port with multiple connections can -correspond to multiple devices being connected to the same physical bus. - -Organisation of ports and endpoints ------------------------------------ - -Ports are described by child 'port' nodes contained in the device node. -Each port node contains an 'endpoint' subnode for each remote device port -connected to this port. If a single port is connected to more than one -remote device, an 'endpoint' child node must be provided for each link. -If more than one port is present in a device node or there is more than one -endpoint at a port, or a port node needs to be associated with a selected -hardware interface, a common scheme using '#address-cells', '#size-cells' -and 'reg' properties is used to number the nodes. - -device { - ... - #address-cells = <1>; - #size-cells = <0>; - - port@0 { - #address-cells = <1>; - #size-cells = <0>; - reg = <0>; - - endpoint@0 { - reg = <0>; - ... - }; - endpoint@1 { - reg = <1>; - ... - }; - }; - - port@1 { - reg = <1>; - - endpoint { ... }; - }; -}; - -All 'port' nodes can be grouped under an optional 'ports' node, which -allows to specify #address-cells, #size-cells properties for the 'port' -nodes independently from any other child device nodes a device might -have. - -device { - ... - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@0 { - ... - endpoint@0 { ... }; - endpoint@1 { ... }; - }; - - port@1 { ... }; - }; -}; - -Links between endpoints ------------------------ - -Each endpoint should contain a 'remote-endpoint' phandle property that points -to the corresponding endpoint in the port of the remote device. In turn, the -remote endpoint should contain a 'remote-endpoint' property. If it has one, it -must not point to anything other than the local endpoint. Two endpoints with -their 'remote-endpoint' phandles pointing at each other form a link between the -containing ports. - -device-1 { - port { - device_1_output: endpoint { - remote-endpoint = <&device_2_input>; - }; - }; -}; - -device-2 { - port { - device_2_input: endpoint { - remote-endpoint = <&device_1_output>; - }; - }; -}; - -Required properties -------------------- - -If there is more than one 'port' or more than one 'endpoint' node or 'reg' -property present in the port and/or endpoint nodes then the following -properties are required in a relevant parent node: - - - #address-cells : number of cells required to define port/endpoint - identifier, should be 1. - - #size-cells : should be zero. - -Optional endpoint properties ----------------------------- - -- remote-endpoint: phandle to an 'endpoint' subnode of a remote device node. - +This file has moved to graph.yaml
Documentation/devicetree/bindings/graph.yaml new file +188 -0
188 lines not on this page · raw message
Signature · 1 line
2.7.4
Re: [PATCH v2] dt-bindings: Convert graph bindings to json-schema
Quoted 6 lines · Sameer Pujar
Convert device tree bindings of graph to YAML format. Currently graph.txt doc is referenced in multiple files and all of these need to use schema references. For now graph.txt is updated to refer to
graph.yaml.Signed-off-by Sameer Pujar <[email protected]>Cc Philipp Zabel <[email protected]>
regards
Philipp
Re: [PATCH v2] dt-bindings: Convert graph bindings to json-schema
In reply to Sameer PujarHi Rob,
Quoted 11 lines
Convert device tree bindings of graph to YAML format. Currently graph.txt doc is referenced in multiple files and all of these need to use schema references. For now graph.txt is updated to refer to
graph.yaml.Signed-off-by Sameer Pujar <[email protected]>Cc Philipp Zabel <[email protected]>--- Documentation/devicetree/bindings/graph.txt | 129 +----------------- Documentation/devicetree/bindings/graph.yaml | 188 +++++++++++++++++++++++++++ 2 files changed, 189 insertions(+), 128 deletions(-)create mode 100644
Documentation/devicetree/bindings/graph.yaml
As per report from http://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected] there are some warnings. I will fix yamllint warnings in v3.
However I don't see below errors when I run 'make dt_binding_check' locally.
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/graph.yaml: 'additionalProperties' is a required property schemas/graph.yaml: ignoring, error in schema:./Documentation/devicetree/bindings/graph.yaml: Unresolvable JSON pointer: 'properties/port' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/graph.yaml: ignoring, error in schema:
warning: no schema found in file: ./Documentation/devicetree/bindings/graph.yaml
Am I missing anything?
Thanks,
Sameer.