ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
Subsystems (2)
PATCH 1/1 ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins.
Fix the phy-mode description to correct reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config").
--- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sun7i-a20-bananapi.dts +1 -1
@@ -132,7 +132,7 @@ pinctrl-names = "default"; pinctrl-0 = <&gmac_rgmii_pins>; phy-handle = <&phy1>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-supply = <®_gmac_3v3>; status = "okay"; };
Signature · 7 lines
2.18.4 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/1 ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator
DCDC1 regulator powers many different subsystems. While some of them can work at 3.0 V, some of them can not. For example, VCC-HDMI can only work between 3.24 V and 3.36 V. According to OS images provided by the board manufacturer this regulator should be set to 3.3 V.
Set DCDC1 and DCDC1SW to 3.3 V in order to fix this.
--- arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts +5 -5
@@ -198,16 +198,16 @@ }; ®_dc1sw { - regulator-min-microvolt = <3000000>; - regulator-max-microvolt = <3000000>; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; regulator-name = "vcc-gmac-phy"; }; ®_dcdc1 { regulator-always-on; - regulator-min-microvolt = <3000000>; - regulator-max-microvolt = <3000000>; - regulator-name = "vcc-3v0"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcc-3v3"; }; ®_dcdc2 {
Signature · 7 lines
2.18.4 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH] ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator
Dne nedelja, 01. november 2020 ob 01:34:16 CET je Pablo Greco napisal(a):
Quoted 8 lines
DCDC1 regulator powers many different subsystems. While some of them can work at 3.0 V, some of them can not. For example, VCC-HDMI can only work between 3.24 V and 3.36 V. According to OS images provided by the board manufacturer this regulator should be set to 3.3 V.
Set DCDC1 and DCDC1SW to 3.3 V in order to fix this.
Fixes 23edc168bd98 ("ARM: dts: sun8i: Add board dts file for Banana Pi M2
Berry")
Quoted 1 line
Fixes 27e81e1970a8 ("ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC
ethernet controller")
Quoted 1 line
Signed-off-by Pablo Greco <[email protected]>
Thanks!
Jernej
PATCH 1/1 ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node
In reply to Pablo GrecoEthernet PHY on BananaPi M2 Berry provides RX and TX delays. Fix ethernet node to reflect that fact.
--- arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts +1 -1
@@ -120,7 +120,7 @@ pinctrl-names = "default"; pinctrl-0 = <&gmac_rgmii_pins>; phy-handle = <&phy1>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-supply = <®_dc1sw>; status = "okay"; };
Signature · 7 lines
2.18.4 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node
Dne nedelja, 01. november 2020 ob 01:34:17 CET je Pablo Greco napisal(a):
Quoted 4 lines
Ethernet PHY on BananaPi M2 Berry provides RX and TX delays. Fix ethernet node to reflect that fact.
Fixes 27e81e1970a8 ("ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC
ethernet controller")
Quoted 1 line
Signed-off-by Pablo Greco <[email protected]>
Thanks!
Jernej
Dne nedelja, 01. november 2020 ob 01:34:15 CET je Pablo Greco napisal(a):
Quoted 10 lines
The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins.
Fix the phy-mode description to correct reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit
bbc4d71d6354("net: phy: realtek: fix rtl8211e rx/tx delay config").Fixes 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")Signed-off-by Pablo Greco <[email protected]>
Thanks!
Jernej
Hi,
Quoted 10 lines · Pablo Greco
The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins.
Fix the phy-mode description to correct reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit
bbc4d71d6354("net: phy: realtek: fix rtl8211e rx/tx delay config").Fixes 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")Signed-off-by Pablo Greco <[email protected]>
Thanks for sending those patches.
However, I'm not entirely sure how you sent it but the odd threading you used (each other patches being in reply to this one without 0/N in the name) seem to confuse the tools we use to apply the patches.
Can you resend it properly?
Thanks!
Maxime
Quoted 15 lines · Maxime Ripard
Hi,
Quoted 10 lines · Pablo Greco
The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins.
Fix the phy-mode description to correct reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit
bbc4d71d6354("net: phy: realtek: fix rtl8211e rx/tx delay config").Fixes 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")Signed-off-by Pablo Greco <[email protected]>Thanks for sending those patches.
Quoted 7 lines
However, I'm not entirely sure how you sent it but the odd threading you used (each other patches being in reply to this one without 0/N in the name) seem to confuse the tools we use to apply the patches.
Can you resend it properly?
Thanks!
Maxime
I prepared them individually but sent them together in a single git-send-email, that must have been the problem. I"ll send them again one by one.
Pablo.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel