remoteproc: ti_k3: fix -Wcast-function-type warning
PATCH 1/1 remoteproc: ti_k3: fix -Wcast-function-type warning
From: Arnd Bergmann <[email protected]>
The function cast causes a warning with "make W=1"
drivers/remoteproc/ti_k3_r5_remoteproc.c: In function 'k3_r5_probe':drivers/remoteproc/ti_k3_r5_remoteproc.c:1368:12: warning: cast between incompatible function types from 'int (*)(struct platform_device *)' to 'void (*)(void *)' [-Wcast-function-type]
Rewrite the code to avoid the cast, and fix the incorrect return type of the callback.
--- drivers/remoteproc/ti_k3_r5_remoteproc.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-)
drivers/remoteproc/ti_k3_r5_remoteproc.c +6 -12
@@ -940,9 +940,9 @@ static int k3_r5_cluster_rproc_init(struct platform_device *pdev)return ret; } -static int k3_r5_cluster_rproc_exit (struct platform_device *pdev) +static void k3_r5_cluster_rproc_exit (void *data) { -struct k3_r5_cluster *cluster =platform_get_drvdata (pdev); +struct k3_r5_cluster *cluster =platform_get_drvdata (data);struct k3_r5_rproc *kproc;struct k3_r5_core *core;struct rproc *rproc;
@@ -967,8 +967,6 @@ static int k3_r5_cluster_rproc_exit(struct platform_device *pdev)rproc_free (rproc); core->rproc =NULL ; } - -return 0 ; } static int k3_r5_core_of_get_internal_memories(struct platform_device *pdev,
@@ -1255,9 +1253,9 @@ static void k3_r5_core_of_exit(struct platform_device *pdev)devres_release_group (dev, k3_r5_core_of_init); } -static void k3_r5_cluster_of_exit (struct platform_device *pdev) +static void k3_r5_cluster_of_exit (void *data) { -struct k3_r5_cluster *cluster =platform_get_drvdata (pdev); +struct k3_r5_cluster *cluster =platform_get_drvdata (data);struct platform_device *cpdev;struct k3_r5_core *core, *temp;
@@ -1351,9 +1349,7 @@ static int k3_r5_probe(struct platform_device *pdev)return ret; } - ret =devm_add_action_or_reset (dev, - (void (*)(void *))k3_r5_cluster_of_exit, - pdev); + ret =devm_add_action_or_reset (dev, k3_r5_cluster_of_exit, pdev);if (ret)return ret;
@@ -1364,9 +1360,7 @@ static int k3_r5_probe(struct platform_device *pdev)return ret; } - ret =devm_add_action_or_reset (dev, - (void (*)(void *))k3_r5_cluster_rproc_exit, - pdev); + ret =devm_add_action_or_reset (dev, k3_r5_cluster_rproc_exit, pdev);if (ret)return ret;
Signature · 1 line
2.27.0
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):
Hello:
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):
Quoted 8 lines · On Mon, 26 Oct 2020 17:05:23 +0100 you wrote:
From: Arnd Bergmann <[email protected]>
The function cast causes a warning with "make W=1"
drivers/remoteproc/ti_k3_r5_remoteproc.c: In function 'k3_r5_probe':drivers/remoteproc/ti_k3_r5_remoteproc.c:1368:12: warning: cast between incompatible function types from 'int (*)(structplatform_device*)' to 'void (*)(void *)' [-Wcast-function-type][...]
Here is the summary with links:
- remoteproc: ti_k3: fix -Wcast-function-type warning
https://git.kernel.org/andersson/remoteproc/c/2316822989a3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html