net/mlx5: fix meter packet missing
PATCH 1/1 net/mlx5: fix meter packet missing
For transfer flow with meter, packet was passed without applying flow action. The group level was multipled by 10 for group level 65531.
This patch fixes this issue by correcting suffix table group level calculation.
--- drivers/net/mlx5/mlx5.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/mlx5/mlx5.h +2 -2
@@ -610,9 +610,9 @@ struct mlx5_flow_tbl_resource {#define MLX5_FLOW_MREG_ACT_TABLE_GROUP (MLX5_MAX_TABLES - 1)#define MLX5_FLOW_MREG_CP_TABLE_GROUP (MLX5_MAX_TABLES - 2)/* Tables for metering splits should be added here. */ -#define MLX5_MAX_TABLES_EXTERNAL (MLX5_MAX_TABLES - 3) -#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4)#define MLX5_FLOW_TABLE_LEVEL_SUFFIX (MLX5_MAX_TABLES - 3) +#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4) +#define MLX5_MAX_TABLES_EXTERNAL MLX5_FLOW_TABLE_LEVEL_METER#define MLX5_MAX_TABLES_FDB UINT16_MAX#define MLX5_FLOW_TABLE_FACTOR 10
Signature · 1 line
2.25.1
PATCH 1/1 net/mlx5: fix meter packet missing
For transfer flow with meter, packet was passed without applying flow action. The group level was multiplied by 10 for group level 65531.
This patch fixes this issue by correcting suffix table group level calculation.
--- drivers/net/mlx5/mlx5.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/mlx5/mlx5.h +2 -2
@@ -610,9 +610,9 @@ struct mlx5_flow_tbl_resource {#define MLX5_FLOW_MREG_ACT_TABLE_GROUP (MLX5_MAX_TABLES - 1)#define MLX5_FLOW_MREG_CP_TABLE_GROUP (MLX5_MAX_TABLES - 2)/* Tables for metering splits should be added here. */ -#define MLX5_MAX_TABLES_EXTERNAL (MLX5_MAX_TABLES - 3) -#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4)#define MLX5_FLOW_TABLE_LEVEL_SUFFIX (MLX5_MAX_TABLES - 3) +#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4) +#define MLX5_MAX_TABLES_EXTERNAL MLX5_FLOW_TABLE_LEVEL_METER#define MLX5_MAX_TABLES_FDB UINT16_MAX#define MLX5_FLOW_TABLE_FACTOR 10
Signature · 1 line
2.25.1
Quoted 15 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Tuesday, November 3, 2020 7:02 PM
To: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>
Cc: [email protected]; Xueming(Steven) Li <[email protected]>; Asaf Penso <[email protected]>; Suanming Mou <[email protected]>; [email protected]
Subject: [PATCH v1] net/mlx5: fix meter packet missingFor transfer flow with meter, packet was passed without applying flow action. The group level was multiplied by 10 for group level 65531.
Quoted 7 lines
This patch fixes this issue by correcting suffix table group level calculation.
Fixes 3e8f3e51fd93 ("net/mlx5: fix meter table definitions")Signed-off-by Xueming Li <[email protected]>
Thanks.
Quoted 22 lines
--- drivers/net/mlx5/mlx5.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/mlx5/mlx5.h index renamed from drivers/net/mlx5/mlx5.h +0
-0
63d263384b..a28f30a5ab100644drivers/net/mlx5/mlx5.h +0
-0@@ -610,9 +610,9 @@ struct mlx5_flow_tbl_resource { #define
MLX5_FLOW_MREG_ACT_TABLE_GROUP(MLX5_MAX_TABLES- 1) #defineMLX5_FLOW_MREG_CP_TABLE_GROUP(MLX5_MAX_TABLES- 2)
/* Tables for metering splits should be added here. */ -#defineMLX5_MAX_TABLES_EXTERNAL(MLX5_MAX_TABLES- 3) -#defineMLX5_FLOW_TABLE_LEVEL_METER(MLX5_MAX_TABLES- 4) #defineMLX5_FLOW_TABLE_LEVEL_SUFFIX(MLX5_MAX_TABLES- 3)drivers/net/mlx5/mlx5.h +2
-1+#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4) #define +MLX5_MAX_TABLES_EXTERNAL MLX5_FLOW_TABLE_LEVEL_METER#define MLX5_MAX_TABLES_FDB UINT16_MAX#define MLX5_FLOW_TABLE_FACTOR 10 --2.25.1
Hi,
Quoted 16 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Xueming Li
Sent: Tuesday, November 3, 2020 1:02 PM
To: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>
Cc: [email protected]; Xueming(Steven) Li <[email protected]>; Asaf Penso <[email protected]>; Suanming Mou <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix meter packet missingFor transfer flow with meter, packet was passed without applying flow action. The group level was multiplied by 10 for group level 65531.
This patch fixes this issue by correcting suffix table group level calculation.
Quoted 9 lines
Fixes 3e8f3e51fd93 ("net/mlx5: fix meter table definitions")Signed-off-by Xueming Li <[email protected]>--- drivers/net/mlx5/mlx5.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
From: Xueming Li
Quoted 10 lines
For transfer flow with meter, packet was passed without applying flow action. The group level was multipled by 10 for group level 65531.
This patch fixes this issue by correcting suffix table group level calculation.
Fixes 3e8f3e51fd93 ("net/mlx5: fix meter table definitions")Signed-off-by Xueming Li <[email protected]>