Skip to contentSkip to conversation

usb: dwc3: Replace of_reset_control_array_get()

PATCH In review Yejune Deng 2 participants 2 messages Nov 3, 2020 – Jan 7, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: dwc3: Replace of_reset_control_array_get()

of_reset_control_array_get_optional_exclusive() looks more readable

---
 drivers/usb/dwc3/dwc3-of-simple.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/dwc3/dwc3-of-simple.c +1 -2
index e62ecd2..e358ff0 100644
@@ -52,8 +52,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
 	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
 		simple->need_reset = true;
 
-	simple->resets = of_reset_control_array_get(np, false, true,
-						    true);
+	simple->resets = of_reset_control_array_get_optional_exclusive(np);
 	if (IS_ERR(simple->resets)) {
 		ret = PTR_ERR(simple->resets);
 		dev_err(dev, "failed to get device resets, err=%d\n", ret);
Signature · 1 line
1.9.1
Reviewed-by on v1 1/1
#1 lore raw

03.11.2020 12:25, Yejune Deng пишет:

Quoted 13 lines

of_reset_control_array_get_optional_exclusive() looks more readable

---
 drivers/usb/dwc3/dwc3-of-simple.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/dwc3/dwc3-of-simple.c +0 -0
index e62ecd2..e358ff0 100644

drivers/usb/dwc3/dwc3-of-simple.c static int dwc3_of_simple_probe(struct platform_device *pdev) · line 58

Quoted 9 lines
drivers/usb/dwc3/dwc3-of-simple.c +1 -2
@@ -52,8 +52,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
 	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
 		simple->need_reset = true;
 
-	simple->resets = of_reset_control_array_get(np, false, true,
-						    true);
+	simple->resets = of_reset_control_array_get_optional_exclusive(np);
 	if (IS_ERR(simple->resets)) {
 		ret = PTR_ERR(simple->resets);
 		dev_err(dev, "failed to get device resets, err=%d\n", ret);