Skip to contentSkip to conversation

event/dlb2: add missing sections to documentation

PATCH In review Timothy McDaniel 2 participants 6 messages Nov 5, 2020 – Nov 10, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 4/4 event/dlb2: add missing sections to documentation

Add queue depth threshold and class of service sections to DLB2 rst file.

Fixes 5433956 ("event/dlb2: add eventdev probe")
---
 doc/guides/eventdevs/dlb2.rst | 47 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)
doc/guides/eventdevs/dlb2.rst +47 -0
index b9f57fd..159f36c 100644
@@ -363,3 +363,50 @@ increase a vdev's per-queue atomic-inflight allocation to (for example) 64:
 
        --vdev=dlb1_event,atm_inflights=64
 
+QID Depth Threshold
+~~~~~~~~~~~~~~~~~~~
+
+DLB2 supports setting and tracking queue depth thresholds. Hardware uses
+the thresholds to track how full a queue is compared to its threshold.
+Four buckets are used
+
+- Less than or equal to 50% of queue depth threshold
+- Greater than 50%, but less than or equal to 75% of depth threshold
+- Greater than 75%, but less than or equal to 100% of depth threshold
+- Greater than 100% of depth thresholds
+
+Per queue threshold metrics are tracked in the DLB2 xstats, and are also
+returned in the impl_opaque field of each received event.
+
+The per qid threshold can be specified as part of the device args, and
+can be applied to all queue, a range of queues, or a single queue, as
+shown below.
+
+    .. code-block:: console
+
+       --vdev=dlb2_event,qid_depth_thresh=all:<threshold_value>
+       --vdev=dlb2_event,qid_depth_thresh=qidA-qidB:<threshold_value>
+       --vdev=dlb2_event,qid_depth_thresh=qid:<threshold_value>
+
+Class of service
+~~~~~~~~~~~~~~~~
+
+DLB2 supports provisioning the DLB2 bandwidth into 4 classes of service.
+
+- Class 4 corresponds to 40% of the DLB2 hardware bandwidth
+- Class 3 corresponds to 30% of the DLB2 hardware bandwidth
+- Class 2 corresponds to 20% of the DLB2 hardware bandwidth
+- Class 1 corresponds to 10% of the DLB2 hardware bandwidth
+- Class 0 corresponds to don't care
+
+The classes are applied globally to the set of ports contained in this
+scheduling domain, which is more appropriate for the bifurcated
+PMD than for the PF PMD, since the PF PMD supports just 1 scheduling
+domain.
+
+Class of service can be specified in the devargs, as follows
+
+    .. code-block:: console
+
+       --vdev=dlb2_event,cos=<0..4>
+
Signature · 1 line
2.6.4
#1 lore raw

PATCH 1/4 event/dlb: fix memory overrun Coverity warning

Fix memory corruption bug caused by passing address of a 16b value, instead of address of a 32b value.

Fixes 1998008 ("event/dlb: add eventdev probe")

Coverity issue: 363715
Cc: [email protected]

---
 drivers/event/dlb/pf/dlb_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/event/dlb/pf/dlb_main.c +2 -2
index 87ab8dd..17e671e 100644
@@ -250,13 +250,13 @@ dlb_pf_reset(struct dlb_dev *dlb_dev)
 {
 	int msix_cap_offset, err_cap_offset, acs_cap_offset, wait_count;
 	uint16_t dev_ctl_word, dev_ctl2_word, lnk_word, lnk_word2;
-	uint16_t rt_ctl_word, pri_reqs_dword,  pri_ctrl_word;
+	uint16_t rt_ctl_word, pri_ctrl_word;
 	struct rte_pci_device *pdev = dlb_dev->pdev;
 	uint16_t devsta_busy_word, devctl_word;
 	int pcie_cap_offset, pri_cap_offset;
 	uint16_t slt_word, slt_word2, cmd;
 	int ret = 0, i = 0;
-	uint32_t dword[16];
+	uint32_t dword[16], pri_reqs_dword;
 	off_t off;
 
 	/* Save PCI config state */
Signature · 1 line
2.6.4
#2 lore raw

Re: [dpdk-dev] [PATCH 1/4] event/dlb: fix memory overrun Coverity warning

Quoted 9 lines · Timothy McDaniel

Fix memory corruption bug caused by passing address of a 16b value, instead of address of a 32b value.

Fixes 1998008 ("event/dlb: add eventdev probe")

Coverity issue: 363715
Cc: [email protected]

Series applied to dpdk-next-eventdev/for-main. Thanks.

Quoted 27 lines
---
 drivers/event/dlb/pf/dlb_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/event/dlb/pf/dlb_main.c +2 -3
index 87ab8dd..17e671e 100644
@@ -250,13 +250,13 @@ dlb_pf_reset(struct dlb_dev *dlb_dev)
 {
        int msix_cap_offset, err_cap_offset, acs_cap_offset, wait_count;
        uint16_t dev_ctl_word, dev_ctl2_word, lnk_word, lnk_word2;
-       uint16_t rt_ctl_word, pri_reqs_dword,  pri_ctrl_word;
+       uint16_t rt_ctl_word, pri_ctrl_word;
        struct rte_pci_device *pdev = dlb_dev->pdev;
        uint16_t devsta_busy_word, devctl_word;
        int pcie_cap_offset, pri_cap_offset;
        uint16_t slt_word, slt_word2, cmd;
        int ret = 0, i = 0;
-       uint32_t dword[16];
+       uint32_t dword[16], pri_reqs_dword;
        off_t off;
 
        /* Save PCI config state */
--

2.6.4

#3 lore raw

Re: [dpdk-dev] [PATCH 1/4] event/dlb: fix memory overrun Coverity warning

Quoted 19 lines

-----Original Message-----
From: Jerin Jacob <[email protected]>
Sent: Tuesday, November 10, 2020 9:36 AM
To: McDaniel, Timothy <[email protected]>
Cc: Eads, Gage <[email protected]>; dpdk-dev <[email protected]>; Carrillo, Erik G <[email protected]>; Van Haaren, Harry <[email protected]>; Jerin Jacob <[email protected]>; [email protected]; dpdk stable <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 1/4] event/dlb: fix memory overrun Coverity warning

Quoted 4 lines · Timothy McDaniel

Fix memory corruption bug caused by passing address of a 16b value, instead of address of a 32b value.

Quoted 8 lines
Quoted 5 lines
Fixes 1998008 ("event/dlb: add eventdev probe")

Coverity issue: 363715
Cc: [email protected]

Series applied to dpdk-next-eventdev/for-main. Thanks.

Thank you, Jerin.

Quoted 28 lines
Quoted 28 lines
---
 drivers/event/dlb/pf/dlb_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/event/dlb/pf/dlb_main.c +2 -3
index 87ab8dd..17e671e 100644
@@ -250,13 +250,13 @@ dlb_pf_reset(struct dlb_dev *dlb_dev)
 {
        int msix_cap_offset, err_cap_offset, acs_cap_offset, wait_count;
        uint16_t dev_ctl_word, dev_ctl2_word, lnk_word, lnk_word2;
-       uint16_t rt_ctl_word, pri_reqs_dword,  pri_ctrl_word;
+       uint16_t rt_ctl_word, pri_ctrl_word;
        struct rte_pci_device *pdev = dlb_dev->pdev;
        uint16_t devsta_busy_word, devctl_word;
        int pcie_cap_offset, pri_cap_offset;
        uint16_t slt_word, slt_word2, cmd;
        int ret = 0, i = 0;
-       uint32_t dword[16];
+       uint32_t dword[16], pri_reqs_dword;
        off_t off;
 
        /* Save PCI config state */
--

2.6.4

#4 lore raw

PATCH 2/4 event/dlb: fix no-effect Coverity warning

In reply to Timothy McDaniel

Remove nonproductive assignment of qmport->cq_depth.

Fixes ee57517 ("event/dlb: add port setup")

Coverity issue: 363717
Cc: [email protected]

---
 drivers/event/dlb/dlb.c | 1 -
 1 file changed, 1 deletion(-)
drivers/event/dlb/dlb.c +0 -1
index 2bb270d..0c95c47 100644
@@ -1000,7 +1000,6 @@ dlb_hw_create_ldb_port(struct dlb_eventdev *dlb,
 	/* The credit window is one high water mark of QEs */
 	qm_port->dir_pushcount_at_credit_expiry = 0;
 	qm_port->cached_dir_credits = cfg.dir_credit_high_watermark;
-	qm_port->cq_depth = cfg.cq_depth;
 	/* CQs with depth < 8 use an 8-entry queue, but withhold credits so
 	 * the effective depth is smaller.
 	 */
Signature · 1 line
2.6.4
#5 lore raw

PATCH 3/4 event/dlb2: fix dereference NULL pointer Coverity warning

In reply to Timothy McDaniel

Add NULL check before using t->mbuf_pool.

Fixes 6f1b828 ("event/dlb2: add self-tests")

Coverity issue: 363719
Cc: [email protected]

---
 drivers/event/dlb2/dlb2_selftest.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/event/dlb2/dlb2_selftest.c +6 -1
index e300067..f433654 100644
@@ -212,7 +212,12 @@ test_stop_flush(struct test *t) /* test to check we can properly flush events */
 		goto err;
 	}
 
-	count = rte_mempool_avail_count(t->mbuf_pool);
+	if (t->mbuf_pool)
+		count = rte_mempool_avail_count(t->mbuf_pool);
+	else {
+		printf("%d: mbuf_pool is NULL\n", __LINE__);
+		goto err;
+	}
 
 	if (rte_event_port_attr_get(evdev,
 				    0,
Signature · 1 line
2.6.4