tools/bpftool: fix attaching flow dissector
Subsystems (4)
PATCH 1/1 tools/bpftool: fix attaching flow dissector
My earlier patch to reject non-zero arguments to flow dissector attach broke attaching via bpftool. Instead of 0 it uses -1 for target_fd. Fix this by passing a zero argument when attaching the flow dissector.
--- tools/bpf/bpftool/prog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/bpf/bpftool/prog.c +1 -1
@@ -940,7 +940,7 @@ static int parse_attach_detach_args(int argc, char **argv, int *progfd, }if (*attach_type ==BPF_FLOW_DISSECTOR ) { - *mapfd =-1 ; + *mapfd =0 ;return 0 ; }
Signature · 1 line
2.25.1
Quoted 8 lines · Lorenz Bauer
My earlier patch to reject non-zero arguments to flow dissector attach broke attaching via bpftool. Instead of 0 it uses -1 for
target_fd. Fix this by passing a zero argument when attaching the flow dissector.Fixes 1b514239e859 ("bpf: flow_dissector: Check value of unused flags to BPF_PROG_ATTACH")Reported-by Jiri Benc <[email protected]>Signed-off-by Lorenz Bauer <[email protected]>
Quoted 20 lines
--- tools/bpf/bpftool/prog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/bpf/bpftool/prog.c +1
-2@@ -940,7 +940,7 @@ static int parse_attach_detach_args(int argc, char **argv, int *progfd, }if (*attach_type ==BPF_FLOW_DISSECTOR ) { - *mapfd =-1 ; + *mapfd =0 ;return 0 ; } --2.25.1
This patch was applied to bpf/bpf.git (refs/heads/master):
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
Quoted 9 lines · On Thu, 5 Nov 2020 11:52:30 +0000 you wrote:
My earlier patch to reject non-zero arguments to flow dissector attach broke attaching via bpftool. Instead of 0 it uses -1 for
target_fd. Fix this by passing a zero argument when attaching the flow dissector.Fixes 1b514239e859 ("bpf: flow_dissector: Check value of unused flags to BPF_PROG_ATTACH")Reported-by Jiri Benc <[email protected]>Signed-off-by Lorenz Bauer <[email protected]>[...]
Here is the summary with links:
- [bpf] tools/bpftool: fix attaching flow dissector
https://git.kernel.org/bpf/bpf/c/f9b7ff0d7f7a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html