Skip to contentSkip to conversation

net/mlx5: fix Tx queue completions on stop

PATCH In review Viacheslav Ovsiienko 3 participants 3 messages Nov 6, 2020 – Nov 9, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix Tx queue completions on stop

The Tx queue completion production index was not reset on Tx queue stop and there were completions remaining from the previous queue run. This caused the wrong completion queue operating and overall Tx queue malfunction on queue restart.

Fixes 161d103b231c ("net/mlx5: add queue start and stop")
---
 drivers/net/mlx5/mlx5_txq.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/mlx5/mlx5_txq.c +1 -0
index faf4e45..d96abef 100644
@@ -154,6 +154,7 @@
 	/* Resync CQE and WQE (WQ in reset state). */
 	rte_io_wmb();
 	*txq->cq_db = rte_cpu_to_be_32(txq->cq_ci);
+	txq->cq_pi = txq->cq_ci;
 	rte_io_wmb();
 }
 
Signature · 1 line
1.8.3.1
Acked-by on v1 1/1
#1 lore raw

From: Viacheslav Ovsiienko

Quoted 9 lines

The Tx queue completion production index was not reset on Tx queue stop and there were completions remaining from the previous queue run. This caused the wrong completion queue operating and overall Tx queue malfunction on queue restart.

Fixes 161d103b231c ("net/mlx5: add queue start and stop")
#2 lore raw
In reply to Viacheslav Ovsiienko

Hi,

Quoted 15 lines

-----Original Message-----
From: Viacheslav Ovsiienko <[email protected]>
Sent: Friday, November 6, 2020 6:58 PM
To: [email protected]
Cc: Raslan Darawsheh <[email protected]>; Alexander Kozyrev <[email protected]>; Matan Azrad <[email protected]>; [email protected]
Subject: [PATCH] net/mlx5: fix Tx queue completions on stop

The Tx queue completion production index was not reset on Tx queue stop and there were completions remaining from the previous queue run. This caused the wrong completion queue operating and overall Tx queue malfunction on queue restart.

Quoted 8 lines
Fixes 161d103b231c ("net/mlx5: add queue start and stop")
---
 drivers/net/mlx5/mlx5_txq.c | 1 +
 1 file changed, 1 insertion(+)

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh