fs/ntfs: remove unused varible attr_len
PATCH 1/1 fs/ntfs: remove unused varible attr_len
This varible isn't used anymore, remove it to skip W=1 warning:fs/ntfs/inode.c:2350:6: warning: variable ‘attr_len’ set but not used [-Wunused-but-set-variable]
--- fs/ntfs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
fs/ntfs/inode.c +1 -2
@@ -2347,7 +2347,6 @@ int ntfs_truncate(struct inode *vi)ATTR_RECORD *a;const char *te =" Leaving file length out of sync with i_size." ;int err, mp_size, size_change, alloc_change; -u32 attr_len;ntfs_debug ("Entering for inode 0x%lx." , vi->i_ino);BUG_ON (NInoAttr (ni));
@@ -2721,7 +2720,7 @@ int ntfs_truncate(struct inode *vi)* this cannot fail since we are making the attribute smaller thus by * definition there is enough space to do so. */ - attr_len =le32_to_cpu (a->length); +le32_to_cpu (a->length); err =ntfs_attr_record_resize (m, a, mp_size +le16_to_cpu (a->data.non_resident.mapping_pairs_offset));BUG_ON (err);
Signature · 1 line
1.8.3.1
Review
Quoted 3 lines · Alex Shi
(quoted diff) +1
-1*/ - attr_len = le32_to_cpu(a->length); + le32_to_cpu(a->length);
This line is also useless. and should be removed. so:
From d1c6de723995adeeecb90c6fd77811dd85b697e6 Mon Sep 17 00:00:00 2001
From: Alex Shi <[email protected]>
Date: Sun, 8 Nov 2020 15:52:32 +0800
Subject: [PATCH] fs/ntfs: remove unused varible attr_len
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This varible isn't used anymore, remove it to skip W=1 warning:fs/ntfs/inode.c:2350:6: warning: variable ‘attr_len’ set but not used [-Wunused-but-set-variable]
--- fs/ntfs/inode.c | 2 -- 1 file changed, 2 deletions(-)
fs/ntfs/inode.c +0 -2
@@ -2347,7 +2347,6 @@ int ntfs_truncate(struct inode *vi)ATTR_RECORD *a;const char *te =" Leaving file length out of sync with i_size." ;int err, mp_size, size_change, alloc_change; -u32 attr_len;ntfs_debug ("Entering for inode 0x%lx." , vi->i_ino);BUG_ON (NInoAttr (ni));
@@ -2721,7 +2720,6 @@ int ntfs_truncate(struct inode *vi)* this cannot fail since we are making the attribute smaller thus by * definition there is enough space to do so. */ - attr_len =le32_to_cpu (a->length); err =ntfs_attr_record_resize (m, a, mp_size +le16_to_cpu (a->data.non_resident.mapping_pairs_offset));BUG_ON (err);
Signature · 1 line
1.8.3.1
Hi Andrew,
Can you also please merge this one? Thanks a lot in advance!
Alex, again, thank you for the patch!
Best regards,
Anton
Quoted 38 lines · Alex Shi
From: Alex Shi <[email protected]>
Date: Sun, 8 Nov 2020 15:52:32 +0800
Subject: [PATCH] fs/ntfs: remove unused varibleattr_lenThis varible isn't used anymore, remove it to skip W=1 warning:
fs/ntfs/inode.c:2350:6: warning: variable ‘attr_len’ set but not used [-Wunused-but-set-variable]Signed-off-by Alex Shi <[email protected]>---
fs/ntfs/inode.c| 2 --1 file changed, 2 deletions(-)fs/ntfs/inode.c +0
-2@@ -2347,7 +2347,6 @@ int ntfs_truncate(struct inode *vi)ATTR_RECORD *a;const char *te =" Leaving file length out of sync with i_size." ;int err, mp_size, size_change, alloc_change; -u32 attr_len;ntfs_debug ("Entering for inode 0x%lx." , vi->i_ino);BUG_ON (NInoAttr (ni));@@ -2721,7 +2720,6 @@ int ntfs_truncate(struct inode *vi)* this cannot fail since we are making the attribute smaller thus by * definition there is enough space to do so. */ - attr_len =le32_to_cpu (a->length); err =ntfs_attr_record_resize (m, a, mp_size +le16_to_cpu (a->data.non_resident.mapping_pairs_offset));BUG_ON (err);Signature · 1 line
1.8.3.1
Signature · 3 lines
Anton Altaparmakov <anton at tuxera.com> (replace at with @) Lead in File System Development, Tuxera Inc., http://www.tuxera.com/ Linux NTFS maintainer