bpf: selftest: Use static globals in tcp_hdr_options and btf_skc_cls_ingress
Subsystems (5)
PATCH 1/1 bpf: selftest: Use static globals in tcp_hdr_options and btf_skc_cls_ingress
Some globals in the tcp_hdr_options test and btf_skc_cls_ingress test are not using static scope. This patch fixes it.
Targeting bpf-next branch as an improvement since it currently does not break the build.
--- .../selftests/bpf/prog_tests/btf_skc_cls_ingress.c | 2 +- .../selftests/bpf/prog_tests/tcp_hdr_options.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-)
tools/testing/selftests/bpf/prog_tests/btf_skc_cls_ingress.c +1 -1
@@ -17,7 +17,7 @@#include "test_btf_skc_cls_ingress.skel.h" static struct test_btf_skc_cls_ingress *skel; -struct sockaddr_in6 srv_sa6; +static struct sockaddr_in6 srv_sa6;static __u32 duration;#define PROG_PIN_FILE "/sys/fs/bpf/btf_skc_cls_ingress"
tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c +6 -6
@@ -18,12 +18,12 @@#define LO_ADDR6 "::1"#define CG_NAME "/tcpbpf-hdr-opt-test" -struct bpf_test_option exp_passive_estab_in; -struct bpf_test_option exp_active_estab_in; -struct bpf_test_option exp_passive_fin_in; -struct bpf_test_option exp_active_fin_in; -struct hdr_stg exp_passive_hdr_stg; -struct hdr_stg exp_active_hdr_stg = { .active = true, }; +static struct bpf_test_option exp_passive_estab_in; +static struct bpf_test_option exp_active_estab_in; +static struct bpf_test_option exp_passive_fin_in; +static struct bpf_test_option exp_active_fin_in; +static struct hdr_stg exp_passive_hdr_stg; +static struct hdr_stg exp_active_hdr_stg = { .active = true, };static struct test_misc_tcp_hdr_options *misc_skel;static struct test_tcp_hdr_options *skel;
Signature · 1 line
2.24.1
Quoted 6 lines · Martin KaFai Lau
Some globals in the
tcp_hdr_optionstest andbtf_skc_cls_ingresstest are not using static scope. This patch fixes it.Targeting bpf-next branch as an improvement since it currently does not break the build.
Quoted 8 lines
Fixes ad2f8eb0095e ("bpf: selftests: Tcp header options")Fixes 9a856cae2217 ("bpf: selftest: Add test_btf_skc_cls_ingress")Signed-off-by Martin KaFai Lau <[email protected]>--- .../selftests/bpf/prog_tests/btf_skc_cls_ingress.c | 2 +- .../selftests/bpf/prog_tests/tcp_hdr_options.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-)
This patch was applied to bpf/bpf-next.git (refs/heads/master):
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
Quoted 11 lines · On Fri, 6 Nov 2020 14:54:02 -0800 you wrote:
Some globals in the
tcp_hdr_optionstest andbtf_skc_cls_ingresstest are not using static scope. This patch fixes it.Targeting bpf-next branch as an improvement since it currently does not break the build.
Fixes ad2f8eb0095e ("bpf: selftests: Tcp header options")Fixes 9a856cae2217 ("bpf: selftest: Add test_btf_skc_cls_ingress")Signed-off-by Martin KaFai Lau <[email protected]>[...]
Here is the summary with links:
- [bpf-next] bpf: selftest: Use static globals in tcp_hdr_options and btf_skc_cls_ingress
https://git.kernel.org/bpf/bpf-next/c/f52b8fd33257
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html