ehci-mxc: Fix host power mask bit for i.MX35
Subsystems (3)
PATCH 1/1 ehci-mxc: Fix host power mask bit for i.MX35
The correct bit for H1_PM is 16, not 8, which is the DP pull-up impedance selection bit.
This issue has been reported by Michael Burkey <[email protected]> and fixed by Christoph Fritz <[email protected]> on Linux, from which these #define-s had been copied.
--- .../drivers/usb/host/ehci-mxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/ehci-mxc.c +1 -1
@@ -67,7 +67,7 @@#define MX35_H1_SIC_SHIFT 21#define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)#define MX35_H1_PP_BIT (1 << 18) -#define MX35_H1_PM_BIT (1 << 8) +#define MX35_H1_PM_BIT (1 << 16)#define MX35_H1_IPPUE_UP_BIT (1 << 7)#define MX35_H1_IPPUE_DOWN_BIT (1 << 6)#define MX35_H1_TLL_BIT (1 << 5)
PATCH 1/1 ehci-mxc: Fix host power mask bit for i.MX35
Quoted 10 lines · Beno?t Th?baudeau
The correct bit for
H1_PMis 16, not 8, which is the DP pull-up impedance selection bit.This issue has been reported by Michael Burkey <[email protected]> and fixed by Christoph Fritz <[email protected]> on Linux, from which these #define-s had been copied.
Signed-off-by Beno?t Th?baudeau <[email protected]>Cc Stefano Babic <[email protected]>Cc Marek Vasut <[email protected]>
Hi Benoit,
Quoted 9 lines
--- .../drivers/usb/host/ehci-mxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/host/ehci-mxc.c +0
-0
drivers/usb/host/ehci-mxc.c line 73
Quoted 8 lines
drivers/usb/host/ehci-mxc.c +1
-1@@ -67,7 +67,7 @@#define MX35_H1_SIC_SHIFT 21#define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)#define MX35_H1_PP_BIT (1 << 18) -#define MX35_H1_PM_BIT (1 << 8) +#define MX35_H1_PM_BIT (1 << 16)#define MX35_H1_IPPUE_UP_BIT (1 << 7)#define MX35_H1_IPPUE_DOWN_BIT (1 << 6)#define MX35_H1_TLL_BIT (1 << 5)
Hey, the patch was sent today to linux-arm ! Very nice you noted and route the bug to u-boot.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 ehci-mxc: Fix host power mask bit for i.MX35
In reply to Benoît ThébaudeauQuoted 20 lines · Beno?t Th?baudeau
The correct bit for
H1_PMis 16, not 8, which is the DP pull-up impedance selection bit.This issue has been reported by Michael Burkey <[email protected]> and fixed by Christoph Fritz <[email protected]> on Linux, from which these #define-s had been copied.
Signed-off-by Beno?t Th?baudeau <[email protected]>Cc Stefano Babic <[email protected]>Cc Marek Vasut <[email protected]>--- .../drivers/usb/host/ehci-mxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/host/ehci-mxc.c +0
-0
drivers/usb/host/ehci-mxc.c line 73
Quoted 8 lines
drivers/usb/host/ehci-mxc.c +1
-1@@ -67,7 +67,7 @@#define MX35_H1_SIC_SHIFT 21#define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)#define MX35_H1_PP_BIT (1 << 18) -#define MX35_H1_PM_BIT (1 << 8) +#define MX35_H1_PM_BIT (1 << 16)#define MX35_H1_IPPUE_UP_BIT (1 << 7)#define MX35_H1_IPPUE_DOWN_BIT (1 << 6)#define MX35_H1_TLL_BIT (1 << 5)
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================