docs/vm: remove unused 3 items explanation for /proc/vmstat
Subsystems (3)
PATCH 1/1 docs/vm: remove unused 3 items explanation for /proc/vmstat
Commit 5647bc293ab1 ("mm: compaction: Move migration fail/success stats to migrate.c"), removed 3 items in /proc/vmstat. but the docs still has their explanation. let's remove them.
"compact_blocks_moved",
"compact_pages_moved",
"compact_pagemigrate_failed",
--- Documentation/admin-guide/mm/transhuge.rst | 15 --------------- 1 file changed, 15 deletions(-)
Documentation/admin-guide/mm/transhuge.rst +0 -15
@@ -401,21 +401,6 @@ compact_fail is incremented if the system tries to compact memory but failed. -compact_pages_moved - is incremented each time a page is moved. If - this value is increasing rapidly, it implies that the system - is copying a lot of data to satisfy the huge page allocation. - It is possible that the cost of copying exceeds any savings - from reduced TLB misses. - -compact_pagemigrate_failed - is incremented when the underlying mechanism - for moving a page failed. - -compact_blocks_moved - is incremented each time memory compaction examines - a huge page aligned range of pages. - It is possible to establish how long the stalls were using the function tracer to record how long was spent in __alloc_pages_nodemask and using the mm_page_alloc tracepoint to identify which allocations were
Signature · 1 line
2.29.GIT
Zi Yan
reviewerQuoted 17 lines · Alex Shi
Commit
5647bc293ab1("mm: compaction: Move migration fail/success stats tomigrate.c"), removed 3 items in/proc/vmstat. but the docs still has their explanation. let's remove them."
compact_blocks_moved",
"compact_pages_moved",
"compact_pagemigrate_failed",Signed-off-by Alex Shi <[email protected]>Cc Jonathan Corbet <[email protected]>Cc Andrew Morton <[email protected]>Cc Yang Shi <[email protected]>Cc "Kirill A. Shutemov" <[email protected]>Cc David Rientjes <[email protected]>Cc Zi Yan <[email protected]>
Quoted 4 lines
--- Documentation/admin-guide/mm/transhuge.rst | 15 --------------- 1 file changed, 15 deletions(-)
LGTM. Reviewed-by: Zi Yan <[email protected]>.
—
Best Regards,
Yan Zi
Jonathan Corbet
maintainerQuoted 7 lines · On Mon, 16 Nov 2020 17:51:22 +0800 Alex Shi <[email protected]> wrote:
Commit
5647bc293ab1("mm: compaction: Move migration fail/success stats tomigrate.c"), removed 3 items in/proc/vmstat. but the docs still has their explanation. let's remove them."
compact_blocks_moved",
"compact_pages_moved",
"compact_pagemigrate_failed",
So a quick look says that the above-mentioned patch didn't remove those three items; two of them were, instead, renamed. Rather than just taking out the old information, it seems we should actually update it to reflect current reality?
Thanks,
jon
Quoted 7 lines · Jonathan Corbet
Quoted 4 lines · On Mon, 16 Nov 2020 17:51:22 +0800 Alex Shi <[email protected]> wrote:
Commit
5647bc293ab1("mm: compaction: Move migration fail/success stats tomigrate.c"), removed 3 items in/proc/vmstat. but the docs still has their explanation. let's remove them.
Quoted 9 lines
Quoted 3 lines
"
compact_blocks_moved",
"compact_pages_moved",
"compact_pagemigrate_failed",So a quick look says that the above-mentioned patch didn't remove those three items; two of them were, instead, renamed. Rather than just taking out the old information, it seems we should actually update it to reflect current reality?
I thought about the replacement, but there are couple of migration events have no explanation:
#ifdef CONFIG_MIGRATION
"pgmigrate_success",
"pgmigrate_fail",
"thp_migration_success",
"thp_migration_fail",
"thp_migration_split",
#endif
It's better to fill them together, also change current explanation accordinglly. but I'm not so confident on this now...
Thanks
Alex