net: stmmac: Use rtnl_lock/unlock on netif_set_real_num_rx_queues() call
Subsystems (4)
PATCH v2 1/1 net: stmmac: Use rtnl_lock/unlock on netif_set_real_num_rx_queues() call
Fix an issue where dump stack is printed on suspend resume flow due to netif_set_real_num_rx_queues() is not called with rtnl_lock held().
---
v2 changelog:
- Move rtnl_lock() before priv->lock and release it after to avoid a possible ABBA deadlock scenario.
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +2 -0
@@ -5272,6 +5272,7 @@ int stmmac_resume(struct device *dev)return ret; } +rtnl_lock ();mutex_lock (&priv->lock);stmmac_reset_queues_param (priv);
@@ -5287,6 +5288,7 @@ int stmmac_resume(struct device *dev)stmmac_enable_all_queues (priv);mutex_unlock (&priv->lock); +rtnl_unlock ();if (!device_may_wakeup (priv->device) || !priv->plat->pmt) {rtnl_lock ();
Signature · 1 line
2.17.0
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 11 lines · On Sun, 15 Nov 2020 15:42:10 +0800 you wrote:
Fix an issue where dump stack is printed on suspend resume flow due to
netif_set_real_num_rx_queues()is not called withrtnl_lockheld().Fixes 686cff3d7022 ("net: stmmac: Fix incorrect location to set real_num_rx|tx_queues")Reported-by Christophe ROULLIER <[email protected]>Tested-by Christophe ROULLIER <[email protected]>Cc Alexandre TORGUE <[email protected]>Reviewed-by Ong Boon Leong <[email protected]>Signed-off-by Wong Vee Khee <[email protected]>[...]
Here is the summary with links:
- [v2,net,1/1] net: stmmac: Use rtnl_lock/unlock on netif_set_real_num_rx_queues() call
https://git.kernel.org/netdev/net/c/8e5debed3901
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html