qed: fix ILT configuration of SRC block
Subsystems (3)
PATCH 1/1 qed: fix ILT configuration of SRC block
The code refactoring of ILT configuration was not complete, the old unused variables were used for the SRC block. That could lead to the memory corruption by HW when rx filters are configured.
This patch completes that refactoring.
--- drivers/net/ethernet/qlogic/qed/qed_cxt.c | 4 ++-- drivers/net/ethernet/qlogic/qed/qed_cxt.h | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-)
drivers/net/ethernet/qlogic/qed/qed_cxt.c +2 -2
@@ -1647,9 +1647,9 @@ static void qed_src_init_pf(struct qed_hwfn *p_hwfn) ilog2(rounded_conn_num));STORE_RT_REG_AGG (p_hwfn,SRC_REG_FIRSTFREE_RT_OFFSET , - p_hwfn->p_cxt_mngr->first_free); + p_hwfn->p_cxt_mngr->src_t2.first_free);STORE_RT_REG_AGG (p_hwfn,SRC_REG_LASTFREE_RT_OFFSET , - p_hwfn->p_cxt_mngr->last_free); + p_hwfn->p_cxt_mngr->src_t2.last_free); }/* Timers PF */
drivers/net/ethernet/qlogic/qed/qed_cxt.h +0 -3
@@ -326,9 +326,6 @@ struct qed_cxt_mngr {/* SRC T2 */ struct qed_src_t2 src_t2; -u32 t2_num_pages; -u64 first_free; -u64 last_free;/* total number of SRQ's for this hwfn */ u32 srq_count;
Signature · 1 line
2.25.1
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 11 lines · On Mon, 16 Nov 2020 16:29:44 +0300 you wrote:
The code refactoring of ILT configuration was not complete, the old unused variables were used for the SRC block. That could lead to the memory corruption by HW when rx filters are configured.
This patch completes that refactoring.Fixes 8a52bbab39c9 (qed: Debug feature: ilt and mdump)Signed-off-by Igor Russkikh <[email protected]>Signed-off-by Ariel Elior <[email protected]>Signed-off-by Dmitry Bogdanov <[email protected]>[...]
Here is the summary with links:
- [net] qed: fix ILT configuration of SRC block
https://git.kernel.org/netdev/net/c/93be52612431
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html