Skip to contentSkip to conversation

soc: amlogic: replace devm_reset_control_array_get()

PATCH Applied Yejune Deng 4 participants 4 messages Nov 18, 2020 – Dec 1, 2020 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: amlogic: replace devm_reset_control_array_get()

devm_reset_control_array_get_exclusive() looks more readable

---
 drivers/soc/amlogic/meson-ee-pwrc.c     | 3 +--
 drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
drivers/soc/amlogic/meson-ee-pwrc.c +1 -2
index ed7d2fb..50bf5d2 100644
@@ -413,8 +413,7 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev,
 			dev_warn(&pdev->dev, "Invalid resets count %d for domain %s\n",
 				 count, dom->desc.name);
 
-		dom->rstc = devm_reset_control_array_get(&pdev->dev, false,
-							 false);
+		dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
 		if (IS_ERR(dom->rstc))
 			return PTR_ERR(dom->rstc);
 	}
drivers/soc/amlogic/meson-gx-pwrc-vpu.c +1 -1
index 8790627..b4615b2 100644
@@ -304,7 +304,7 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
 		return PTR_ERR(regmap_hhi);
 	}
 
-	rstc = devm_reset_control_array_get(&pdev->dev, false, false);
+	rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
 	if (IS_ERR(rstc)) {
 		if (PTR_ERR(rstc) != -EPROBE_DEFER)
 			dev_err(&pdev->dev, "failed to get reset lines\n");
Signature · 1 line
1.9.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Yejune,

Quoted 27 lines · Yejune Deng

devm_reset_control_array_get_exclusive() looks more readable

---
 drivers/soc/amlogic/meson-ee-pwrc.c     | 3 +--
 drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
drivers/soc/amlogic/meson-ee-pwrc.c +1 -2
index ed7d2fb..50bf5d2 100644
@@ -413,8 +413,7 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev,
 			dev_warn(&pdev->dev, "Invalid resets count %d for domain %s\n",
 				 count, dom->desc.name);
 
-		dom->rstc = devm_reset_control_array_get(&pdev->dev, false,
-							 false);
+		dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
 		if (IS_ERR(dom->rstc))
 			return PTR_ERR(dom->rstc);
 	}
drivers/soc/amlogic/meson-gx-pwrc-vpu.c +0 -0
index 8790627..b4615b2 100644

drivers/soc/amlogic/meson-gx-pwrc-vpu.c static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev) · line 310

Quoted 8 lines
drivers/soc/amlogic/meson-gx-pwrc-vpu.c +1 -1
@@ -304,7 +304,7 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
 		return PTR_ERR(regmap_hhi);
 	}
 
-	rstc = devm_reset_control_array_get(&pdev->dev, false, false);
+	rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
 	if (IS_ERR(rstc)) {
 		if (PTR_ERR(rstc) != -EPROBE_DEFER)
 			dev_err(&pdev->dev, "failed to get reset lines\n");

regards
Philipp

maintainer Applied
#3 lore raw
In reply to Yejune Deng
Quoted 1 line · Yejune Deng

devm_reset_control_array_get_exclusive() looks more readable

Applied, thanks!

[1/1] soc: amlogic: replace devm_reset_control_array_get()

      commit: 978d0dbb98c7ce9a5d6897744ac49ac5ff85831e

Best regards,

Signature · 6 lines
Kevin Hilman <[email protected]>

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic