Skip to contentSkip to conversation

iomap: set REQ_NOWAIT according to IOCB_NOWAIT in Direct IO

RFC New Hao Xu 1 participant 4 messages Nov 18, 2020 – Nov 22, 2020

Subsystems (2)
lore
Share & tools
lore

Hao Xu

author
#0 lore raw

RFC 1/1 iomap: set REQ_NOWAIT according to IOCB_NOWAIT in Direct IO

Currently, IOCB_NOWAIT is ignored in direct io, REQ_NOWAIT is only set when IOCB_HIPRI is set. But REQ_NOWAIT should be set as well when IOCB_NOWAIT is set.

---

Hi all,
I tested fio io_uring direct read for a file on ext4 filesystem on a nvme ssd. I found that IOCB_NOWAIT is ignored in iomap layer, which means REQ_NOWAIT is not set in bio->bi_opf. This makes nowait IO a normal IO. Since I'm new to iomap and block layer, I sincerely ask yours opinions in case I misunderstand the code which is very likely to happen.:)

 fs/block_dev.c       | 3 +++
 fs/iomap/direct-io.c | 3 +++
 2 files changed, 6 insertions(+)
fs/block_dev.c +3 -0
index 9e84b1928b94..b7db3b7e2ba1 100644
@@ -424,6 +424,9 @@ static void blkdev_bio_end_io(struct bio *bio)
 		if (!nr_pages) {
 			bool polled = false;
 
+			if ((iocb->ki_flags & IOCB_NOWAIT) && !is_sync)
+				bio->bi_opf |= REQ_NOWAIT;
+
 			if (iocb->ki_flags & IOCB_HIPRI) {
 				bio_set_polled(bio, iocb);
 				polled = true;
fs/iomap/direct-io.c +3 -0
index 933f234d5bec..22f7488bf5e5 100644
@@ -64,6 +64,9 @@ static void iomap_dio_submit_bio(struct iomap_dio *dio, struct iomap *iomap,
 {
 	atomic_inc(&dio->ref);
 
+	if ((dio->iocb->ki_flags & IOCB_NOWAIT) && !is_sync_kiocb(dio->iocb))
+		bio->bi_opf |= REQ_NOWAIT;
+
 	if (dio->iocb->ki_flags & IOCB_HIPRI)
 		bio_set_polled(bio, dio->iocb);
 
Signature · 1 line
1.8.3.1
author
#1 lore raw

RFC 1/1 iomap: set REQ_NOWAIT according to IOCB_NOWAIT in Direct IO

Currently, IOCB_NOWAIT is ignored in direct io, REQ_NOWAIT is only set when IOCB_HIPRI is set. But REQ_NOWAIT should be set as well when IOCB_NOWAIT is set.

---

Hi all,
I tested fio io_uring direct read for a file on ext4 filesystem on a nvme ssd. I found that IOCB_NOWAIT is ignored in iomap layer, which means REQ_NOWAIT is not set in bio->bi_opf. This makes nowait IO a normal IO. Since I'm new to iomap and block layer, I sincerely ask yours opinions in case I misunderstand the code which is very likely to happen.:)

 fs/block_dev.c       | 3 +++
 fs/iomap/direct-io.c | 3 +++
 2 files changed, 6 insertions(+)
fs/block_dev.c +3 -0
index 9e84b1928b94..b7db3b7e2ba1 100644
@@ -424,6 +424,9 @@ static void blkdev_bio_end_io(struct bio *bio)
 		if (!nr_pages) {
 			bool polled = false;
 
+			if (iocb->ki_flags & IOCB_NOWAIT)
+				bio->bi_opf |= REQ_NOWAIT;
+
 			if (iocb->ki_flags & IOCB_HIPRI) {
 				bio_set_polled(bio, iocb);
 				polled = true;
fs/iomap/direct-io.c +3 -0
index 933f234d5bec..22f7488bf5e5 100644
@@ -64,6 +64,9 @@ static void iomap_dio_submit_bio(struct iomap_dio *dio, struct iomap *iomap,
 {
 	atomic_inc(&dio->ref);
 
+	if (dio->iocb->ki_flags & IOCB_NOWAIT)
+		bio->bi_opf |= REQ_NOWAIT;
+
 	if (dio->iocb->ki_flags & IOCB_HIPRI)
 		bio_set_polled(bio, dio->iocb);
 
Signature · 1 line
1.8.3.1
author
#2 lore raw

RFC v2 1/1 iomap: set REQ_NOWAIT according to IOCB_NOWAIT in Direct IO

Currently, IOCB_NOWAIT is ignored in Direct IO, REQ_NOWAIT is only set when IOCB_HIPRI is set. But REQ_NOWAIT should be set as well when IOCB_NOWAIT is set.

---

Hi all,
I tested fio io_uring direct read for a file on ext4 filesystem on a nvme ssd. I found that IOCB_NOWAIT is ignored in iomap layer, which means REQ_NOWAIT is not set in bio->bi_opf. This makes nowait IO a normal IO. Since I'm new to iomap and block layer, I sincerely ask yours opinions in case I misunderstand the code which is very likely to happen.:)

v1->v2:
* add same logic in __blkdev_direct_IO_simple()

 fs/block_dev.c       | 7 +++++++
 fs/iomap/direct-io.c | 3 +++
 2 files changed, 10 insertions(+)
fs/block_dev.c +7 -0
index 9e84b1928b94..f3e9e13a9a9f 100644
@@ -263,6 +263,10 @@ static void blkdev_bio_end_io_simple(struct bio *bio)
 	 	bio.bi_opf = dio_bio_write_op(iocb);
 		task_io_account_write(ret);
 	}
+
+	if (iocb->ki_flags & IOCB_NOWAIT)
+		bio.bi_opf |= REQ_NOWAIT;
+
 	if (iocb->ki_flags & IOCB_HIPRI)
 		bio_set_polled(&bio, iocb);
 
@@ -424,6 +428,9 @@ static void blkdev_bio_end_io(struct bio *bio)
 		if (!nr_pages) {
 			bool polled = false;
 
+			if (iocb->ki_flags & IOCB_NOWAIT)
+				bio->bi_opf |= REQ_NOWAIT;
+
 			if (iocb->ki_flags & IOCB_HIPRI) {
 				bio_set_polled(bio, iocb);
 				polled = true;
fs/iomap/direct-io.c +3 -0
index 933f234d5bec..2e897688ed6d 100644
@@ -64,6 +64,9 @@ static void iomap_dio_submit_bio(struct iomap_dio *dio, struct iomap *iomap,
 {
 	atomic_inc(&dio->ref);
 
+	if (dio->iocb->ki_flags & IOCB_NOWAIT)
+		bio->bi_opf |= REQ_NOWAIT;
+
 	if (dio->iocb->ki_flags & IOCB_HIPRI)
 		bio_set_polled(bio, dio->iocb);
 
Signature · 1 line
1.8.3.1
author
#3 lore raw
Quoted 15 lines · Hao Xu

Currently, IOCB_NOWAIT is ignored in Direct IO, REQ_NOWAIT is only set when IOCB_HIPRI is set. But REQ_NOWAIT should be set as well when IOCB_NOWAIT is set.

---

Hi all,
I tested fio io_uring direct read for a file on ext4 filesystem on a nvme ssd. I found that IOCB_NOWAIT is ignored in iomap layer, which means REQ_NOWAIT is not set in bio->bi_opf. This makes nowait IO a normal IO. Since I'm new to iomap and block layer, I sincerely ask yours opinions in case I misunderstand the code which is very likely to happen.:)

Quoted 7 lines

v1->v2:
* add same logic in __blkdev_direct_IO_simple()

  fs/block_dev.c       | 7 +++++++
  fs/iomap/direct-io.c | 3 +++
  2 files changed, 10 insertions(+)

ping...

Quoted 40 lines
fs/block_dev.c +7 -0
index 9e84b1928b94..f3e9e13a9a9f 100644
@@ -263,6 +263,10 @@ static void blkdev_bio_end_io_simple(struct bio *bio)
  	 	bio.bi_opf = dio_bio_write_op(iocb);
  		task_io_account_write(ret);
  	}
+
+	if (iocb->ki_flags & IOCB_NOWAIT)
+		bio.bi_opf |= REQ_NOWAIT;
+
  	if (iocb->ki_flags & IOCB_HIPRI)
  		bio_set_polled(&bio, iocb);
 
@@ -424,6 +428,9 @@ static void blkdev_bio_end_io(struct bio *bio)
  		if (!nr_pages) {
  			bool polled = false;
 
+			if (iocb->ki_flags & IOCB_NOWAIT)
+				bio->bi_opf |= REQ_NOWAIT;
+
  			if (iocb->ki_flags & IOCB_HIPRI) {
  				bio_set_polled(bio, iocb);
  				polled = true;
fs/iomap/direct-io.c +3 -0
index 933f234d5bec..2e897688ed6d 100644
@@ -64,6 +64,9 @@ static void iomap_dio_submit_bio(struct iomap_dio *dio, struct iomap *iomap,
  {
  	atomic_inc(&dio->ref);
 
+	if (dio->iocb->ki_flags & IOCB_NOWAIT)
+		bio->bi_opf |= REQ_NOWAIT;
+
  	if (dio->iocb->ki_flags & IOCB_HIPRI)
  		bio_set_polled(bio, dio->iocb);