net/mlx5: make ethernet xstats names compliant
PATCH 1/1 net/mlx5: make ethernet xstats names compliant
xstats names for simple stats are mostly standardized in ethdev drivers and should be compliant with [1]
[1] http://doc.dpdk.org/guides/prog_guide/poll_mode_drv.html?highlight=xstats#extended-statistics-api
--- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 54 ++++++++++++++++----------------- 1 file changed, 27 insertions(+), 27 deletions(-)
drivers/net/mlx5/linux/mlx5_ethdev_os.c +27 -27
@@ -1315,71 +1315,71 @@ int mlx5_get_module_eeprom(struct rte_eth_dev *dev,static const struct mlx5_counter_ctrl mlx5_counters_init[] = { { - .dpdk_name ="rx_port_unicast_bytes" , + .dpdk_name ="rx_unicast_bytes" , .ctr_name ="rx_vport_unicast_bytes" , }, { - .dpdk_name ="rx_port_multicast_bytes" , + .dpdk_name ="rx_multicast_bytes" , .ctr_name ="rx_vport_multicast_bytes" , }, { - .dpdk_name ="rx_port_broadcast_bytes" , + .dpdk_name ="rx_broadcast_bytes" , .ctr_name ="rx_vport_broadcast_bytes" , }, { - .dpdk_name ="rx_port_unicast_packets" , + .dpdk_name ="rx_unicast_packets" , .ctr_name ="rx_vport_unicast_packets" , }, { - .dpdk_name ="rx_port_multicast_packets" , + .dpdk_name ="rx_multicast_packets" , .ctr_name ="rx_vport_multicast_packets" , }, { - .dpdk_name ="rx_port_broadcast_packets" , + .dpdk_name ="rx_broadcast_packets" , .ctr_name ="rx_vport_broadcast_packets" , }, { - .dpdk_name ="tx_port_unicast_bytes" , + .dpdk_name ="tx_unicast_bytes" , .ctr_name ="tx_vport_unicast_bytes" , }, { - .dpdk_name ="tx_port_multicast_bytes" , + .dpdk_name ="tx_multicast_bytes" , .ctr_name ="tx_vport_multicast_bytes" , }, { - .dpdk_name ="tx_port_broadcast_bytes" , + .dpdk_name ="tx_broadcast_bytes" , .ctr_name ="tx_vport_broadcast_bytes" , }, { - .dpdk_name ="tx_port_unicast_packets" , + .dpdk_name ="tx_unicast_packets" , .ctr_name ="tx_vport_unicast_packets" , }, { - .dpdk_name ="tx_port_multicast_packets" , + .dpdk_name ="tx_multicast_packets" , .ctr_name ="tx_vport_multicast_packets" , }, { - .dpdk_name ="tx_port_broadcast_packets" , + .dpdk_name ="tx_broadcast_packets" , .ctr_name ="tx_vport_broadcast_packets" , }, { - .dpdk_name ="rx_wqe_err" , + .dpdk_name ="rx_wqe_errors" , .ctr_name ="rx_wqe_err" , }, { - .dpdk_name ="rx_crc_errors_phy" , + .dpdk_name ="rx_phy_crc_errors" , .ctr_name ="rx_crc_errors_phy" , }, { - .dpdk_name ="rx_in_range_len_errors_phy" , + .dpdk_name ="rx_phy_in_range_len_errors" , .ctr_name ="rx_in_range_len_errors_phy" , }, { - .dpdk_name ="rx_symbol_err_phy" , + .dpdk_name ="rx_phy_symbol_errors" , .ctr_name ="rx_symbol_err_phy" , }, { - .dpdk_name ="tx_errors_phy" , + .dpdk_name ="tx_phy_errors" , .ctr_name ="tx_errors_phy" , }, {
@@ -1388,44 +1388,44 @@ int mlx5_get_module_eeprom(struct rte_eth_dev *dev, .dev = 1, }, { - .dpdk_name = "tx_packets_phy", + .dpdk_name = "tx_phy_packets", .ctr_name = "tx_packets_phy", }, { - .dpdk_name = "rx_packets_phy", + .dpdk_name = "rx_phy_packets", .ctr_name = "rx_packets_phy", }, { - .dpdk_name = "tx_discards_phy", + .dpdk_name = "tx_phy_discard_packets", .ctr_name = "tx_discards_phy", }, { - .dpdk_name = "rx_discards_phy", + .dpdk_name = "rx_phy_discard_packets", .ctr_name = "rx_discards_phy", }, { - .dpdk_name = "tx_bytes_phy", + .dpdk_name = "tx_phy_bytes", .ctr_name = "tx_bytes_phy", }, { - .dpdk_name = "rx_bytes_phy", + .dpdk_name = "rx_phy_bytes", .ctr_name = "rx_bytes_phy", }, /* Representor only */ { - .dpdk_name = "rx_packets", + .dpdk_name = "rx_vport_packets", .ctr_name = "vport_rx_packets", }, { - .dpdk_name = "rx_bytes", + .dpdk_name = "rx_vport_bytes", .ctr_name = "vport_rx_bytes", }, { - .dpdk_name = "tx_packets", + .dpdk_name = "tx_vport_packets", .ctr_name = "vport_tx_packets", }, { - .dpdk_name = "tx_bytes", + .dpdk_name = "tx_vport_bytes", .ctr_name = "vport_tx_bytes", }, };
Signature · 1 line
1.8.3.1
Hi,
Quoted 22 lines
-----Original Message-----
From: Viacheslav Ovsiienko <[email protected]>
Sent: Thursday, November 19, 2020 9:18 PM
To: [email protected]
Cc: Raslan Darawsheh <[email protected]>; Matan Azrad <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; [email protected]
Subject: [PATCH] net/mlx5: make ethernet xstats names compliantxstats names for simple stats are mostly standardized in ethdev drivers and should be compliant with [1]
[1]
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdoc.d
pdk.org%2Fguides%2Fprog_guide%2Fpoll_mode_drv.html%3Fhighlight%3Dx stats%23extended-statistics- api&data=04%7C01%7Crasland%40nvidia.com%7Cdc0a60ac1fb24742c03 208d88cbfe0bf%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63741 4103029395985%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=v7Ri pQbvVRPnj%2FBh7GTym%2FZVl6stIRJ8Qnaqas91wXA%3D&reserved=0
Quoted 5 lines
Reported-by Igor Ryzhov <[email protected]>Signed-off-by Viacheslav Ovsiienko <[email protected]>--- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 54 ++++++++++++++++-----------------
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh