FAILED: patch "[PATCH] spi: bcm2835: Fix use-after-free on unbind" failed to apply to 4.19-stable tree

PATCH [email protected] 2 participants 4 messages Nov 23, 2020 – Dec 5, 2020

Subsystems (4)

Stable branch SPI Broadcom BCM2711/BCM2835 Arm architecture Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture

lore

Share & tools

lore

[email protected]

author maintainer

2020-11-23 08:53 UTC #0 lore raw

The patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From e1483ac030fb4c57734289742f1c1d38dca61e22 Mon Sep 17 00:00:00 2001
From: Lukas Wunner <[email protected]>
Date: Wed, 11 Nov 2020 20:07:20 +0100
Subject: [PATCH] spi: bcm2835: Fix use-after-free on unbind

bcm2835_spi_remove() accesses the driver's private data after calling spi_unregister_controller() even though that function releases the last reference on the spi_controller and thereby frees the private data.

Fix by switching over to the new devm_spi_alloc_master() helper which keeps the private data accessible until the driver has unbound.

Fixes f8043872e796 ("spi: add driver for BCM2835")

Reported-by Sascha Hauer <[email protected]>

Reported-by Florian Fainelli <[email protected]>

Signed-off-by Lukas Wunner <[email protected]>

Cc <[email protected]> # v3.10+: 123456789abc: spi: Introduce device-managed SPI controller allocation

Cc <[email protected]> # v3.10+

Cc Vladimir Oltean <[email protected]>

Tested-by Florian Fainelli <[email protected]>

Acked-by Florian Fainelli <[email protected]>

Link https://lore.kernel.org/r/ad66e0a0ad96feb848814842ecf5b6a4539ef35c.1605121038.git.lukas@wunner.de open here

Signed-off-by Mark Brown <[email protected]>

drivers/spi/spi-bcm2835.c +8 ~~-16~~

index 7104cf17b848..197485f2c2b2 100644
@@ -1278,7 +1278,7 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
 	struct bcm2835_spi *bs;
 	int err;
 
-	ctlr = spi_alloc_master(&pdev->dev, ALIGN(sizeof(*bs),
+	ctlr = devm_spi_alloc_master(&pdev->dev, ALIGN(sizeof(*bs),
 						  dma_get_cache_alignment()));
 	if (!ctlr)
 		return -ENOMEM;

@@ -1299,23 +1299,17 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
 	bs->ctlr = ctlr;
 
 	bs->regs = devm_platform_ioremap_resource(pdev, 0);
-	if (IS_ERR(bs->regs)) {
-		err = PTR_ERR(bs->regs);
-		goto out_controller_put;
-	}
+	if (IS_ERR(bs->regs))
+		return PTR_ERR(bs->regs);
 
 	bs->clk = devm_clk_get(&pdev->dev, NULL);
-	if (IS_ERR(bs->clk)) {
-		err = dev_err_probe(&pdev->dev, PTR_ERR(bs->clk),
-				    "could not get clk\n");
-		goto out_controller_put;
-	}
+	if (IS_ERR(bs->clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(bs->clk),
+				     "could not get clk\n");
 
 	bs->irq = platform_get_irq(pdev, 0);
-	if (bs->irq <= 0) {
-		err = bs->irq ? bs->irq : -ENODEV;
-		goto out_controller_put;
-	}
+	if (bs->irq <= 0)
+		return bs->irq ? bs->irq : -ENODEV;
 
 	clk_prepare_enable(bs->clk);

@@ -1349,8 +1343,6 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
 	bcm2835_dma_release(ctlr, bs);
 out_clk_disable:
 	clk_disable_unprepare(bs->clk);
-out_controller_put:
-	spi_controller_put(ctlr);
 	return err;
 }

Lukas Wunner

Tested-by Florian Fainelli Acked-by Florian Fainelli

2020-12-05 09:50 UTC #1 lore raw

Quoted 4 lines · On Mon, Nov 23, 2020 at 09:54:25AM +0100, [email protected] wrote:

The patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

Below please find the backport of e1483ac030fb to linux-4.19.y.

Be aware that it depends on commit 5e844cc37a5c ("spi: Introduce device-managed SPI controller allocation").

Thanks!

-- >8 --
Subject: [PATCH] spi: bcm2835: Fix use-after-free on unbind

[ Upstream commit e1483ac030fb4c57734289742f1c1d38dca61e22 ]

Fix by switching over to the new devm_spi_alloc_master() helper which keeps the private data accessible until the driver has unbound.

Fixes f8043872e796 ("spi: add driver for BCM2835")

Reported-by Sascha Hauer <[email protected]>

Reported-by Florian Fainelli <[email protected]>

Signed-off-by Lukas Wunner <[email protected]>

Cc <[email protected]> # v3.10+: 5e844cc37a5c: spi: Introduce device-managed SPI controller allocation

Cc <[email protected]> # v3.10+

Cc Vladimir Oltean <[email protected]>

Tested-by Florian Fainelli <[email protected]>

Acked-by Florian Fainelli <[email protected]>

Link https://lore.kernel.org/r/ad66e0a0ad96feb848814842ecf5b6a4539ef35c.1605121038.git.lukas@wunner.de open here

Signed-off-by Mark Brown <[email protected]>

---
 drivers/spi/spi-bcm2835.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

drivers/spi/spi-bcm2835.c +5 ~~-10~~

index df6abc75bc16..2908df35466f 100644
@@ -737,7 +737,7 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
 	struct resource *res;
 	int err;
 
-	master = spi_alloc_master(&pdev->dev, sizeof(*bs));
+	master = devm_spi_alloc_master(&pdev->dev, sizeof(*bs));
 	if (!master) {
 		dev_err(&pdev->dev, "spi_alloc_master() failed\n");
 		return -ENOMEM;

@@ -759,23 +759,20 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	bs->regs = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(bs->regs)) {
-		err = PTR_ERR(bs->regs);
-		goto out_master_put;
-	}
+	if (IS_ERR(bs->regs))
+		return PTR_ERR(bs->regs);
 
 	bs->clk = devm_clk_get(&pdev->dev, NULL);
 	if (IS_ERR(bs->clk)) {
 		err = PTR_ERR(bs->clk);
 		dev_err(&pdev->dev, "could not get clk: %d\n", err);
-		goto out_master_put;
+		return err;
 	}
 
 	bs->irq = platform_get_irq(pdev, 0);
 	if (bs->irq <= 0) {
 		dev_err(&pdev->dev, "could not get IRQ: %d\n", bs->irq);
-		err = bs->irq ? bs->irq : -ENODEV;
-		goto out_master_put;
+		return bs->irq ? bs->irq : -ENODEV;
 	}
 
 	clk_prepare_enable(bs->clk);

@@ -803,8 +800,6 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
 
 out_clk_disable:
 	clk_disable_unprepare(bs->clk);
-out_master_put:
-	spi_master_put(master);
 	return err;
 }

Signature · 1 line

2.29.2

Lukas Wunner

2020-12-05 18:44 UTC #2 lore raw

Quoted 7 lines · Lukas Wunner

Quoted 4 lines · On Mon, Nov 23, 2020 at 09:54:25AM +0100, [email protected] wrote:
The patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
Below please find the backport of e1483ac030fb to linux-4.19.y.

This backport is also applicable to 4.14-stable and 4.9-stable, as is the one I sent out for spi-bcm2835aux.c as well as the backport of 666224b43b4b.

Thanks,

Lukas

Lukas Wunner

2020-12-05 18:03 UTC #3 lore raw

Quoted 7 lines · Lukas Wunner

Quoted 6 lines · Lukas Wunner
Quoted 4 lines · On Mon, Nov 23, 2020 at 09:54:25AM +0100, [email protected] wrote:
The patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

Quoted 5 lines

Quoted 1 line
Below please find the backport of e1483ac030fb to linux-4.19.y.
This backport is also applicable to 4.14-stable and 4.9-stable, as is the one I sent out for spi-bcm2835aux.c as well as the backport of 666224b43b4b.

Same for 4.4-stable. As a prerequisite, this requires the 4.9 backport of 5e844cc37a5c ("spi: Introduce device-managed SPI controller allocation") which I sent out today.

Thanks,

Lukas