Skip to contentSkip to conversation

arm64: dts: qcom: sc7180: Remove double pull-up on p-sensor-int-l

PATCH Applied Stephen Boyd 3 participants 3 messages Nov 20, 2020 – Nov 24, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sc7180: Remove double pull-up on p-sensor-int-l

This interrupt has an external pull-up so we don't need to pull it up again. Drop the internal pull here. Note I don't think this really changes anything, just noticed while looking at this irq pin.

Cc Douglas Anderson <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +2 -1
index d48a75afdafb..3eb1ff2483be 100644
@@ -1331,7 +1331,8 @@ pinmux {
 
 		pinconf {
 			pins = "gpio24";
-			bias-pull-up;
+			/* Has external pullup */
+			bias-disable;
 		};
 	};
 

base-commit: ead9f7d7ea9e20843e29e688b53859cea20044ee
prerequisite-patch-id: 239dd75c9c3d2ef544f95466280f296fc217c096

Signature · 1 line
https://chromeos.dev
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 10 lines · Stephen Boyd

This interrupt has an external pull-up so we don't need to pull it up again. Drop the internal pull here. Note I don't think this really changes anything, just noticed while looking at this irq pin.

Cc Douglas Anderson <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
#2 lore raw
In reply to Stephen Boyd
This patch was applied to qcom/linux.git (refs/heads/for-next):

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

Quoted 8 lines · On Fri, 20 Nov 2020 12:09:13 -0800 you wrote:

This interrupt has an external pull-up so we don't need to pull it up again. Drop the internal pull here. Note I don't think this really changes anything, just noticed while looking at this irq pin.

Cc Douglas Anderson <[email protected]>

[...]

Here is the summary with links:
- arm64: dts: qcom: sc7180: Remove double pull-up on p-sensor-int-l

    https://git.kernel.org/qcom/c/d5276bfa0ca6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html