drm: rcar-du: Use drm_dev_put
Subsystems (3)
PATCH 1/1 drm: rcar-du: Use drm_dev_put
As specified in drm_drv.c, drm_dev_unref is a compatibility alias for drm_dev_put and shouldn't be used in new code. So, use drm_dev_put instead.
--- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/rcar-du/rcar_du_drv.c +1 -1
@@ -378,7 +378,7 @@ static int rcar_du_remove(struct platform_device *pdev)drm_kms_helper_poll_fini (ddev);drm_mode_config_cleanup (ddev); -drm_dev_unref (ddev); +drm_dev_put (ddev);return 0 ; }
Signature · 6 lines
2.14.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Vaishali,
Thank you for the patch.
Quoted 3 lines · On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote:
As specified in
drm_drv.c,drm_dev_unrefis a compatibility alias fordrm_dev_putand shouldn't be used in new code. So, usedrm_dev_putinstead.
This looks good to me. However, how about taking it one step further and mass- patching all drivers to use drm_dev_put() ? We could then remove drm_dev_unref() completely.
Quoted 19 lines
Signed-off-by Vaishali Thakkar <[email protected]>--- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/rcar-du/rcar_du_drv.cindex05745e86d73e..418a80e6b2f4100644drivers/gpu/drm/rcar-du/rcar_du_drv.c +1
-1@@ -378,7 +378,7 @@ static int rcar_du_remove(struct platform_device *pdev)drm_kms_helper_poll_fini (ddev);drm_mode_config_cleanup (ddev); -drm_dev_unref (ddev); +drm_dev_put (ddev);return 0 ; }
Signature · 10 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 4 lines · Laurent Pinchart
Hi Vaishali,
Thank you for the patch.
Quoted 8 lines
Quoted 3 lines · On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote:
As specified in
drm_drv.c,drm_dev_unrefis a compatibility alias fordrm_dev_putand shouldn't be used in new code. So, usedrm_dev_putinstead.This looks good to me. However, how about taking it one step further and mass- patching all drivers to use
drm_dev_put()? We could then removedrm_dev_unref()completely.
Sure thing! Do you want me to fold this patch in that patchset or will you be fine with applying this separately?
Quoted 27 lines
Quoted 11 lines
Signed-off-by Vaishali Thakkar <[email protected]>--- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/rcar-du/rcar_du_drv.cindex05745e86d73e..418a80e6b2f4100644drivers/gpu/drm/rcar-du/rcar_du_drv.c static int rcar_du_remove(struct platform_device *pdev) · line 384
Quoted 8 lines
drivers/gpu/drm/rcar-du/rcar_du_drv.c +1
-1@@ -378,7 +378,7 @@ static int rcar_du_remove(struct platform_device *pdev)drm_kms_helper_poll_fini (ddev);drm_mode_config_cleanup (ddev); -drm_dev_unref (ddev); +drm_dev_put (ddev);return 0 ; }--
Regards,Laurent Pinchart
Signature · 6 lines
Vaishali http://vaishalithakkar.in/ _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Vaishali,
Quoted 6 lines · On Wednesday, 25 April 2018 16:42:59 EEST Vaishali Thakkar wrote:
Quoted 5 lines · Laurent Pinchart
Quoted 3 lines · On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote:
As specified in
drm_drv.c,drm_dev_unrefis a compatibility alias fordrm_dev_putand shouldn't be used in new code. So, usedrm_dev_putinstead.
Quoted 6 lines
Quoted 3 lines
This looks good to me. However, how about taking it one step further and mass- patching all drivers to use
drm_dev_put()? We could then removedrm_dev_unref()completely.Sure thing! Do you want me to fold this patch in that patchset or will you be fine with applying this separately?
I don't think we should split the change in one patch per driver, so if you send a single patch (to be applied through drm-misc) I think it would make sense to fold this change in.
Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
Signed-off-by Vaishali Thakkar <[email protected]>---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/rcar-du/rcar_du_drv.cindex05745e86d73e..418a80e6b2f4100644drivers/gpu/drm/rcar-du/rcar_du_drv.c +1
-1@@ -378,7 +378,7 @@ static int rcar_du_remove(struct platform_device *pdev)drm_kms_helper_poll_fini (ddev);drm_mode_config_cleanup (ddev); -drm_dev_unref (ddev); +drm_dev_put (ddev);return 0 ; }
Signature · 10 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel