eal: fix build on armv7
PATCH 1/1 eal: fix build on armv7
Caught by OBS on armv7:
In file included from .../lib/librte_eal/include/rte_string_fns.h:21,
from .../lib/librte_kvargs/rte_kvargs.c:9:
.../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__rte_aligned'
67 | typedef uint64_t unaligned_uint64_t __rte_aligned(1);
| ^~~~~~~~~~~~~
.../lib/librte_eal/include/rte_common.h:68:37: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__rte_aligned'
68 | typedef uint32_t unaligned_uint32_t __rte_aligned(1);
| ^~~~~~~~~~~~~
.../lib/librte_eal/include/rte_common.h:69:37: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__rte_aligned'
69 | typedef uint16_t unaligned_uint16_t __rte_aligned(1);
| ^~~~~~~~~~~~~make[3]: *** [.../mk/internal/rte.compile-pre.mk:116: rte_kvargs.o] Error 1
Fixes f35e5b3e07b2 ("replace alignment attributes")
Signed-off-by David Marchand <[email protected]>
--- lib/librte_eal/include/rte_common.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
lib/librte_eal/include/rte_common.h +5 -5
@@ -63,6 +63,11 @@ extern "C" { __GNUC_PATCHLEVEL__)#endif +/** +* Force alignment +*/ +#define __rte_aligned (a) __attribute__((__aligned__(a))) +#ifdef RTE_ARCH_STRICT_ALIGN typedef uint64_t unaligned_uint64_t __rte_aligned(1); typedef uint32_t unaligned_uint32_t __rte_aligned(1);
@@ -73,11 +78,6 @@ typedef uint32_t unaligned_uint32_t;typedef uint16_t unaligned_uint16_t ;#endif -/** -* Force alignment -*/ -#define __rte_aligned (a) __attribute__((__aligned__(a))) -/** * Force a structure to be packed */
Signature · 1 line
2.23.0
23/04/2020 16:24, David Marchand:
Quoted 16 lines
Caught by OBS on armv7:
In file included from
.../lib/librte_eal/include/rte_string_fns.h:21,from .../lib/librte_kvargs/rte_kvargs.c:9: .../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__rte_aligned' 67 | typedef uint64_t unaligned_uint64_t __rte_aligned(1); | ^~~~~~~~~~~~~ .../lib/librte_eal/include/rte_common.h:68:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__rte_aligned' 68 | typedef uint32_t unaligned_uint32_t __rte_aligned(1); | ^~~~~~~~~~~~~ .../lib/librte_eal/include/rte_common.h:69:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__rte_aligned' 69 | typedef uint16_t unaligned_uint16_t __rte_aligned(1); | ^~~~~~~~~~~~~
Quoted 5 lines
make[3]: *** [
.../mk/internal/rte.compile-pre.mk:116: rte_kvargs.o] Error 1Fixes f35e5b3e07b2 ("replace alignment attributes")Signed-off-by David Marchand <[email protected]>
It deserves few words explanation about RTE_ARCH_STRICT_ALIGN.
Acked-by Thomas Monjalon <[email protected]>
Quoted 17 lines · David Marchand
Caught by OBS on armv7:
In file included from
.../lib/librte_eal/include/rte_string_fns.h:21,from .../lib/librte_kvargs/rte_kvargs.c:9: .../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__rte_aligned' 67 | typedef uint64_t unaligned_uint64_t __rte_aligned(1); | ^~~~~~~~~~~~~ .../lib/librte_eal/include/rte_common.h:68:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__rte_aligned' 68 | typedef uint32_t unaligned_uint32_t __rte_aligned(1); | ^~~~~~~~~~~~~ .../lib/librte_eal/include/rte_common.h:69:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__rte_aligned' 69 | typedef uint16_t unaligned_uint16_t __rte_aligned(1); | ^~~~~~~~~~~~~
Quoted 5 lines
make[3]: *** [
.../mk/internal/rte.compile-pre.mk:116: rte_kvargs.o] Error 1Fixes f35e5b3e07b2 ("replace alignment attributes")Signed-off-by David Marchand <[email protected]>
Acked-by Thomas Monjalon <[email protected]>
Applied with mention of RTE_ARCH_STRICT_ALIGN in commitlog.
Signature · 1 line
David Marchand