Fixes kernel crash generating from bam_dma_irq()
Subsystems (2)
PATCH 1/1 Fixes kernel crash generating from bam_dma_irq()
While performing suspend/resume, we were getting below kernel crash.
[ 54.541672] [FTS][Info]gesture suspend... [ 54.605256] [FTS][Error][GESTURE]Enter into gesture(suspend) failed! [ 54.605256] [ 58.345850] irq event 10: bogus return value fffffff3
......
[ 58.345966] [<ffff0000080830f0>] el1_irq+0xb0/0x124 [ 58.345971] [<ffff000008085360>] arch_cpu_idle+0x10/0x18 [ 58.345975] [<ffff0000081077f4>] do_idle+0x1ac/0x1e0 [ 58.345979] [<ffff0000081079c8>] cpu_startup_entry+0x20/0x28 [ 58.345983] [<ffff000008a80ed0>] rest_init+0xd0/0xdc [ 58.345988] [<ffff0000091c0b48>] start_kernel+0x390/0x3a4 [ 58.345990] handlers: [ 58.345994] [<ffff0000085120d0>] bam_dma_irq
The reason for the crash we found is, bam_dma_irq() was returning negative value when the device resumes in some conditions.
In addition, the irq handler should have one of the below return values.
IRQ_NONE interrupt was not from this device or was not handled IRQ_HANDLED interrupt was handled by this device IRQ_WAKE_THREAD handler requests to wake the handler thread
Therefore, to resolve this crash, we have changed the return value to IRQ_NONE.
--- drivers/dma/qcom/bam_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/qcom/bam_dma.c +1 -1
@@ -875,7 +875,7 @@ static irqreturn_t bam_dma_irq(int irq, void *data) ret =bam_pm_runtime_get_sync (bdev->dev);if (ret <0 ) -return ret; +return IRQ_NONE ;if (srcs &BAM_IRQ ) { clr_mask =readl_relaxed (bam_addr (bdev,0 ,BAM_IRQ_STTS ));
Signature · 1 line
2.7.4
Vinod Koul
maintainerHi Parth,
Quoted 20 lines · Parth Y Shah
While performing suspend/resume, we were getting below kernel crash.
[ 54.541672] [FTS][Info]gesture suspend... [ 54.605256] [FTS][Error][GESTURE]Enter into gesture(suspend) failed! [ 54.605256] [ 58.345850] irq event 10: bogus return value fffffff3......
[ 58.345966] [<ffff0000080830f0>] el1_irq+0xb0/0x124 [ 58.345971] [<ffff000008085360>] arch_cpu_idle+0x10/0x18 [ 58.345975] [<ffff0000081077f4>] do_idle+0x1ac/0x1e0 [ 58.345979] [<ffff0000081079c8>] cpu_startup_entry+0x20/0x28 [ 58.345983] [<ffff000008a80ed0>] rest_init+0xd0/0xdc [ 58.345988] [<ffff0000091c0b48>] start_kernel+0x390/0x3a4 [ 58.345990] handlers: [ 58.345994] [<ffff0000085120d0>] bam_dma_irqThe reason for the crash we found is,
bam_dma_irq()was returning negative value when the device resumes in some conditions.
Quoted 8 lines
In addition, the irq handler should have one of the below return values.
IRQ_NONE interrupt was not from this device or was not handled IRQ_HANDLED interrupt was handled by this device IRQ_WAKE_THREAD handler requests to wake the handler threadTherefore, to resolve this crash, we have changed the return value to
IRQ_NONE.
The change and explanation look good to me, unfortunately the patch title is incorrect. It describes the fix it does and not the change in this patch. Also do add subsystem and driver tags to the patch! git log would tell you this information
Consider: "dmaengine: bam_dma: fix return of bam_dma_irq()" as a suggestion.
drivers/dma/qcom/bam_dma.c static irqreturn_t bam_dma_irq(int irq, void *data) · line 876
Quoted 13 lines
Signed-off-by Parth Y Shah <[email protected]>--- drivers/dma/qcom/bam_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/dma/qcom/bam_dma.c +0
-0@@ -875,7 +875,7 @@ static irqreturn_t bam_dma_irq(int irq, void *data) ret =bam_pm_runtime_get_sync (bdev->dev);
Also this looks wrong to me. get_sync() can sleep and we cant invoke that in an irq. Srini have you seen this issue
Quoted 8 lines
drivers/dma/qcom/bam_dma.c +1
-1if (ret <0 ) -return ret; +return IRQ_NONE ;if (srcs &BAM_IRQ ) { clr_mask =readl_relaxed (bam_addr (bdev,0 ,BAM_IRQ_STTS ));Signature · 1 line
2.7.4
Signature · 1 line
~Vinod
This patch was applied to qcom/linux.git (refs/heads/for-next):
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
Quoted 9 lines · On Sun, 6 Dec 2020 15:51:34 +0530 you wrote:
While performing suspend/resume, we were getting below kernel crash.
[ 54.541672] [FTS][Info]gesture suspend... [ 54.605256] [FTS][Error][GESTURE]Enter into gesture(suspend) failed! [ 54.605256] [ 58.345850] irq event 10: bogus return value fffffff3......
[...]
Here is the summary with links:
- Fixes kernel crash generating from bam_dma_irq()
https://git.kernel.org/qcom/c/4421fe533296
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html