Skip to contentSkip to conversation

gfs2: Fix the crc32c dependency

PATCH New Andreas Gruenbacher 2 participants 2 messages Feb 1, 2018 GFS2 file system

lore
Share & tools
lore

Andreas Gruenbacher

author maintainer
#0 lore raw

PATCH 1/1 gfs2: Fix the crc32c dependency

Depend on LIBCRC32C which uses the crypto API to select the appropriate crc32c implementation. With the CRYPTO and CRYPTO_CRC32C dependencies, gfs2 would still need to use the crypto API directly like ext4 and btrfs do, which isn't necessary.

---
 fs/gfs2/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/gfs2/Kconfig +1 -2
index c0225d4b5435..3ed2b088dcfd 100644
@@ -3,8 +3,7 @@ config GFS2_FS
 	depends on (64BIT || LBDAF)
 	select FS_POSIX_ACL
 	select CRC32
-	select CRYPTO
-	select CRYPTO_CRC32C
+	select LIBCRC32C
 	select QUOTACTL
 	select FS_IOMAP
 	help
Signature · 1 line
2.14.3
#1 lore raw

PATCH 1/1 gfs2: Fix the crc32c dependency

----- Original Message -----

| Depend on LIBCRC32C which uses the crypto API to select the appropriate
| crc32c implementation.  With the CRYPTO and CRYPTO_CRC32C dependencies,
| gfs2 would still need to use the crypto API directly like ext4 and btrfs
| do, which isn't necessary.
| 
| Signed-off-by: Andreas Gruenbacher <[email protected]>
| ---

Hi,

Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs?h=for-next&id=dcb2cd55cf43fe06ada66265c1e088a4b08d3e3d

Regards,

Bob Peterson
Red Hat File Systems