Skip to contentSkip to conversation

ath10k: Fix error handling in case of CE pipe init failure

PATCH In review Rakesh Pillai 3 participants 4 messages Dec 11, 2020 – Dec 17, 2020 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: Fix error handling in case of CE pipe init failure

Currently if the copy engine pipe init fails for snoc based chipsets, the rri is not freed.

Fix this error handling for copy engine pipe init
failure.

Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1

Fixes 4945af5b264f ("ath10k: enable SRRI/DRRI support on ddr for WCN3990")
---
 drivers/net/wireless/ath/ath10k/snoc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath10k/snoc.c +3 -2
index fd41f25..daae470 100644
@@ -1045,12 +1045,13 @@ static int ath10k_snoc_hif_power_up(struct ath10k *ar,
 	ret = ath10k_snoc_init_pipes(ar);
 	if (ret) {
 		ath10k_err(ar, "failed to initialize CE: %d\n", ret);
-		goto err_wlan_enable;
+		goto err_free_rri;
 	}
 
 	return 0;
 
-err_wlan_enable:
+err_free_rri:
+	ath10k_ce_free_rri(ar);
 	ath10k_snoc_wlan_disable(ar);
 
 	return ret;
Signature · 7 lines
2.7.4


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Rakesh Pillai

Currently if the copy engine pipe init fails for snoc based chipsets, the rri is not freed.

Fix this error handling for copy engine pipe init
failure.

Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1

Fixes 4945af5b264f ("ath10k: enable SRRI/DRRI support on ddr for WCN3990")

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

#2 lore raw
In reply to Rakesh Pillai
Quoted 6 lines · Rakesh Pillai

Currently if the copy engine pipe init fails for snoc based chipsets, the rri is not freed.

Fix this error handling for copy engine pipe init
failure.

Quoted 6 lines

Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1

Fixes 4945af5b264f ("ath10k: enable SRRI/DRRI support on ddr for WCN3990")

Patch applied to ath-next branch of ath.git, thanks.

31561e8557cd ath10k: Fix error handling in case of CE pipe init failure

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#3 lore raw
In reply to Rakesh Pillai
Quoted 6 lines · Rakesh Pillai

Currently if the copy engine pipe init fails for snoc based chipsets, the rri is not freed.

Fix this error handling for copy engine pipe init
failure.

Quoted 6 lines

Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1

Fixes 4945af5b264f ("ath10k: enable SRRI/DRRI support on ddr for WCN3990")

Patch applied to ath-next branch of ath.git, thanks.

31561e8557cd ath10k: Fix error handling in case of CE pipe init failure

Signature · 9 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k