drm/amd/display: Fixed kernel test robot warning
Subsystems (3)
PATCH 1/1 drm/amd/display: Fixed kernel test robot warning
Kernel test robot throws below warning ->
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5349:5:
warning: no previous prototype for 'amdgpu_dm_crtc_atomic_set_property' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5349:5:
warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_set_property' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5373:5:
warning: no previous prototype for 'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5373:5:
warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes]
As these functions are only used inside amdgpu_dm.c, these can be made static.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -2
@@ -5328,7 +5328,7 @@ static void dm_crtc_reset_state(struct drm_crtc *crtc) }#ifdef CONFIG_DEBUG_FS -int amdgpu_dm_crtc_atomic_set_property (struct drm_crtc *crtc, +static int amdgpu_dm_crtc_atomic_set_property (struct drm_crtc *crtc,struct drm_crtc_state *crtc_state,struct drm_property *property,uint64_t val)
@@ -5352,7 +5352,7 @@ int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,return 0 ; } -int amdgpu_dm_crtc_atomic_get_property (struct drm_crtc *crtc, +static int amdgpu_dm_crtc_atomic_get_property (struct drm_crtc *crtc,const struct drm_crtc_state *state,struct drm_property *property,uint64_t *val)
Signature · 6 lines
1.9.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
AppliedQuoted 16 lines · Souptick Joarder
Kernel test robot throws below warning ->
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5349:5:
warning: no previous prototype for 'amdgpu_dm_crtc_atomic_set_property' [-Wmissing-prototypes]drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5349:5:
warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_set_property' [-Wmissing-prototypes]drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5373:5:
warning: no previous prototype for 'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes]drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5373:5:
warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes]
Quoted 5 lines
As these functions are only used inside
amdgpu_dm.c, these can be made static.Reported-by kernel test robot <[email protected]>Signed-off-by Souptick Joarder <[email protected]>
Applied. Thanks!
Alex
Quoted 29 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2
-3@@ -5328,7 +5328,7 @@ static void dm_crtc_reset_state(struct drm_crtc *crtc) }#ifdef CONFIG_DEBUG_FS -int amdgpu_dm_crtc_atomic_set_property (struct drm_crtc *crtc, +static int amdgpu_dm_crtc_atomic_set_property (struct drm_crtc *crtc,struct drm_crtc_state *crtc_state,struct drm_property *property,uint64_t val)@@ -5352,7 +5352,7 @@ int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,return 0 ; } -int amdgpu_dm_crtc_atomic_get_property (struct drm_crtc *crtc, +static int amdgpu_dm_crtc_atomic_get_property (struct drm_crtc *crtc,const struct drm_crtc_state *state,struct drm_property *property,uint64_t *val) --1.9.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel