Skip to contentSkip to conversation

net: core: fix msleep() is not accurate

PATCH In review Yejune Deng 2 participants 2 messages Dec 15, 2020 – Dec 16, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: core: fix msleep() is not accurate

See Documentation/timers/timers-howto.rst, msleep() is not for (1ms - 20ms), use usleep_range() instead.

---
 net/core/dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/core/dev.c +2 -2
index d33099f..c0aa52f 100644
@@ -6726,9 +6726,9 @@ void napi_disable(struct napi_struct *n)
 	set_bit(NAPI_STATE_DISABLE, &n->state);
 
 	while (test_and_set_bit(NAPI_STATE_SCHED, &n->state))
-		msleep(1);
+		usleep_range(10, 200);
 	while (test_and_set_bit(NAPI_STATE_NPSVC, &n->state))
-		msleep(1);
+		usleep_range(10, 200);
 
 	hrtimer_cancel(&n->timer);
 
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 4 lines · On Tue, 15 Dec 2020 10:04:25 +0800 Yejune Deng wrote:

See Documentation/timers/timers-howto.rst, msleep() is not for (1ms - 20ms), use usleep_range() instead.

# Form letter - net-next is closed

We have already sent the networking pull request for 5.11 and therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only.

Please repost when net-next reopens after 5.11-rc1 is cut.

Look out for the announcement on the mailing list or check:
http://vger.kernel.org/~davem/net-next.html

RFC patches sent for review only are obviously welcome at any time.