Skip to contentSkip to conversation

net: mvpp2: Fix GoP port 3 Networking Complex Control configurations

PATCH Applied [email protected] 2 participants 2 messages Dec 20, 2020 – Dec 22, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 net: mvpp2: Fix GoP port 3 Networking Complex Control configurations

From: Stefan Chulski <[email protected]>

During GoP port 2 Networking Complex Control mode of operation configurations, also GoP port 3 mode of operation was wrongly set.
Patch removes these configurations.

Fixes f84bf386f395 ("net: mvpp2: initialize the GoP")

---

Changes in v4:
- Remove rename change.
Changes in v3:
- No changes.
Changes in v2:
- Added Fixes tag.

 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +1 -1
index d64dc12..82c6bef 100644
@@ -1231,7 +1231,7 @@ static void mvpp22_gop_init_rgmii(struct mvpp2_port *port)
 
 	regmap_read(priv->sysctrl_base, GENCONF_CTRL0, &val);
 	if (port->gop_id == 2)
-		val |= GENCONF_CTRL0_PORT0_RGMII | GENCONF_CTRL0_PORT1_RGMII;
+		val |= GENCONF_CTRL0_PORT0_RGMII;
 	else if (port->gop_id == 3)
 		val |= GENCONF_CTRL0_PORT1_RGMII_MII;
 	regmap_write(priv->sysctrl_base, GENCONF_CTRL0, val);
Signature · 1 line
1.9.1
#1 lore raw
This patch was applied to netdev/net.git (refs/heads/master):

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

Quoted 11 lines · On Sun, 20 Dec 2020 13:02:29 +0200 you wrote:

From: Stefan Chulski <[email protected]>

During GoP port 2 Networking Complex Control mode of operation configurations, also GoP port 3 mode of operation was wrongly set.
Patch removes these configurations.

Fixes f84bf386f395 ("net: mvpp2: initialize the GoP")

[...]

Here is the summary with links:
- [net,v4] net: mvpp2: Fix GoP port 3 Networking Complex Control configurations

    https://git.kernel.org/netdev/net/c/2575bc1aa9d5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html