leds: mt6360: Add LED driver for MT6360
Subsystems (3)
v13 cover leds: mt6360: Add LED driver for MT6360
In-Reply-To:
This patch series add MT6360 LED support contains driver and binding document
Gene Chen (5)
leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH
leds: flash: Fix multicolor no-ops registration by return 0
dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions
dt-bindings: leds: Add bindings for MT6360 LED
leds: mt6360: Add LED driver for MT6360
Documentation/devicetree/bindings/leds/leds-mt6360.yaml | 159 +++ drivers/leds/Kconfig | 13 drivers/leds/Makefile | 1 drivers/leds/leds-mt6360.c | 827 ++++++++++++++++ include/dt-bindings/leds/common.h | 1 include/linux/led-class-flash.h | 42 include/linux/led-class-multicolor.h | 42 7 files changed, 1049 insertions(+), 36 deletions(-)
changelogs between v1 & v2
- add led driver with mfd
changelogs between v2 & v3
- independent add led driver
- add dt-binding document
- refactor macros definition for easy to debug
- parse device tree by fwnode
- use devm*ext to register led class device
changelogs between v3 & v4
- fix binding document description
- use GENMASK and add unit postfix to definition
- isink register led class device
changelogs between v4 & v5
- change rgb isink to multicolor control
- add binding reference to mfd yaml
changelogs between v5 & v6
- Use DT to decide RGB LED is multicolor device or indicator device only
changelogs between v6 & v7
- Add binding multicolor device sample code
- Add flash ops mutex lock
- Remove V4L2 init with indicator device
changelogs between v7 & v8
- Add mutex for led fault get ops
- Fix flash and multicolor no-ops return 0
- Add LED_FUNCTION_MOONLIGHT
changelogs between v8 & v9
- reuse api in flash and multicolor header
changelogs between v9 & v10
- add comment for reuse registration functions in flash and multicolor
changelogs between v10 & v11
- match dt-binding reg property comment to the functionality name
- remove exist patch in linux-next
- dicide multicolor channel by color definitiion
changelogs between v11 & v12
- Fix print size_t by %zu
- Fix dt-binding name regular experssion
changelogs between v12 & v13
- Fix kbuild test rebot build error
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
PATCH v13 1/5 leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH
From: Gene Chen <[email protected]>
Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH, and move the same registration functions outside of #ifdef block.
--- include/linux/led-class-flash.h | 42 ++++++++++++++++++++++++++++++++--------- 1 file changed, 33 insertions(+), 9 deletions(-)
include/linux/led-class-flash.h +33 -9
@@ -85,6 +85,7 @@ static inline struct led_classdev_flash *lcdev_to_flcdev( return container_of(lcdev, struct led_classdev_flash, led_cdev); } +#if IS_ENABLED (CONFIG_LEDS_CLASS_FLASH )/** * led_classdev_flash_register_ext - register a new object of LED class with * init data and with support for flash LEDs
@@ -98,12 +99,6 @@ int led_classdev_flash_register_ext(struct device *parent,struct led_classdev_flash *fled_cdev, struct led_init_data *init_data); -static inline int led_classdev_flash_register (struct device *parent, -struct led_classdev_flash *fled_cdev) -{ -return led_classdev_flash_register_ext (parent, fled_cdev,NULL ); -} -/** * led_classdev_flash_unregister - unregisters an object of led_classdev class * with support for flash LEDs
@@ -118,15 +113,44 @@ int devm_led_classdev_flash_register_ext(struct device *parent, struct led_init_data *init_data); +void devm_led_classdev_flash_unregister (struct device *parent, +struct led_classdev_flash *fled_cdev); + +#else + +static inline int led_classdev_flash_register_ext (struct device *parent, +struct led_classdev_flash *fled_cdev, +struct led_init_data *init_data) +{ +return 0 ; +} + +static inline void led_classdev_flash_unregister (struct led_classdev_flash *fled_cdev) {}; +static inline int devm_led_classdev_flash_register_ext (struct device *parent, +struct led_classdev_flash *fled_cdev, +struct led_init_data *init_data) +{ +return 0 ; +} + +static inline void devm_led_classdev_flash_unregister (struct device *parent, +struct led_classdev_flash *fled_cdev) +{}; + +#endif /* IS_ENABLED(CONFIG_LEDS_CLASS_FLASH) */ + +static inline int led_classdev_flash_register (struct device *parent, +struct led_classdev_flash *fled_cdev) +{ +return led_classdev_flash_register_ext (parent, fled_cdev,NULL ); +} +static inline int devm_led_classdev_flash_register (struct device *parent,struct led_classdev_flash *fled_cdev) {return devm_led_classdev_flash_register_ext (parent, fled_cdev,NULL ); } -void devm_led_classdev_flash_unregister (struct device *parent, -struct led_classdev_flash *fled_cdev); -/** * led_set_flash_strobe - setup flash strobe * @fled_cdev: the flash LED to set strobe on
Signature · 7 lines
2.7.4 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
PATCH v13 2/5 leds: flash: Fix multicolor no-ops registration by return 0
In reply to Gene ChenFrom: Gene Chen <[email protected]>
Fix multicolor no-ops registration by return 0,
and move the same registration functions outside of #ifdef block.
--- include/linux/led-class-multicolor.h | 42 +++++++++++++----------------------- 1 file changed, 15 insertions(+), 27 deletions(-)
include/linux/led-class-multicolor.h +15 -27
@@ -44,12 +44,6 @@ int led_classdev_multicolor_register_ext(struct device *parent,struct led_classdev_mc *mcled_cdev, struct led_init_data *init_data); -static inline int led_classdev_multicolor_register (struct device *parent, -struct led_classdev_mc *mcled_cdev) -{ -return led_classdev_multicolor_register_ext (parent, mcled_cdev,NULL ); -} -/** * led_classdev_multicolor_unregister - unregisters an object of led_classdev * class with support for multicolor LEDs
@@ -68,13 +62,6 @@ int devm_led_classdev_multicolor_register_ext(struct device *parent,struct led_classdev_mc *mcled_cdev, struct led_init_data *init_data); -static inline int devm_led_classdev_multicolor_register (struct device *parent, -struct led_classdev_mc *mcled_cdev) -{ -return devm_led_classdev_multicolor_register_ext (parent, mcled_cdev, -NULL ); -} -void devm_led_classdev_multicolor_unregister (struct device *parent,struct led_classdev_mc *mcled_cdev);#else
@@ -83,27 +70,33 @@ static inline int led_classdev_multicolor_register_ext(struct device *parent, struct led_classdev_mc *mcled_cdev, struct led_init_data *init_data) { - return -EINVAL; -} - -static inline int led_classdev_multicolor_register (struct device *parent, -struct led_classdev_mc *mcled_cdev) -{ -return led_classdev_multicolor_register_ext (parent, mcled_cdev,NULL ); +return 0 ; }static inline void led_classdev_multicolor_unregister (struct led_classdev_mc *mcled_cdev) {};static inline int led_mc_calc_color_components (struct led_classdev_mc *mcled_cdev,enum led_brightness brightness) { -return -EINVAL ; +return 0 ; }static inline int devm_led_classdev_multicolor_register_ext (struct device *parent,struct led_classdev_mc *mcled_cdev,struct led_init_data *init_data) { -return -EINVAL ; +return 0 ; +} + +static inline void devm_led_classdev_multicolor_unregister (struct device *parent, +struct led_classdev_mc *mcled_cdev) +{}; + +#endif /* IS_ENABLED(CONFIG_LEDS_CLASS_MULTICOLOR) */ + +static inline int led_classdev_multicolor_register (struct device *parent, +struct led_classdev_mc *mcled_cdev) +{ +return led_classdev_multicolor_register_ext (parent, mcled_cdev,NULL ); } static inline int devm_led_classdev_multicolor_register(struct device *parent,
@@ -113,9 +106,4 @@ static inline int devm_led_classdev_multicolor_register(struct device *parent, NULL); } -static inline void devm_led_classdev_multicolor_unregister (struct device *parent, -struct led_classdev_mc *mcled_cdev) -{}; - -#endif /* IS_ENABLED(CONFIG_LEDS_CLASS_MULTICOLOR) */ #endif /* _LINUX_MULTICOLOR_LEDS_H_INCLUDED */
Signature · 7 lines
2.7.4 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Re: [PATCH v13 2/5] leds: flash: Fix multicolor no-ops registration by return 0
Quoted 7 lines · Gene Chen
From: Gene Chen <[email protected]>
Fix multicolor no-ops registration by return 0,
and move the same registration functions outside of #ifdef block.Signed-off-by Gene Chen <[email protected]>Acked-by Jacek Anaszewski <[email protected]>
I applied the first two.
Best regards,
Pavel
Signature · 1 line
http://www.livejournal.com/~pavelmachek
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
PATCH v13 3/5 dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions
In reply to Gene ChenFrom: Gene Chen <[email protected]>
Add LED_FUNCTION_MOONLIGHT definitions
--- include/dt-bindings/leds/common.h | 1 + 1 file changed, 1 insertion(+)
include/dt-bindings/leds/common.h +1 -0
@@ -78,6 +78,7 @@#define LED_FUNCTION_INDICATOR "indicator"#define LED_FUNCTION_LAN "lan"#define LED_FUNCTION_MAIL "mail" +#define LED_FUNCTION_MOONLIGHT "moonlight"#define LED_FUNCTION_MTD "mtd"#define LED_FUNCTION_PANIC "panic"#define LED_FUNCTION_PROGRAMMING "programming"
Signature · 7 lines
2.7.4 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Re: [PATCH v13 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions
Hi!
Quoted 7 lines
From: Gene Chen <[email protected]>
Add
LED_FUNCTION_MOONLIGHTdefinitionsSigned-off-by Gene Chen <[email protected]>Acked-by Jacek Anaszewski <[email protected]>Acked-by Rob Herring <[email protected]>
No, sorry, I don't believe we need another define for flash/torch.
Best regards,
Pavel
Signature · 1 line
http://www.livejournal.com/~pavelmachek
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Re: [PATCH v13 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions
Pavel Machek <[email protected]> 於 2021年2月19日 週五 下午6:47寫道:
Quoted 5 lines
Hi!
Quoted 2 lines
From: Gene Chen <[email protected]>
Quoted 8 lines
Quoted 5 lines
Add
LED_FUNCTION_MOONLIGHTdefinitionsSigned-off-by Gene Chen <[email protected]>Acked-by Jacek Anaszewski <[email protected]>Acked-by Rob Herring <[email protected]>No, sorry, I don't believe we need another define for flash/torch.
As previous discuss,
Quoted 4 lines
We use term "Moonlight" as reference says
"When you are trying to imitate moonlight you need to use low voltage, softer lighting. You don’t want something that’s too bright" which is focus on brightness instead of color.
If any concern about this change, maybe we use LED_FUNCTION_INDICATOR instead? (refs: https://lkml.org/lkml/2020/11/24/1267)
Quoted 4 lines
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Re: [PATCH v13 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions
Gene Chen <[email protected]> 於 2021年3月2日 週二 下午2:08寫道:
Quoted 16 lines
Pavel Machek <[email protected]> 於 2021年2月19日 週五 下午6:47寫道:
Quoted 5 lines
Hi!
Quoted 2 lines
From: Gene Chen <[email protected]>
Quoted 8 lines
Quoted 5 lines
Add
LED_FUNCTION_MOONLIGHTdefinitionsSigned-off-by Gene Chen <[email protected]>Acked-by Jacek Anaszewski <[email protected]>Acked-by Rob Herring <[email protected]>No, sorry, I don't believe we need another define for flash/torch.
Quoted 8 lines
As previous discuss,
Quoted 4 lines
We use term "Moonlight" as reference says
"When you are trying to imitate moonlight you need to use low voltage, softer lighting. You don’t want something that’s too bright" which is focus on brightness instead of color.If any concern about this change, maybe we use
LED_FUNCTION_INDICATORinstead? (refs: https://lkml.org/lkml/2020/11/24/1267)
Is there any update?
Quoted 4 lines
Quoted 4 lines
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
PATCH v13 4/5 dt-bindings: leds: Add bindings for MT6360 LED
In reply to Gene ChenFrom: Gene Chen <[email protected]>
Add bindings document for LED support on MT6360 PMIC
--- .../devicetree/bindings/leds/leds-mt6360.yaml | 159 +++++++++++++++++++++ 1 file changed, 159 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml
Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file +159 -0
@@ -0,0 +1,159 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LED driver for MT6360 PMIC from MediaTek Integrated. + +maintainers: + - Gene Chen <[email protected]> + +description: | + This module is part of the MT6360 MFD device. + see Documentation/devicetree/bindings/mfd/mt6360.yaml + Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, + and 4-channel RGB LED support Register/Flash/Breath Mode + +properties: + compatible: + const: mediatek,mt6360-led + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^(multi-)?led@[0-5]$": + type: object + $ref: common.yaml# + description: + Properties for a single LED. + + properties: + reg: + description: Index of the LED. + enum: + - 0 # LED output ISINK1 + - 1 # LED output ISINK2 + - 2 # LED output ISINK3 + - 3 # LED output ISINKML + - 4 # LED output FLASH1 + - 5 # LED output FLASH2 + +unevaluatedProperties: false + +required: + - compatible + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/leds/common.h> + led-controller { + compatible = "mediatek,mt6360-led"; + #address-cells = <1>; + #size-cells = <0>; + + multi-led@0 { + reg = <0>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_RGB>; + led-max-microamp = <24000>; + #address-cells = <1>; + #size-cells = <0>; + led@0 { + reg = <0>; + color = <LED_COLOR_ID_RED>; + }; + led@1 { + reg = <1>; + color = <LED_COLOR_ID_GREEN>; + }; + led@2 { + reg = <2>; + color = <LED_COLOR_ID_BLUE>; + }; + }; + led@3 { + reg = <3>; + function = LED_FUNCTION_MOONLIGHT; + color = <LED_COLOR_ID_WHITE>; + led-max-microamp = <150000>; + }; + led@4 { + reg = <4>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <1>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + led@5 { + reg = <5>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <2>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + }; + + - | + + led-controller { + compatible = "mediatek,mt6360-led"; + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_RED>; + led-max-microamp = <24000>; + }; + led@1 { + reg = <1>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_GREEN>; + led-max-microamp = <24000>; + }; + led@2 { + reg = <2>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_BLUE>; + led-max-microamp = <24000>; + }; + led@3 { + reg = <3>; + function = LED_FUNCTION_MOONLIGHT; + color = <LED_COLOR_ID_WHITE>; + led-max-microamp = <150000>; + }; + led@4 { + reg = <4>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <1>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + led@5 { + reg = <5>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <2>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + }; +...
Signature · 7 lines
2.7.4 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
PATCH v13 5/5 leds: mt6360: Add LED driver for MT6360
In reply to Gene ChenFrom: Gene Chen <[email protected]>
Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for moonlight LED.
--- drivers/leds/Kconfig | 13 + drivers/leds/Makefile | 1 + drivers/leds/leds-mt6360.c | 827 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 841 insertions(+) create mode 100644 drivers/leds/leds-mt6360.c
drivers/leds/Kconfig +13 -0
@@ -271,6 +271,19 @@ config LEDS_MT6323 This option enables support for on-chip LED drivers found on Mediatek MT6323 PMIC. +config LEDS_MT6360 + tristate "LED Support for Mediatek MT6360 PMIC" + depends on LEDS_CLASS && OF + depends on LEDS_CLASS_FLASH || !LEDS_CLASS_FLASH + depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS + depends on MFD_MT6360 + help + This option enables support for dual Flash LED drivers found on + Mediatek MT6360 PMIC. + Independent current sources supply for each flash LED support torch + and strobe mode. + config LEDS_S3C24XX tristate "LED Support for Samsung S3C24XX GPIO LEDs" depends on LEDS_CLASS
drivers/leds/Makefile +1 -0
@@ -66,6 +66,7 @@ obj-$(CONFIG_LEDS_MIKROTIK_RB532) += leds-rb532.o obj-$(CONFIG_LEDS_MLXCPLD) += leds-mlxcpld.o obj-$(CONFIG_LEDS_MLXREG) += leds-mlxreg.o obj-$(CONFIG_LEDS_MT6323) += leds-mt6323.o +obj-$(CONFIG_LEDS_MT6360) += leds-mt6360.o obj-$(CONFIG_LEDS_NET48XX) += leds-net48xx.o obj-$(CONFIG_LEDS_NETXBIG) += leds-netxbig.o obj-$(CONFIG_LEDS_NIC78BX) += leds-nic78bx.o
drivers/leds/leds-mt6360.c new file +827 -0
827 lines not on this page · raw message
Signature · 7 lines
2.7.4 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Matthias Brugger
maintainerQuoted 1 line · Gene Chen
From: Gene Chen <[email protected]>
[...]
drivers/leds/leds-mt6360.c line 814
Quoted 7 lines
drivers/leds/leds-mt6360.c new file +7
-0+ +static const struct of_device_id __maybe_unused mt6360_led_of_id[] = { + { .compatible ="mediatek,mt6360-led" , }, + {} +}; +MODULE_DEVICE_TABLE (of, mt6360_led_of_id); +
I think we should fix MFD code to not need to use a DT binding here. See [1].
Regards,
Matthias
[1] https://lore.kernel.org/linux-mediatek/[email protected]/
Quoted 4 lines
drivers/leds/leds-mt6360.c new file +3
-0+static struct platform_driver mt6360_led_driver = { + .driver = { + .name ="mt6360-led" ,
drivers/leds/leds-mt6360.c line 827
Quoted 10 lines
drivers/leds/leds-mt6360.c new file +10
-0+ .of_match_table = mt6360_led_of_id, + }, + .probe = mt6360_led_probe, + .remove = mt6360_led_remove, +}; +module_platform_driver (mt6360_led_driver); + +MODULE_AUTHOR ("Gene Chen <[email protected]>" ); +MODULE_DESCRIPTION ("MT6360 LED Driver" ); +MODULE_LICENSE ("GPL v2" );
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Hi!
Quoted 5 lines
From: Gene Chen <[email protected]>
Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for moonlight LED.
What kind of ninja mutant hardware is this?
Can we make this go to drivers/leds/flash?
drivers/leds/leds-mt6360.c line 205
Quoted 6 lines
drivers/leds/leds-mt6360.c new file +6
-0+static int mt6360_flash_brightness_set (struct led_classdev_flash *fl_cdev,u32 brightness) +{ +/* +* Due to the current spike when turning on flash, let brightness to be kept by framework. +* This empty function is used to prevent led_classdev_flash register ops check failure. +*/
Please stick to 80 columns.
drivers/leds/leds-mt6360.c line 688
Quoted 3 lines
drivers/leds/leds-mt6360.c new file +3
-0+static int mt6360_init_common_properties (struct mt6360_led *led,struct led_init_data *init_data) +{ +const char *const states[] = {"off" ,"keep" ,"on" };
No need for space between * and const.
Best regards,
Pavel
Signature · 1 line
http://www.livejournal.com/~pavelmachek
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek