input: ariel-pwrbutton.c: Remove unused variable ariel_pwrbutton_id_table[]
Subsystems (2)
PATCH 1/1 input: ariel-pwrbutton.c: Remove unused variable ariel_pwrbutton_id_table[]
Kernel test robot throws below warning ->
Quoted 2 lines
Quoted 2 lines
drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable 'ariel_pwrbutton_id_table' [-Wunused-const-variable]
static const struct spi_device_id ariel_pwrbutton_id_table[] = {
^1 warning generated.
Remove unused variable ariel_pwrbutton_id_table[] if no plan to use it further.
--- drivers/input/misc/ariel-pwrbutton.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/input/misc/ariel-pwrbutton.c +0 -6
@@ -149,12 +149,6 @@ static int ariel_pwrbutton_probe(struct spi_device *spi) };MODULE_DEVICE_TABLE (of, ariel_pwrbutton_of_match); -static const struct spi_device_id ariel_pwrbutton_id_table[] = { - {"wyse-ariel-ec-input" ,0 }, - {} -}; -MODULE_DEVICE_TABLE (spi, ariel_pwrbutton_id_table); -static struct spi_driver ariel_pwrbutton_driver = { .driver = { .name ="dell-wyse-ariel-ec-input" ,
Signature · 1 line
1.9.1
Quoted 7 lines · Souptick Joarder
Kernel test robot throws below warning ->
Quoted 2 lines
Quoted 2 lines
drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable 'ariel_pwrbutton_id_table' [-Wunused-const-variable]static const struct spi_device_id ariel_pwrbutton_id_table[] = { ^
Quoted 7 lines
1 warning generated.
Remove unused variable ariel_pwrbutton_id_table[] if no plan to use it further.
Reported-by kernel test robot <[email protected]>Signed-off-by Souptick Joarder <[email protected]>
Any comment on this patch ?
Quoted 24 lines
--- drivers/input/misc/ariel-pwrbutton.c | 6 ------ 1 file changed, 6 deletions(-)drivers/input/misc/ariel-pwrbutton.c +0
-7@@ -149,12 +149,6 @@ static int ariel_pwrbutton_probe(struct spi_device *spi) };MODULE_DEVICE_TABLE (of, ariel_pwrbutton_of_match); -static const struct spi_device_id ariel_pwrbutton_id_table[] = { - {"wyse-ariel-ec-input" ,0 }, - {} -}; -MODULE_DEVICE_TABLE (spi, ariel_pwrbutton_id_table); -static struct spi_driver ariel_pwrbutton_driver = { .driver = { .name ="dell-wyse-ariel-ec-input" , --1.9.1
Dmitry Torokhov
maintainerQuoted 10 lines · Souptick Joarder
Quoted 9 lines · Souptick Joarder
Kernel test robot throws below warning ->
Quoted 2 lines
Quoted 2 lines
drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable 'ariel_pwrbutton_id_table' [-Wunused-const-variable]static const struct spi_device_id ariel_pwrbutton_id_table[] = { ^1 warning generated.
Quoted 7 lines
Quoted 5 lines
Remove unused variable ariel_pwrbutton_id_table[] if no plan to use it further.
Reported-by kernel test robot <[email protected]>Signed-off-by Souptick Joarder <[email protected]>Any comment on this patch ?
Lubomir, would you prefer to remove the table or add it to the driver structure as ariel_pwrbutton_driver->id_table?
Thanks.
Signature · 1 line
Dmitry
Lubomir Rintel
Reviewed-byQuoted 14 lines · Dmitry Torokhov
Quoted 13 lines · Souptick Joarder
Quoted 12 lines · Souptick Joarder
Kernel test robot throws below warning ->
Quoted 2 lines
Quoted 2 lines
drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable 'ariel_pwrbutton_id_table' [-Wunused-const-variable]static const struct spi_device_id ariel_pwrbutton_id_table[] = { ^1 warning generated.
Remove unused variable ariel_pwrbutton_id_table[] if no plan to use it further.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Reported-by kernel test robot <[email protected]>Signed-off-by Souptick Joarder <[email protected]>Any comment on this patch ?
Lubomir, would you prefer to remove the table or add it to the driver structure as
ariel_pwrbutton_driver->id_table?
I believe it can be safely dropped, as the OF match seems to be sufficient.
Thank you for the patch Souptick.
Quoted 5 lines
Thanks.
Signature · 1 line
Dmitry
Quoted 23 lines · Lubomir Rintel
Quoted 14 lines · Dmitry Torokhov
Quoted 13 lines · Souptick Joarder
Quoted 12 lines · Souptick Joarder
Kernel test robot throws below warning ->
Quoted 2 lines
Quoted 2 lines
drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable 'ariel_pwrbutton_id_table' [-Wunused-const-variable]static const struct spi_device_id ariel_pwrbutton_id_table[] = { ^1 warning generated.
Remove unused variable ariel_pwrbutton_id_table[] if no plan to use it further.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Reported-by kernel test robot <[email protected]>Signed-off-by Souptick Joarder <[email protected]>Any comment on this patch ?
Lubomir, would you prefer to remove the table or add it to the driver structure as
ariel_pwrbutton_driver->id_table?
Quoted 6 lines
I believe it can be safely dropped, as the OF match seems to be sufficient.
Thank you for the patch Souptick.
Reviewed-by Lubomir Rintel <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry