ibmvnic: fix login buffer memory leak
PATCH 1/1 ibmvnic: fix login buffer memory leak
Commit 34f0f4e3f488 ("ibmvnic: Fix login buffer memory leaks") frees login_rsp_buffer in release_resources() and send_login() because handle_login_rsp() does not free it.
Commit f3ae59c0c015 ("ibmvnic: store RX and TX subCRQ handle array in ibmvnic_adapter struct") frees login_rsp_buffer in handle_login_rsp(). It seems unnecessary to free it in release_resources() and send_login(). There are chances that handle_login_rsp returns earlier without freeing buffers. Double-checking the buffer is harmless since release_login_buffer and release_login_rsp_buffer will
do nothing if buffer is already freed.
--- drivers/net/ethernet/ibm/ibmvnic.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/ethernet/ibm/ibmvnic.c +3 -0
@@ -934,6 +934,7 @@ static void release_resources(struct ibmvnic_adapter *adapter)release_rx_pools (adapter);release_napi (adapter); +release_login_buffer (adapter);release_login_rsp_buffer (adapter); }
@@ -3730,7 +3731,9 @@ static int send_login(struct ibmvnic_adapter *adapter)return -1 ; } +release_login_buffer (adapter);release_login_rsp_buffer (adapter); + client_data_len =vnic_client_data_len (adapter); buffer_size =
Signature · 1 line
2.23.0
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 11 lines · On Sat, 19 Dec 2020 15:39:19 -0600 you wrote:
Commit
34f0f4e3f488("ibmvnic: Fix login buffer memory leaks") freeslogin_rsp_bufferinrelease_resources()andsend_login()becausehandle_login_rsp()does not free it.
Commitf3ae59c0c015("ibmvnic: store RX and TX subCRQ handle array inibmvnic_adapterstruct") freeslogin_rsp_bufferinhandle_login_rsp(). It seems unnecessary to free it inrelease_resources()andsend_login(). There are chances thathandle_login_rspreturns earlier without freeing buffers. Double-checking the buffer is harmless sincerelease_login_bufferandrelease_login_rsp_bufferwill
do nothing if buffer is already freed.
Quoted 1 line
[...]
Here is the summary with links:
- [net] ibmvnic: fix login buffer memory leak
https://git.kernel.org/netdev/net/c/a0c8be56affa
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html