qede: fix offload for IPIP tunnel packets
Subsystems (3)
PATCH 1/1 qede: fix offload for IPIP tunnel packets
IPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time.
--- drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/net/ethernet/qlogic/qede/qede_fp.c +5 -0
@@ -1799,6 +1799,11 @@ netdev_features_t qede_features_check(struct sk_buff *skb, ntohs(udp_hdr(skb)->dest) != gnv_port))return features & ~(NETIF_F_CSUM_MASK |NETIF_F_GSO_MASK ); + }else if (l4_proto ==IPPROTO_IPIP ) { +/* IPIP tunnels are unknown to the device or at least unsupported natively, +* offloads for them can't be done trivially, so disable them for such skb. +*/ +return features & ~(NETIF_F_CSUM_MASK |NETIF_F_GSO_MASK ); } }
Signature · 1 line
1.8.3.1
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 10 lines · On Mon, 21 Dec 2020 06:55:30 -0800 you wrote:
IPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time.
Signed-off-by Manish Chopra <[email protected]>Signed-off-by Sudarsana Kalluru <[email protected]>Signed-off-by Igor Russkikh <[email protected]>[...]
Here is the summary with links:
- [net,1/1] qede: fix offload for IPIP tunnel packets
https://git.kernel.org/netdev/net/c/5d5647dad259
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Quoted 41 lines
-----Original Message-----
From: Manish Chopra <[email protected]>
Sent: Monday, December 21, 2020 8:26 PM
To: [email protected]
Cc: [email protected]; Ariel Elior <[email protected]>; Igor Russkikh <[email protected]>; Sudarsana Reddy Kalluru <[email protected]>
Subject: [PATCH net 1/1] qede: fix offload for IPIP tunnel packetsIPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time.
Signed-off-by Manish Chopra <[email protected]>Signed-off-by Sudarsana Kalluru <[email protected]>Signed-off-by Igor Russkikh <[email protected]>--- drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/net/ethernet/qlogic/qede/qede_fp.c +3
-0@@ -1799,6 +1799,11 @@ netdev_features_t qede_features_check(struct sk_buff *skb, ntohs(udp_hdr(skb)->dest) != gnv_port))return features & ~(NETIF_F_CSUM_MASK |NETIF_F_GSO_MASK ); + }else if (l4_proto ==IPPROTO_IPIP ) { +/* IPIP tunnels are unknown to the device or at least unsupported natively, +* offloads for them can't be done trivially, so disable them for such skb.
drivers/net/ethernet/qlogic/qede/qede_fp.c +2
-0+*/ + return features & ~(NETIF_F_CSUM_MASK |
NETIF_F_GSO_MASK);drivers/net/ethernet/qlogic/qede/qede_fp.c +0
-1} } --
Quoted 1 line
1.8.3.1
Hello Jakub, can you please queue up for stable releases (specifically for long term linux 5.4)?
Thanks,
Manish
Jakub Kicinski
maintainerQuoted 34 lines · On Thu, 24 Dec 2020 10:46:47 +0000 Manish Chopra wrote:
Quoted 34 lines
-----Original Message-----
From: Manish Chopra <[email protected]>
Sent: Monday, December 21, 2020 8:26 PM
To: [email protected]
Cc: [email protected]; Ariel Elior <[email protected]>; Igor Russkikh <[email protected]>; Sudarsana Reddy Kalluru <[email protected]>
Subject: [PATCH net 1/1] qede: fix offload for IPIP tunnel packetsIPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time.
Signed-off-by Manish Chopra <[email protected]>Signed-off-by Sudarsana Kalluru <[email protected]>Signed-off-by Igor Russkikh <[email protected]>--- drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/net/ethernet/qlogic/qede/qede_fp.c +3
-0@@ -1799,6 +1799,11 @@ netdev_features_t qede_features_check(struct sk_buff *skb, ntohs(udp_hdr(skb)->dest) != gnv_port))return features & ~(NETIF_F_CSUM_MASK |NETIF_F_GSO_MASK ); + }else if (l4_proto ==IPPROTO_IPIP ) { +/* IPIP tunnels are unknown to the device or at least unsupported natively, +* offloads for them can't be done trivially, so disable them for such skb.
Quoted 8 lines
drivers/net/ethernet/qlogic/qede/qede_fp.c
Quoted 5 lines
drivers/net/ethernet/qlogic/qede/qede_fp.c +2
-0+*/ + return features & ~(NETIF_F_CSUM_MASK |
NETIF_F_GSO_MASK);drivers/net/ethernet/qlogic/qede/qede_fp.c +0
-0} }Hello Jakub, can you please queue up for stable releases (specifically for long term linux 5.4)?
It's in the queue:
https://patchwork.kernel.org/bundle/netdev/stable/?state=*
I'll submit it later this week.