Skip to contentSkip to conversation

dt-bindings: mfd: mediatek: Add bindings for MT6360 PMIC

PATCH RESEND In review Gene Chen 3 participants 4 messages Dec 24, 2020 – Apr 21, 2022

Subsystems (3)
lore
Share & tools
lore

Gene Chen

author
#0 lore raw

PATCH RESEND 1/1 dt-bindings: mfd: mediatek: Add bindings for MT6360 PMIC

From: Gene Chen <[email protected]>

Add bindings for MT6360 PMIC

---
 Documentation/devicetree/bindings/mfd/mt6360.yaml | 69 +++++++++++++++++++++++
 1 file changed, 69 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/mt6360.yaml
Documentation/devicetree/bindings/mfd/mt6360.yaml new file +69 -0
new file mode 100644
index 0000000..2781c31
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/mt6360.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MT6360 PMIC from MediaTek Integrated
+
+maintainers:
+  - Gene Chen <[email protected]>
+
+description: |
+  MT6360 is a PMIC device with the following sub modules.
+  It is interfaced to host controller using I2C interface.
+
+  This document describes the binding for PMIC device and its sub module.
+
+properties:
+  compatible:
+    const: mediatek,mt6360
+
+  reg:
+    description:
+      I2C device address.
+    maxItems: 1
+
+  wakeup-source: true
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+      enum:
+        - IRQB
+
+  interrupt-controller: true
+
+  "#interrupt-cells":
+    const: 1
+    description:
+      The first cell is the IRQ number.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-controller
+  - "#interrupt-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        mt6360@34 {
+            compatible = "mediatek,mt6360";
+            reg = <0x34>;
+            wakeup-source;
+            interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
+            interrupt-names = "IRQB";
+            interrupt-controller;
+            #interrupt-cells = <1>;
+        };
+    };
Signature · 7 lines
2.7.4


_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
#1 lore raw

Hello Peeps,

Quoted 76 lines · Gene Chen

From: Gene Chen <[email protected]>

Add bindings for MT6360 PMIC

---
 Documentation/devicetree/bindings/mfd/mt6360.yaml | 69
+++++++++++++++++++++++
 1 file changed, 69 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/mt6360.yaml
Documentation/devicetree/bindings/mfd/mt6360.yaml new file +16 -0
new file mode 100644
index 0000000..2781c31
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/mt6360.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MT6360 PMIC from MediaTek Integrated
+
+maintainers:
+  - Gene Chen <[email protected]>
+
+description: |
+  MT6360 is a PMIC device with the following sub modules.
+  It is interfaced to host controller using I2C interface.
+
+  This document describes the binding for PMIC device and its sub

module.

Documentation/devicetree/bindings/mfd/mt6360.yaml new file +41 -0
+
+properties:
+  compatible:
+    const: mediatek,mt6360
+
+  reg:
+    description:
+      I2C device address.
+    maxItems: 1
+
+  wakeup-source: true
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+      enum:
+        - IRQB
+
+  interrupt-controller: true
+
+  "#interrupt-cells":
+    const: 1
+    description:
+      The first cell is the IRQ number.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-controller
+  - "#interrupt-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
+    i2c {
+        #address-cells = <1>;

Documentation/devicetree/bindings/mfd/mt6360.yaml line 67

Quoted 10 lines
Documentation/devicetree/bindings/mfd/mt6360.yaml new file +10 -0
+        #size-cells = <0>;
+
+        mt6360@34 {
+            compatible = "mediatek,mt6360";
+            reg = <0x34>;
+            wakeup-source;
+            interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
+            interrupt-names = "IRQB";
+            interrupt-controller;
+            #interrupt-cells = <1>;

Out of the curiosity - is this the complete node? I would assume some sub-devices like regulators here?

Documentation/devicetree/bindings/mfd/mt6360.yaml line 69

Quoted 2 lines
Documentation/devicetree/bindings/mfd/mt6360.yaml new file +2 -0
+        };
+    };

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

author
#2 lore raw

Vaittinen, Matti <[email protected]> 於 2021年1月11日 週一 下午5:13寫道:

Quoted 85 lines

Hello Peeps,

Quoted 81 lines · Gene Chen

From: Gene Chen <[email protected]>

Add bindings for MT6360 PMIC

---
 Documentation/devicetree/bindings/mfd/mt6360.yaml | 69
+++++++++++++++++++++++
 1 file changed, 69 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/mt6360.yaml
Documentation/devicetree/bindings/mfd/mt6360.yaml new file +16 -0
new file mode 100644
index 0000000..2781c31
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/mt6360.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MT6360 PMIC from MediaTek Integrated
+
+maintainers:
+  - Gene Chen <[email protected]>
+
+description: |
+  MT6360 is a PMIC device with the following sub modules.
+  It is interfaced to host controller using I2C interface.
+
+  This document describes the binding for PMIC device and its sub

module.

Documentation/devicetree/bindings/mfd/mt6360.yaml new file +46 -0
+
+properties:
+  compatible:
+    const: mediatek,mt6360
+
+  reg:
+    description:
+      I2C device address.
+    maxItems: 1
+
+  wakeup-source: true
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+      enum:
+        - IRQB
+
+  interrupt-controller: true
+
+  "#interrupt-cells":
+    const: 1
+    description:
+      The first cell is the IRQ number.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-controller
+  - "#interrupt-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        mt6360@34 {
+            compatible = "mediatek,mt6360";
+            reg = <0x34>;
Quoted 9 lines

Documentation/devicetree/bindings/mfd/mt6360.yaml line 67

Quoted 5 lines
Documentation/devicetree/bindings/mfd/mt6360.yaml new file +5 -0
+            wakeup-source;
+            interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
+            interrupt-names = "IRQB";
+            interrupt-controller;
+            #interrupt-cells = <1>;

Out of the curiosity - is this the complete node? I would assume some sub-devices like regulators here?

After all sub-devices module review done, I will add new patch to add reference description.
e.g. max77650.yaml
leds:
$ref: ../leds/leds-max77650.yaml

Quoted 3 lines

Documentation/devicetree/bindings/mfd/mt6360.yaml line 69

Quoted 2 lines
Documentation/devicetree/bindings/mfd/mt6360.yaml new file +2 -0
+        };
+    };

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

maintainer
#3 lore raw
In reply to Gene Chen
Quoted 9 lines · Gene Chen

From: Gene Chen <[email protected]>

Add bindings for MT6360 PMIC

---
 Documentation/devicetree/bindings/mfd/mt6360.yaml | 69 +++++++++++++++++++++++
 1 file changed, 69 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/mt6360.yaml

Applying this old patch as "mediatek,mt6360" is used, but not documented (causing warnings). Please send a follow-up patch adding the child nodes as promised.

Rob