Skip to contentSkip to conversation

kgdbts: Passing ekgdbts to command line causes panic

PATCH New Defang Bo 1 participant 1 message Dec 28, 2020

Subsystems (2)
lore
Share & tools
lore

Defang Bo

author
#0 lore raw

PATCH 1/1 kgdbts: Passing ekgdbts to command line causes panic

Similar to commit<1bd54d851f50>(("kgdboc: Passing ekgdboc to command line causes panic"), kgdbts_option_setup does not check input argument before passing it to strlen. The argument would be a NULL pointer.

---
 drivers/misc/kgdbts.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/misc/kgdbts.c +5 -0
index 945701b..b077547 100644
@@ -1057,6 +1057,11 @@ static void kgdbts_run_tests(void)
 
 static int kgdbts_option_setup(char *opt)
 {
+	if (!opt) {
+		pr_err("kgdbts: config string not provided\n");
+		return -EINVAL;
+	}
+
 	if (strlen(opt) >= MAX_CONFIG_LEN) {
 		printk(KERN_ERR "kgdbts: config string too long\n");
 		return -ENOSPC;
Signature · 1 line
2.7.4