Skip to contentSkip to conversation

pinctrl: qcom: Fix msm9853 Kconfig entry to depend on, not select PINCTRL_MSM

PATCH Applied John Stultz 3 participants 6 messages Nov 10, 2020 – Dec 29, 2020

Subsystems (5)
Arm Qualcomm mailing list GPIO Pin control Pin controller - Qualcomm +1 more subsystems

v1 of 2 Applied 1/1 Latest is v2 →

lore
Share & tools
lore

John Stultz

author
#0 lore raw

PATCH 1/1 pinctrl: qcom: Fix msm9853 Kconfig entry to depend on, not select PINCTRL_MSM

One fixup following my patch commit be117ca32261 ("pinctrl:
qcom: Kconfig: Rework PINCTRL_MSM to be a depenency rather then a selected config") being queued in LinusW's tree, as a new config entry was added for the msm9853 that also needs the change.

Applies to LinusW's pinctrl devel tree.

Cc Andy Gross <[email protected]>
Cc Prasad Sodagudi <[email protected]>
Cc Vladimir Lypak <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Linus Walleij <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by John Stultz <[email protected]>
---
 drivers/pinctrl/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/qcom/Kconfig +1 -1
index 8bdf878fe970c..cf56e029cd9c7 100644
@@ -115,7 +115,7 @@ config PINCTRL_MSM8916
 config PINCTRL_MSM8953
 	tristate "Qualcomm 8953 pin controller driver"
 	depends on GPIOLIB && OF
-	select PINCTRL_MSM
+	depends on PINCTRL_MSM
 	help
 	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
 	  Qualcomm TLMM block found on the Qualcomm MSM8953 platform.
Signature · 1 line
2.17.1
#1 lore raw
Quoted 26 lines · John Stultz

One fixup following my patch commit be117ca32261 ("pinctrl:
qcom: Kconfig: Rework PINCTRL_MSM to be a depenency rather then a selected config") being queued in LinusW's tree, as a new config entry was added for the msm9853 that also needs the change.

Applies to LinusW's pinctrl devel tree.

Cc Andy Gross <[email protected]>
Cc Prasad Sodagudi <[email protected]>
Cc Vladimir Lypak <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Linus Walleij <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by John Stultz <[email protected]>
---
  drivers/pinctrl/qcom/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/qcom/Kconfig +0 -0
index 8bdf878fe970c..cf56e029cd9c7 100644

drivers/pinctrl/qcom/Kconfig config PINCTRL_MSM8916 · line 121

Quoted 8 lines
drivers/pinctrl/qcom/Kconfig +1 -1
@@ -115,7 +115,7 @@ config PINCTRL_MSM8916
  config PINCTRL_MSM8953
  	tristate "Qualcomm 8953 pin controller driver"
  	depends on GPIOLIB && OF
-	select PINCTRL_MSM
+	depends on PINCTRL_MSM
  	help
  	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
  	  Qualcomm TLMM block found on the Qualcomm MSM8953 platform.

Subject should indicate msm8953, no?

Signature · 3 lines
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
author
#2 lore raw
Quoted 22 lines · Jeffrey Hugo
Quoted 20 lines · John Stultz

One fixup following my patch commit be117ca32261 ("pinctrl:
qcom: Kconfig: Rework PINCTRL_MSM to be a depenency rather then a selected config") being queued in LinusW's tree, as a new config entry was added for the msm9853 that also needs the change.

Applies to LinusW's pinctrl devel tree.

Cc Andy Gross <[email protected]>
Cc Prasad Sodagudi <[email protected]>
Cc Vladimir Lypak <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Linus Walleij <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by John Stultz <[email protected]>
---
  drivers/pinctrl/qcom/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines
Quoted 6 lines
drivers/pinctrl/qcom/Kconfig +0 -0
index 8bdf878fe970c..cf56e029cd9c7 100644

drivers/pinctrl/qcom/Kconfig config PINCTRL_MSM8916 · line 121

Quoted 8 lines
drivers/pinctrl/qcom/Kconfig +1 -1
@@ -115,7 +115,7 @@ config PINCTRL_MSM8916
  config PINCTRL_MSM8953
      tristate "Qualcomm 8953 pin controller driver"
      depends on GPIOLIB && OF
-     select PINCTRL_MSM
+     depends on PINCTRL_MSM
      help
        This is the pinctrl, pinmux, pinconf and gpiolib driver for the
        Qualcomm TLMM block found on the Qualcomm MSM8953 platform.

Subject should indicate msm8953, no?

Sorry, I'm confused. :)
The subject is "pinctrl: qcom: Fix msm9853 Kconfig..." is there something more specific you are suggesting?

thanks
-john

#3 lore raw
Quoted 41 lines · John Stultz
Quoted 22 lines · Jeffrey Hugo
Quoted 20 lines · John Stultz

One fixup following my patch commit be117ca32261 ("pinctrl:
qcom: Kconfig: Rework PINCTRL_MSM to be a depenency rather then a selected config") being queued in LinusW's tree, as a new config entry was added for the msm9853 that also needs the change.

Applies to LinusW's pinctrl devel tree.

Cc Andy Gross <[email protected]>
Cc Prasad Sodagudi <[email protected]>
Cc Vladimir Lypak <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Linus Walleij <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by John Stultz <[email protected]>
---
   drivers/pinctrl/qcom/Kconfig | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines
Quoted 6 lines
drivers/pinctrl/qcom/Kconfig +0 -0
index 8bdf878fe970c..cf56e029cd9c7 100644

drivers/pinctrl/qcom/Kconfig config PINCTRL_MSM8916 · line 121

Quoted 8 lines
drivers/pinctrl/qcom/Kconfig +1 -1
@@ -115,7 +115,7 @@ config PINCTRL_MSM8916
   config PINCTRL_MSM8953
       tristate "Qualcomm 8953 pin controller driver"
       depends on GPIOLIB && OF
-     select PINCTRL_MSM
+     depends on PINCTRL_MSM
       help
         This is the pinctrl, pinmux, pinconf and gpiolib driver for the
         Qualcomm TLMM block found on the Qualcomm MSM8953 platform.

Subject should indicate msm8953, no?

Quoted 3 lines

Sorry, I'm confused. :)
The subject is "pinctrl: qcom: Fix msm9853 Kconfig..." is there something more specific you are suggesting?

Yes, that is the current subject. Yet you are changing a Kconfig for msm8953.

msm9853 != msm8953

Infact I'm not sure msm9853 is something that actually exists....

Signature · 3 lines
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
author
#4 lore raw
Quoted 47 lines · Jeffrey Hugo
Quoted 41 lines · John Stultz
Quoted 22 lines · Jeffrey Hugo
Quoted 20 lines · John Stultz

One fixup following my patch commit be117ca32261 ("pinctrl:
qcom: Kconfig: Rework PINCTRL_MSM to be a depenency rather then a selected config") being queued in LinusW's tree, as a new config entry was added for the msm9853 that also needs the change.

Applies to LinusW's pinctrl devel tree.

Cc Andy Gross <[email protected]>
Cc Prasad Sodagudi <[email protected]>
Cc Vladimir Lypak <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Linus Walleij <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by John Stultz <[email protected]>
---
   drivers/pinctrl/qcom/Kconfig | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines
Quoted 6 lines
drivers/pinctrl/qcom/Kconfig +0 -0
index 8bdf878fe970c..cf56e029cd9c7 100644

drivers/pinctrl/qcom/Kconfig config PINCTRL_MSM8916 · line 121

Quoted 8 lines
drivers/pinctrl/qcom/Kconfig +1 -1
@@ -115,7 +115,7 @@ config PINCTRL_MSM8916
   config PINCTRL_MSM8953
       tristate "Qualcomm 8953 pin controller driver"
       depends on GPIOLIB && OF
-     select PINCTRL_MSM
+     depends on PINCTRL_MSM
       help
         This is the pinctrl, pinmux, pinconf and gpiolib driver for the
         Qualcomm TLMM block found on the Qualcomm MSM8953 platform.

Subject should indicate msm8953, no?

Quoted 3 lines

Sorry, I'm confused. :)
The subject is "pinctrl: qcom: Fix msm9853 Kconfig..." is there something more specific you are suggesting?

Quoted 6 lines

Yes, that is the current subject. Yet you are changing a Kconfig for msm8953.

msm9853 != msm8953

Infact I'm not sure msm9853 is something that actually exists....

Ah! Apologies! My brain flipped it reading it each time. Will fix that up.

thanks
-john

CI Applied
#5 lore raw
In reply to John Stultz
This patch was applied to qcom/linux.git (refs/heads/for-next):

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

Quoted 9 lines · On Tue, 10 Nov 2020 19:00:54 +0000 you wrote:

One fixup following my patch commit be117ca32261 ("pinctrl:
qcom: Kconfig: Rework PINCTRL_MSM to be a depenency rather then a selected config") being queued in LinusW's tree, as a new config entry was added for the msm9853 that also needs the change.

Applies to LinusW's pinctrl devel tree.

[...]

Here is the summary with links:
- pinctrl: qcom: Fix msm9853 Kconfig entry to depend on, not select PINCTRL_MSM

    https://git.kernel.org/qcom/c/2a984219b534

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html