spi: spi-geni-qcom: Use the new method of gpio CS control
Subsystems (2)
PATCH 1/1 spi: spi-geni-qcom: Use the new method of gpio CS control
Let's set the 'use_gpio_descriptors' field so that we use the new way of requesting the CS GPIOs in the core. This allows us to avoid having to configure the CS pins in "output" mode with an 'output-enable' pinctrl setting.
--- drivers/spi/spi-geni-qcom.c | 1 + 1 file changed, 1 insertion(+)
drivers/spi/spi-geni-qcom.c +1 -0
@@ -636,6 +636,7 @@ static int spi_geni_probe(struct platform_device *pdev) spi->auto_runtime_pm = true; spi->handle_err = handle_fifo_timeout; spi->set_cs = spi_geni_set_cs; + spi->use_gpio_descriptors = true;init_completion (&mas->cs_done);init_completion (&mas->cancel_done);
base-commit: b65054597872ce3aefbc6a666385eabdf9e288da
Signature · 1 line
https://chromeos.dev
Quoted 10 lines · Stephen Boyd
Let's set the '
use_gpio_descriptors' field so that we use the new way of requesting the CS GPIOs in the core. This allows us to avoid having to configure the CS pins in "output" mode with an 'output-enable' pinctrl setting.Cc Akash Asthana <[email protected]>Cc Bjorn Andersson <[email protected]>Reviewed-by Douglas Anderson <[email protected]>Acked-by Alexandru M Stan <[email protected]>
I meant this as a joke in chat. It doesn't really mean anything in any capacity.
Quoted 18 lines
Signed-off-by Stephen Boyd <[email protected]>--- drivers/spi/spi-geni-qcom.c | 1 + 1 file changed, 1 insertion(+)drivers/spi/spi-geni-qcom.c +1
-0@@ -636,6 +636,7 @@ static int spi_geni_probe(struct platform_device *pdev) spi->auto_runtime_pm = true; spi->handle_err = handle_fifo_timeout; spi->set_cs = spi_geni_set_cs; + spi->use_gpio_descriptors = true;init_completion (&mas->cs_done);init_completion (&mas->cancel_done);
Quoted 4 lines
base-commit:
b65054597872ce3aefbc6a666385eabdf9e288da--
https://chromeos.dev
Unfortunately this patch makes my cros-ec (the main EC that used to work even before my debugging) also fail to probe:
[ 0.839533] cros-ec-spi spi6.0: EC failed to respond in time [ 1.040453] cros-ec-spi spi6.0: EC failed to respond in time [ 1.040852] cros-ec-spi spi6.0: Cannot identify the EC: error -110 [ 1.040855] cros-ec-spi spi6.0: cannot register EC, fallback to spidev [ 1.040942] cros-ec-spi: probe of spi6.0 failed with error -110
I wasn't closely looking at this part closely when I was using my other spi port with spidev, so this is why I haven't noticed it before.
Doug suggests this might be a polarity issue. More scoping to be had.
On the other hand my gpioinfo output is better with this patch:
line 86: "AP_SPI_FP_MISO" unused input active-high
line 87: "AP_SPI_FP_MOSI" unused input active-high
line 88: "AP_SPI_FP_CLK" unused input active-high
line 89: "AP_SPI_FP_CS_L" "spi10 CS0" output active-low [used]Previously they were:
line 86: "AP_SPI_FP_MISO" unused input active-high
line 87: "AP_SPI_FP_MOSI" unused input active-high
line 88: "AP_SPI_FP_CLK" unused input active-high
line 89: "AP_SPI_FP_CS_L" unused output active-highBut I'm still disappointed the rest of the pins (CLK MISO MOSI) are still "unused", but I was told that's just an artifact of those pins not being gpios (but remuxed to spi).
Alexandru Stan (amstan)
Quoting Alexandru M Stan (2020-12-02 14:18:20)
Quoted 7 lines · Stephen Boyd
Quoted 6 lines
Let's set the '
use_gpio_descriptors' field so that we use the new way of requesting the CS GPIOs in the core. This allows us to avoid having to configure the CS pins in "output" mode with an 'output-enable' pinctrl setting.
Quoted 5 lines
Quoted 4 lines
Cc Akash Asthana <[email protected]>Cc Bjorn Andersson <[email protected]>Reviewed-by Douglas Anderson <[email protected]>Acked-by Alexandru M Stan <[email protected]>I meant this as a joke in chat. It doesn't really mean anything in any capacity.
Sorry! It can be removed when applying.
Quoted 32 lines
Quoted 19 lines
Signed-off-by Stephen Boyd <[email protected]>--- drivers/spi/spi-geni-qcom.c | 1 + 1 file changed, 1 insertion(+)drivers/spi/spi-geni-qcom.c +1
-0@@ -636,6 +636,7 @@ static int spi_geni_probe(struct platform_device *pdev) spi->auto_runtime_pm = true; spi->handle_err = handle_fifo_timeout; spi->set_cs = spi_geni_set_cs; + spi->use_gpio_descriptors = true;init_completion (&mas->cs_done);init_completion (&mas->cancel_done);Quoted 4 lines
base-commit:
b65054597872ce3aefbc6a666385eabdf9e288da--
https://chromeos.devUnfortunately this patch makes my cros-ec (the main EC that used to work even before my debugging) also fail to probe:
[ 0.839533] cros-ec-spi spi6.0: EC failed to respond in time [ 1.040453] cros-ec-spi spi6.0: EC failed to respond in time [ 1.040852] cros-ec-spi spi6.0: Cannot identify the EC: error -110 [ 1.040855] cros-ec-spi spi6.0: cannot register EC, fallback to spidev [ 1.040942] cros-ec-spi: probe of spi6.0 failed with error -110
Quoted 5 lines
I wasn't closely looking at this part closely when I was using my other spi port with spidev, so this is why I haven't noticed it before.
Doug suggests this might be a polarity issue. More scoping to be had.
Ah I see. It looks like the cs-gpios polarity is wrong for the DTS on sc7180. That's a patch that Doug has sent in for the qcom tree, commit 37dd4b777942 ("arm64: dts: qcom: sc7180: Provide pinconf for SPI to use GPIO for CS") and it is pending for the next release (v5.11). Doug says he will send in a fix for the DTS side, but this patch is still "good" as far as I can tell. It moves us to use gpio descriptors and also finds bugs like this in the DTS file that we would have missed otherwise because the legacy mode doesn't look at the polarity flags in DT.
Quoting Stephen Boyd (2020-12-02 15:28:45)
Quoted 15 lines
Quoting Alexandru M Stan (2020-12-02 14:18:20)
Quoted 8 lines
Unfortunately this patch makes my cros-ec (the main EC that used to work even before my debugging) also fail to probe:
[ 0.839533] cros-ec-spi spi6.0: EC failed to respond in time [ 1.040453] cros-ec-spi spi6.0: EC failed to respond in time [ 1.040852] cros-ec-spi spi6.0: Cannot identify the EC: error -110 [ 1.040855] cros-ec-spi spi6.0: cannot register EC, fallback to spidev [ 1.040942] cros-ec-spi: probe of spi6.0 failed with error -110Quoted 5 lines
I wasn't closely looking at this part closely when I was using my other spi port with spidev, so this is why I haven't noticed it before.
Doug suggests this might be a polarity issue. More scoping to be had.
Quoted 8 lines
Ah I see. It looks like the cs-gpios polarity is wrong for the DTS on sc7180. That's a patch that Doug has sent in for the qcom tree, commit
37dd4b777942("arm64: dts: qcom: sc7180: Provide pinconf for SPI to use GPIO for CS") and it is pending for the next release (v5.11). Doug says he will send in a fix for the DTS side, but this patch is still "good" as far as I can tell. It moves us to use gpio descriptors and also finds bugs like this in the DTS file that we would have missed otherwise because the legacy mode doesn't look at the polarity flags in DT.
And that is wrong. With even more investigation and Doug's eagle eyes it seems that the cros-ec driver is overriding the spi::mode to clear out the SPI_CS_HIGH bit that the spi core sets in there when using the gpio descriptors. I'll send a patch for cros-ec-spi shortly.
Hi,
Quoted 26 lines · Stephen Boyd
Quoting Stephen Boyd (2020-12-02 15:28:45)
Quoted 15 lines
Quoting Alexandru M Stan (2020-12-02 14:18:20)
Quoted 8 lines
Unfortunately this patch makes my cros-ec (the main EC that used to work even before my debugging) also fail to probe:
[ 0.839533] cros-ec-spi spi6.0: EC failed to respond in time [ 1.040453] cros-ec-spi spi6.0: EC failed to respond in time [ 1.040852] cros-ec-spi spi6.0: Cannot identify the EC: error -110 [ 1.040855] cros-ec-spi spi6.0: cannot register EC, fallback to spidev [ 1.040942] cros-ec-spi: probe of spi6.0 failed with error -110Quoted 5 lines
I wasn't closely looking at this part closely when I was using my other spi port with spidev, so this is why I haven't noticed it before.
Doug suggests this might be a polarity issue. More scoping to be had.Quoted 8 lines
Ah I see. It looks like the cs-gpios polarity is wrong for the DTS on sc7180. That's a patch that Doug has sent in for the qcom tree, commit
37dd4b777942("arm64: dts: qcom: sc7180: Provide pinconf for SPI to use GPIO for CS") and it is pending for the next release (v5.11). Doug says he will send in a fix for the DTS side, but this patch is still "good" as far as I can tell. It moves us to use gpio descriptors and also finds bugs like this in the DTS file that we would have missed otherwise because the legacy mode doesn't look at the polarity flags in DT.
Quoted 4 lines
And that is wrong. With even more investigation and Doug's eagle eyes it seems that the cros-ec driver is overriding the
spi::modeto clear out theSPI_CS_HIGHbit that the spi core sets in there when using the gpio descriptors. I'll send a patch for cros-ec-spi shortly.
So do we need any coordinating here, are we OK w/ trogdor devices being broken for a short period of time?
I think the device tree changes switching to use GPIO for chip select is already queued in linux-next. That means if we land this patch before the fix to cros_ec [1] then we'll end up in a broken state. Would we be able to do some quick landing to get the cros-ec fix into v5.10 and then target the SPI patch for 5.11?
-Doug
Quoting Doug Anderson (2020-12-03 12:06:10)
Quoted 7 lines · Stephen Boyd
Quoted 5 lines
And that is wrong. With even more investigation and Doug's eagle eyes it seems that the cros-ec driver is overriding the
spi::modeto clear out theSPI_CS_HIGHbit that the spi core sets in there when using the gpio descriptors. I'll send a patch for cros-ec-spi shortly.
Quoted 8 lines
So do we need any coordinating here, are we OK w/ trogdor devices being broken for a short period of time?
I think the device tree changes switching to use GPIO for chip select is already queued in linux-next. That means if we land this patch before the fix to
cros_ec[1] then we'll end up in a broken state. Would we be able to do some quick landing to get the cros-ec fix into v5.10 and then target the SPI patch for 5.11?
I don't think it really matters if the two patches meet up in linux-next or cros-ec is fast tracked, but it would be bad if this patch was merged without the cros-ec one. One option would be to apply the cros-ec fix to the spi tree along with this patch (or vice versa) so that a bisection hole isn't created. Or this patch can wait for a while until cros-ec is fixed. I'm not the maintainer here so it's really up to Mark and Enric/Benson.
Quoted 2 lines
Hi,
Quoted 17 lines · Stephen Boyd
Quoting Doug Anderson (2020-12-03 12:06:10)
Quoted 7 lines · Stephen Boyd
Quoted 5 lines
And that is wrong. With even more investigation and Doug's eagle eyes it seems that the cros-ec driver is overriding the
spi::modeto clear out theSPI_CS_HIGHbit that the spi core sets in there when using the gpio descriptors. I'll send a patch for cros-ec-spi shortly.Quoted 8 lines
So do we need any coordinating here, are we OK w/ trogdor devices being broken for a short period of time?
I think the device tree changes switching to use GPIO for chip select is already queued in linux-next. That means if we land this patch before the fix to
cros_ec[1] then we'll end up in a broken state. Would we be able to do some quick landing to get the cros-ec fix into v5.10 and then target the SPI patch for 5.11?
Quoted 8 lines
I don't think it really matters if the two patches meet up in linux-next or cros-ec is fast tracked, but it would be bad if this patch was merged without the cros-ec one. One option would be to apply the cros-ec fix to the spi tree along with this patch (or vice versa) so that a bisection hole isn't created. Or this patch can wait for a while until cros-ec is fixed. I'm not the maintainer here so it's really up to Mark and Enric/Benson.
I am fine either way. I'm fine with pick all the patches and go through the chrome/platform tree if Mark is agree (I think this patch has no other dependencies and the patch applies cleanly to my tree) or all can go through the Mark's tree. If I need to an IB I can also do it without problems.
I'll leave Mark to decide who has much experience solving this kind of problems.
Thanks,
Enric
Quoted 2 lines
Quoted 2 lines
Mark Brown
maintainerQuoted 6 lines · Enric Balletbo i Serra
I am fine either way. I'm fine with pick all the patches and go through the chrome/platform tree if Mark is agree (I think this patch has no other dependencies and the patch applies cleanly to my tree) or all can go through the Mark's tree. If I need to an IB I can also do it without problems.
I'll leave Mark to decide who has much experience solving this kind of problems.
I'm happy to take both patches, there are some others in this area in the SPI tree so it might minimise bisection problems if I take them but not sure if there's any actual overlap there. If someone could resend them as a series?
This patch was applied to qcom/linux.git (refs/heads/for-next):
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
Quoted 5 lines · On Wed, 2 Dec 2020 13:49:35 -0800 you wrote:
Let's set the '
use_gpio_descriptors' field so that we use the new way of requesting the CS GPIOs in the core. This allows us to avoid having to configure the CS pins in "output" mode with an 'output-enable' pinctrl setting.
Quoted 7 lines
Cc Akash Asthana <[email protected]>Cc Bjorn Andersson <[email protected]>Reviewed-by Douglas Anderson <[email protected]>Acked-by Alexandru M Stan <[email protected]>Signed-off-by Stephen Boyd <[email protected]>[...]
Here is the summary with links:
- spi: spi-geni-qcom: Use the new method of gpio CS control
https://git.kernel.org/qcom/c/3b25f337929e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html