Skip to contentSkip to conversation

mlx4: style: replace zero-length array with flexible-array member.

PATCH In review YANG LI 4 participants 4 messages Dec 30, 2020 – Jan 4, 2021

Subsystems (5)
lore
Share & tools
lore

YANG LI

author
#0 lore raw

PATCH 1/1 mlx4: style: replace zero-length array with flexible-array member.

There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use "flexible array members"[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9/process/
deprecated.html#zero-length-and-one-element-arrays

---
 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h +1 -1
index e8ed2319..4029a8b 100644
@@ -314,7 +314,7 @@ struct mlx4_en_tx_ring {
 
 struct mlx4_en_rx_desc {
 	/* actual number of entries depends on rx ring stride */
-	struct mlx4_wqe_data_seg data[0];
+	struct mlx4_wqe_data_seg data[];
 };
 
 struct mlx4_en_rx_ring {
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 22 lines · YANG LI

There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use "flexible array members"[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9/process/
deprecated.html#zero-length-and-one-element-arrays

---
  drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h +0 -0
index e8ed2319..4029a8b 100644

drivers/net/ethernet/mellanox/mlx4/mlx4_en.h struct mlx4_en_tx_ring { · line 320

Quoted 8 lines
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h +1 -1
@@ -314,7 +314,7 @@ struct mlx4_en_tx_ring {
 
  struct mlx4_en_rx_desc {
  	/* actual number of entries depends on rx ring stride */
-	struct mlx4_wqe_data_seg data[0];
+	struct mlx4_wqe_data_seg data[];
  };
 
  struct mlx4_en_rx_ring {

Thanks.

#2 lore raw
In reply to YANG LI
Thank you for the patch! Yet something to improve:

Hi YANG,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ipvs/master]
[also build test ERROR on linus/master sparc-next/master v5.11-rc1 next-20201223] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/YANG-LI/mlx4-style-replace-zero-length-array-with-flexible-array-member/20201230-143531
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9ba529666d9d11ec16093f038c0d325ebad98b01
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review YANG-LI/mlx4-style-replace-zero-length-array-with-flexible-array-member/20201230-143531 git checkout 9ba529666d9d11ec16093f038c0d325ebad98b01
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

In file included from drivers/net/ethernet/mellanox/mlx4/en_main.c:44:

>> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:316:27: error: flexible array member in a struct with no named members
     316 |  struct mlx4_wqe_data_seg data[];
         |                           ^~~~

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for FRAME_POINTER
Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
Selected by
- FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86

vim +316 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h

313
314 struct mlx4_en_rx_desc {
315 /* actual number of entries depends on rx ring stride */

 > 316		struct mlx4_wqe_data_seg data[];

317 };
318

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

maintainer
#3 lore raw
In reply to YANG LI
Quoted 6 lines · On Wed, 30 Dec 2020 14:28:51 +0800 YANG LI wrote:

There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use "flexible array members"[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].

Quoted 6 lines

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9/process/
deprecated.html#zero-length-and-one-element-arrays

This breaks the build with allmodconfig, could you double check? Are there dependencies?

In file included from drivers/net/ethernet/mellanox/mlx4/en_netdev.c:50:
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:316:27: error: flexible array member in a struct with no named members
316 | struct mlx4_wqe_data_seg data[];
| ^~~~