Skip to contentSkip to conversation

cifs: style: replace one-element array with flexible-array

PATCH Applied YANG LI 2 participants 2 messages Dec 30, 2020 – Dec 31, 2020

Subsystems (2)
lore
Share & tools
lore

YANG LI

author
#0 lore raw

PATCH 1/1 cifs: style: replace one-element array with flexible-array

There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use "flexible array members"[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9/process/
deprecated.html#zero-length-and-one-element-arrays

---
 fs/cifs/smb2pdu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/smb2pdu.h +1 -1
index 204a622..d85edf5 100644
@@ -424,7 +424,7 @@ struct smb2_rdma_transform_capabilities_context {
 	__le16	TransformCount;
 	__u16	Reserved1;
 	__u32	Reserved2;
-	__le16	RDMATransformIds[1];
+	__le16	RDMATransformIds[];
 } __packed;
 
 /* Signing algorithms */
Signature · 1 line
1.8.3.1
Applied
#1 lore raw

merged into cifs-2.6.git for-next

Quoted 33 lines · YANG LI

There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use "flexible array members"[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9/process/
deprecated.html#zero-length-and-one-element-arrays

---
 fs/cifs/smb2pdu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/smb2pdu.h +1 -2
index 204a622..d85edf5 100644
@@ -424,7 +424,7 @@ struct smb2_rdma_transform_capabilities_context {
        __le16  TransformCount;
        __u16   Reserved1;
        __u32   Reserved2;
-       __le16  RDMATransformIds[1];
+       __le16  RDMATransformIds[];
 } __packed;
 
 /* Signing algorithms */
--

1.8.3.1

Signature · 3 lines
Thanks,

Steve