liquidio: fix: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'.
Subsystems (3)
PATCH 1/1 liquidio: fix: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'.
For safety, modify '%u' to '%d' to keep the type consistent.
Signed-off-by YANG LI <[email protected]>
Reported-by Abaci <[email protected]>
--- drivers/net/ethernet/cavium/liquidio/lio_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/cavium/liquidio/lio_core.c +2 -2
@@ -1109,12 +1109,12 @@ int octeon_setup_interrupt(struct octeon_device *oct, u32 num_ioqs)for (i =0 ; i < num_ioq_vectors ; i++) {if (OCTEON_CN23XX_PF (oct))snprintf (&queue_irq_names[IRQ_NAME_OFF (i)], -INTRNAMSIZ ,"LiquidIO%u-pf%u-rxtx-%u" , +INTRNAMSIZ ,"LiquidIO%u-pf%u-rxtx-%d" , oct->octeon_id, oct->pf_num, i);if (OCTEON_CN23XX_VF (oct))snprintf (&queue_irq_names[IRQ_NAME_OFF (i)], -INTRNAMSIZ ,"LiquidIO%u-vf%u-rxtx-%u" , +INTRNAMSIZ ,"LiquidIO%u-vf%u-rxtx-%d" , oct->octeon_id, oct->vf_num, i); irqret = request_irq(msix_entries[i].vector,
Signature · 1 line
1.8.3.1
Quoted 1 line · YANG LI
For safety, modify '%u' to '%d' to keep the type consistent.
There is no additional safety here.
The for loop ensures that i is positive as num_ioq_vector is also int and so i can not be negative as it's incremented from 0.
drivers/net/ethernet/cavium/liquidio/lio_core.c
Quoted 1 line
drivers/net/ethernet/cavium/liquidio/lio_core.c +0
-0
[]
Quoted 17 lines
drivers/net/ethernet/cavium/liquidio/lio_core.c +1
-1@@ -1109,12 +1109,12 @@ int octeon_setup_interrupt(struct octeon_device *oct, u32 num_ioqs) for (i = 0 ; i < num_ioq_vectors ; i++) { if (OCTEON_CN23XX_PF(oct)) snprintf(&queue_irq_names[IRQ_NAME_OFF(i)], -INTRNAMSIZ ,"LiquidIO%u-pf%u-rxtx-%u" , +INTRNAMSIZ ,"LiquidIO%u-pf%u-rxtx-%d" , oct->octeon_id, oct->pf_num, i);if (
OCTEON_CN23XX_VF(oct)) snprintf(&queue_irq_names[IRQ_NAME_OFF(i)],drivers/net/ethernet/cavium/liquidio/lio_core.c +1
-1- INTRNAMSIZ, "LiquidIO%u-vf%u-rxtx-%u", + INTRNAMSIZ, "LiquidIO%u-vf%u-rxtx-%d",
oct->octeon_id,oct->vf_num, i);irqret = request_irq(msix_entries[i].vector,