Skip to contentSkip to conversation

soc: qcom: smem: use %*ph to print small buffer

PATCH Applied Andy Shevchenko 3 participants 4 messages Jul 30, 2020 – Jan 4, 2021 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: qcom: smem: use %*ph to print small buffer

Use %*ph format to print small buffer as hex string.

---
 drivers/soc/qcom/smem.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/qcom/smem.c +1 -3
index 28c19bcb2f20..8e66003f3e81 100644
@@ -731,9 +731,7 @@ qcom_smem_partition_header(struct qcom_smem *smem,
 	header = smem->regions[0].virt_base + le32_to_cpu(entry->offset);
 
 	if (memcmp(header->magic, SMEM_PART_MAGIC, sizeof(header->magic))) {
-		dev_err(smem->dev, "bad partition magic %02x %02x %02x %02x\n",
-			header->magic[0], header->magic[1],
-			header->magic[2], header->magic[3]);
+		dev_err(smem->dev, "bad partition magic %4ph\n", header->magic);
 		return NULL;
 	}
 
Signature · 1 line
2.27.0

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko

Use %*ph format to print small buffer as hex string.

Any comments?

Anybody alive here?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 8 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko

Use %*ph format to print small buffer as hex string.

Any comments?

Anybody alive here?

I have no idea why I've been missing this...twice, sorry about that and thanks for the ping! I've picked it up for v5.12 now.

Regards,
Bjorn

Quoted 5 lines
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
In reply to Andy Shevchenko
This patch was applied to qcom/linux.git (refs/heads/for-next):

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

Quoted 6 lines · On Thu, 30 Jul 2020 18:32:20 +0300 you wrote:

Use %*ph format to print small buffer as hex string.

---
 drivers/soc/qcom/smem.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Here is the summary with links:
- [v1] soc: qcom: smem: use %*ph to print small buffer

    https://git.kernel.org/qcom/c/1b3df368914b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html