r8169: work around power-saving bug on some chip versions
Heiner Kallweit
maintainerPATCH 1/1 r8169: work around power-saving bug on some chip versions
A user reported failing network with RTL8168dp (a quite rare chip version). Realtek confirmed that few chip versions suffer from a PLL power-down hw bug.
---
Note that since the original change source file r8169.c was renamed to r8169_main.c. Also the name of the affected functions has changed from r8168_pll_power_down/up to rtl_pll_power_down/up.
--- drivers/net/ethernet/realtek/r8169_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/ethernet/realtek/r8169_main.c +4 -2
@@ -2207,7 +2207,8 @@ static void rtl_pll_power_down(struct rtl8169_private *tp) }switch (tp->mac_version) { - case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_33: + case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_26: + case RTL_GIGA_MAC_VER_32 ... RTL_GIGA_MAC_VER_33:case RTL_GIGA_MAC_VER_37 :case RTL_GIGA_MAC_VER_39 :case RTL_GIGA_MAC_VER_43 :
@@ -2233,7 +2234,8 @@ static void rtl_pll_power_down(struct rtl8169_private *tp)static void rtl_pll_power_up (struct rtl8169_private *tp) {switch (tp->mac_version) { - case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_33: + case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_26: + case RTL_GIGA_MAC_VER_32 ... RTL_GIGA_MAC_VER_33:case RTL_GIGA_MAC_VER_37 :case RTL_GIGA_MAC_VER_39 :case RTL_GIGA_MAC_VER_43 :
Signature · 1 line
2.29.2
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 8 lines · On Wed, 30 Dec 2020 19:33:34 +0100 you wrote:
A user reported failing network with RTL8168dp (a quite rare chip version). Realtek confirmed that few chip versions suffer from a PLL power-down hw bug.
Fixes 07df5bd874f0 ("r8169: power down chip in probe")Signed-off-by Heiner Kallweit <[email protected]>[...]
Here is the summary with links:
- [net] r8169: work around power-saving bug on some chip versions
https://git.kernel.org/netdev/net/c/e80bd76fbf56
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html