drm/amdgpu: Add check to prevenet IH overflow
Subsystems (2)
PATCH v2 1/1 drm/amdgpu: Add check to prevenet IH overflow
Similar to commit <b82175750131>("drm/amdgpu: fix IH overflow on Vega10 v2"). When an ring buffer overflow happens the appropriate bit is set in the WPTR register which is also written back to memory. But clearing the bit in the WPTR doesn't trigger another memory writeback.
So what can happen is that we end up processing the buffer overflow over and over again because the bit is never cleared. Resulting in a random system lockup because of an infinite loop in an interrupt handler.
---
Changes since v1:
- Modify the subject and replace the wrong register.
---
--- drivers/gpu/drm/amd/amdgpu/cz_ih.c | 39 +++++++++++++++++++++------------ drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 36 +++++++++++++++++++----------- drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 37 ++++++++++++++++++++----------- 3 files changed, 72 insertions(+), 40 deletions(-)
drivers/gpu/drm/amd/amdgpu/cz_ih.c +25 -14
@@ -190,22 +190,33 @@ static u32 cz_ih_get_wptr(struct amdgpu_device *adev, struct amdgpu_ih_ring *ih) {u32 wptr, tmp; - + wptr =le32_to_cpu (*ih->wptr_cpu); -if (REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) { - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); -/* When a ring buffer overflow happen start parsing interrupt -* from the last not overwritten vector (wptr + 16). Hopefully -* this should allow us to catchup. -*/ -dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , - wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); - ih->rptr = (wptr +16 ) & ih->ptr_mask; - tmp =RREG32 (mmIH_RB_CNTL); - tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); -WREG32 (mmIH_RB_CNTL, tmp); - } +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + +/* Double check that the overflow wasn't already cleared. */ + wptr =RREG32 (mmIH_RB_WPTR); + +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); + +/* When a ring buffer overflow happen start parsing interrupt +* from the last not overwritten vector (wptr + 16). Hopefully +* this should allow us to catchup. +*/ +dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , + wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); + ih->rptr = (wptr +16 ) & ih->ptr_mask; + tmp =RREG32 (mmIH_RB_CNTL); + tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); +WREG32 (mmIH_RB_CNTL, tmp); + + +out:return (wptr & ih->ptr_mask); }
drivers/gpu/drm/amd/amdgpu/iceland_ih.c +23 -13
@@ -193,19 +193,29 @@ static u32 iceland_ih_get_wptr(struct amdgpu_device *adev, wptr =le32_to_cpu (*ih->wptr_cpu); -if (REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) { - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); -/* When a ring buffer overflow happen start parsing interrupt -* from the last not overwritten vector (wptr + 16). Hopefully -* this should allow us to catchup. -*/ -dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , - wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); - ih->rptr = (wptr +16 ) & ih->ptr_mask; - tmp =RREG32 (mmIH_RB_CNTL); - tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); -WREG32 (mmIH_RB_CNTL, tmp); - } +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + +/* Double check that the overflow wasn't already cleared. */ + wptr =RREG32 (mmIH_RB_WPTR); + +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +/* When a ring buffer overflow happen start parsing interrupt +* from the last not overwritten vector (wptr + 16). Hopefully +* this should allow us to catchup. +*/ +dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , + wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); + ih->rptr = (wptr +16 ) & ih->ptr_mask; + tmp =RREG32 (mmIH_RB_CNTL); + tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); +WREG32 (mmIH_RB_CNTL, tmp); + + +out:return (wptr & ih->ptr_mask); }
drivers/gpu/drm/amd/amdgpu/tonga_ih.c +24 -13
@@ -195,19 +195,30 @@ static u32 tonga_ih_get_wptr(struct amdgpu_device *adev, wptr =le32_to_cpu (*ih->wptr_cpu); -if (REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) { - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); -/* When a ring buffer overflow happen start parsing interrupt -* from the last not overwritten vector (wptr + 16). Hopefully -* this should allow us to catchup. -*/ -dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , - wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); - ih->rptr = (wptr +16 ) & ih->ptr_mask; - tmp =RREG32 (mmIH_RB_CNTL); - tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); -WREG32 (mmIH_RB_CNTL, tmp); - } +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + +/* Double check that the overflow wasn't already cleared. */ + wptr =RREG32 (mmIH_RB_WPTR); + +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); + +/* When a ring buffer overflow happen start parsing interrupt +* from the last not overwritten vector (wptr + 16). Hopefully +* this should allow us to catchup. +*/ + +dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , + wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); + ih->rptr = (wptr +16 ) & ih->ptr_mask; + tmp =RREG32 (mmIH_RB_CNTL); + tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); +WREG32 (mmIH_RB_CNTL, tmp); + +out:return (wptr & ih->ptr_mask); }
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Am 05.01.21 um 17:06 schrieb Defang Bo:
Quoted 10 lines
Similar to commit <b82175750131>("drm/amdgpu: fix IH overflow on Vega10 v2"). When an ring buffer overflow happens the appropriate bit is set in the WPTR register which is also written back to memory. But clearing the bit in the WPTR doesn't trigger another memory writeback.
So what can happen is that we end up processing the buffer overflow over and over again because the bit is never cleared. Resulting in a random system lockup because of an infinite loop in an interrupt handler.
Signed-off-by Defang Bo <[email protected]>
Thanks for the help,
Christian.
Quoted 147 lines
---
Changes since v1:
- Modify the subject and replace the wrong register.
------ drivers/gpu/drm/amd/amdgpu/cz_ih.c | 39 +++++++++++++++++++++------------ drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 36 +++++++++++++++++++----------- drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 37 ++++++++++++++++++++----------- 3 files changed, 72 insertions(+), 40 deletions(-)drivers/gpu/drm/amd/amdgpu/cz_ih.c +25
-14@@ -190,22 +190,33 @@ static u32 cz_ih_get_wptr(struct amdgpu_device *adev, struct amdgpu_ih_ring *ih) {u32 wptr, tmp; - + wptr =le32_to_cpu (*ih->wptr_cpu); -if (REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) { - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); -/* When a ring buffer overflow happen start parsing interrupt -* from the last not overwritten vector (wptr + 16). Hopefully -* this should allow us to catchup. -*/ -dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , - wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); - ih->rptr = (wptr +16 ) & ih->ptr_mask; - tmp =RREG32 (mmIH_RB_CNTL); - tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); -WREG32 (mmIH_RB_CNTL, tmp); - } +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + +/* Double check that the overflow wasn't already cleared. */ + wptr =RREG32 (mmIH_RB_WPTR); + +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); + +/* When a ring buffer overflow happen start parsing interrupt +* from the last not overwritten vector (wptr + 16). Hopefully +* this should allow us to catchup. +*/ +dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , + wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); + ih->rptr = (wptr +16 ) & ih->ptr_mask; + tmp =RREG32 (mmIH_RB_CNTL); + tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); +WREG32 (mmIH_RB_CNTL, tmp); + + +out:return (wptr & ih->ptr_mask); }drivers/gpu/drm/amd/amdgpu/iceland_ih.c +23
-13@@ -193,19 +193,29 @@ static u32 iceland_ih_get_wptr(struct amdgpu_device *adev, wptr =le32_to_cpu (*ih->wptr_cpu); -if (REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) { - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); -/* When a ring buffer overflow happen start parsing interrupt -* from the last not overwritten vector (wptr + 16). Hopefully -* this should allow us to catchup. -*/ -dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , - wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); - ih->rptr = (wptr +16 ) & ih->ptr_mask; - tmp =RREG32 (mmIH_RB_CNTL); - tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); -WREG32 (mmIH_RB_CNTL, tmp); - } +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + +/* Double check that the overflow wasn't already cleared. */ + wptr =RREG32 (mmIH_RB_WPTR); + +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +/* When a ring buffer overflow happen start parsing interrupt +* from the last not overwritten vector (wptr + 16). Hopefully +* this should allow us to catchup. +*/ +dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , + wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); + ih->rptr = (wptr +16 ) & ih->ptr_mask; + tmp =RREG32 (mmIH_RB_CNTL); + tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); +WREG32 (mmIH_RB_CNTL, tmp); + + +out:return (wptr & ih->ptr_mask); }drivers/gpu/drm/amd/amdgpu/tonga_ih.c +17
-13@@ -195,19 +195,30 @@ static u32 tonga_ih_get_wptr(struct amdgpu_device *adev, wptr =le32_to_cpu (*ih->wptr_cpu); -if (REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) { - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); -/* When a ring buffer overflow happen start parsing interrupt -* from the last not overwritten vector (wptr + 16). Hopefully -* this should allow us to catchup. -*/ -dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , - wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); - ih->rptr = (wptr +16 ) & ih->ptr_mask; - tmp =RREG32 (mmIH_RB_CNTL); - tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); -WREG32 (mmIH_RB_CNTL, tmp); - } +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + +/* Double check that the overflow wasn't already cleared. */ + wptr =RREG32 (mmIH_RB_WPTR); + +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); + +/* When a ring buffer overflow happen start parsing interrupt +* from the last not overwritten vector (wptr + 16). Hopefully +* this should allow us to catchup. +*/ + + dev_warn(adev->dev, "IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n",
drivers/gpu/drm/amd/amdgpu/tonga_ih.c static u32 tonga_ih_get_wptr(struct amdgpu_device *adev, · line 224
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/tonga_ih.c +7
-0+ wptr, ih->rptr, (wptr + 16) & ih->ptr_mask); + ih->rptr = (wptr +16 ) & ih->ptr_mask; + tmp =RREG32 (mmIH_RB_CNTL); + tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); +WREG32 (mmIH_RB_CNTL, tmp); + +out:return (wptr & ih->ptr_mask); }
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Alex Deucher
AppliedQuoted 11 lines · Christian König
Am 05.01.21 um 17:06 schrieb Defang Bo:
Quoted 9 lines
Similar to commit <b82175750131>("drm/amdgpu: fix IH overflow on Vega10 v2"). When an ring buffer overflow happens the appropriate bit is set in the WPTR register which is also written back to memory. But clearing the bit in the WPTR doesn't trigger another memory writeback.
So what can happen is that we end up processing the buffer overflow over and over again because the bit is never cleared. Resulting in a random system lockup because of an infinite loop in an interrupt handler.
Quoted 6 lines
Quoted 1 line
Signed-off-by Defang Bo <[email protected]>Reviewed-by Christian König <[email protected]>Thanks for the help,
Christian.
Applied. Thanks!
Alex
Quoted 155 lines
Quoted 155 lines
---
Changes since v1:
- Modify the subject and replace the wrong register.
------ drivers/gpu/drm/amd/amdgpu/cz_ih.c | 39 +++++++++++++++++++++------------ drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 36 +++++++++++++++++++----------- drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 37 ++++++++++++++++++++----------- 3 files changed, 72 insertions(+), 40 deletions(-)drivers/gpu/drm/amd/amdgpu/cz_ih.c +25
-14@@ -190,22 +190,33 @@ static u32 cz_ih_get_wptr(struct amdgpu_device *adev, struct amdgpu_ih_ring *ih) {u32 wptr, tmp; - + wptr =le32_to_cpu (*ih->wptr_cpu); -if (REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) { - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); -/* When a ring buffer overflow happen start parsing interrupt -* from the last not overwritten vector (wptr + 16). Hopefully -* this should allow us to catchup. -*/ -dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , - wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); - ih->rptr = (wptr +16 ) & ih->ptr_mask; - tmp =RREG32 (mmIH_RB_CNTL); - tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); -WREG32 (mmIH_RB_CNTL, tmp); - } +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + +/* Double check that the overflow wasn't already cleared. */ + wptr =RREG32 (mmIH_RB_WPTR); + +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); + +/* When a ring buffer overflow happen start parsing interrupt +* from the last not overwritten vector (wptr + 16). Hopefully +* this should allow us to catchup. +*/ +dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , + wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); + ih->rptr = (wptr +16 ) & ih->ptr_mask; + tmp =RREG32 (mmIH_RB_CNTL); + tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); +WREG32 (mmIH_RB_CNTL, tmp); + + +out:return (wptr & ih->ptr_mask); }drivers/gpu/drm/amd/amdgpu/iceland_ih.c +23
-13@@ -193,19 +193,29 @@ static u32 iceland_ih_get_wptr(struct amdgpu_device *adev, wptr =le32_to_cpu (*ih->wptr_cpu); -if (REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) { - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); -/* When a ring buffer overflow happen start parsing interrupt -* from the last not overwritten vector (wptr + 16). Hopefully -* this should allow us to catchup. -*/ -dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , - wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); - ih->rptr = (wptr +16 ) & ih->ptr_mask; - tmp =RREG32 (mmIH_RB_CNTL); - tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); -WREG32 (mmIH_RB_CNTL, tmp); - } +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + +/* Double check that the overflow wasn't already cleared. */ + wptr =RREG32 (mmIH_RB_WPTR); + +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +/* When a ring buffer overflow happen start parsing interrupt +* from the last not overwritten vector (wptr + 16). Hopefully +* this should allow us to catchup. +*/ +dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , + wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); + ih->rptr = (wptr +16 ) & ih->ptr_mask; + tmp =RREG32 (mmIH_RB_CNTL); + tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); +WREG32 (mmIH_RB_CNTL, tmp); + + +out:return (wptr & ih->ptr_mask); }drivers/gpu/drm/amd/amdgpu/tonga_ih.c +24
-13@@ -195,19 +195,30 @@ static u32 tonga_ih_get_wptr(struct amdgpu_device *adev, wptr =le32_to_cpu (*ih->wptr_cpu); -if (REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) { - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); -/* When a ring buffer overflow happen start parsing interrupt -* from the last not overwritten vector (wptr + 16). Hopefully -* this should allow us to catchup. -*/ -dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , - wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); - ih->rptr = (wptr +16 ) & ih->ptr_mask; - tmp =RREG32 (mmIH_RB_CNTL); - tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); -WREG32 (mmIH_RB_CNTL, tmp); - } +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + +/* Double check that the overflow wasn't already cleared. */ + wptr =RREG32 (mmIH_RB_WPTR); + +if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) + goto out; + + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); + +/* When a ring buffer overflow happen start parsing interrupt +* from the last not overwritten vector (wptr + 16). Hopefully +* this should allow us to catchup. +*/ + +dev_warn (adev->dev,"IH ring buffer overflow (0x%08X, 0x%08X, 0x%08X)\n" , + wptr, ih->rptr, (wptr +16 ) & ih->ptr_mask); + ih->rptr = (wptr +16 ) & ih->ptr_mask; + tmp =RREG32 (mmIH_RB_CNTL); + tmp =REG_SET_FIELD (tmp,IH_RB_CNTL ,WPTR_OVERFLOW_CLEAR ,1 ); +WREG32 (mmIH_RB_CNTL, tmp); + +out:
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/tonga_ih.c static u32 tonga_ih_get_wptr(struct amdgpu_device *adev, · line 224
Quoted 3 lines
drivers/gpu/drm/amd/amdgpu/tonga_ih.c +0
-0return (wptr & ih->ptr_mask); }_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx